Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1713747 > unrolled thread
| Started by | Timo Alho <talho@nvidia.com> |
|---|---|
| First post | 2017-08-17 12:00 +0200 |
| Last post | 2017-08-17 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] firmware: tegra: set drvdata earlier Timo Alho <talho@nvidia.com> - 2017-08-17 12:00 +0200
Re: [PATCH] firmware: tegra: set drvdata earlier Thierry Reding <thierry.reding@gmail.com> - 2017-08-17 13:10 +0200
| From | Timo Alho <talho@nvidia.com> |
|---|---|
| Date | 2017-08-17 12:00 +0200 |
| Subject | [PATCH] firmware: tegra: set drvdata earlier |
| Message-ID | <ufpKO-33v-13@gated-at.bofh.it> |
Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's drvdata to be set during their probe. Currently this is not always the case. Fix this by calling platform_set_drvdata() earlier during bpmp's probe. Signed-off-by: Timo Alho <talho@nvidia.com> --- drivers/firmware/tegra/bpmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c index b251795..73ca55b 100644 --- a/drivers/firmware/tegra/bpmp.c +++ b/drivers/firmware/tegra/bpmp.c @@ -806,6 +806,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev) dev_info(&pdev->dev, "firmware: %s\n", tag); + platform_set_drvdata(pdev, bpmp); + err = of_platform_default_populate(pdev->dev.of_node, NULL, &pdev->dev); if (err < 0) goto free_mrq; @@ -822,8 +824,6 @@ static int tegra_bpmp_probe(struct platform_device *pdev) if (err < 0) goto free_mrq; - platform_set_drvdata(pdev, bpmp); - return 0; free_mrq: -- 2.7.4
[toc] | [next] | [standalone]
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2017-08-17 13:10 +0200 |
| Message-ID | <ufqQy-40w-23@gated-at.bofh.it> |
| In reply to | #1713747 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 17, 2017 at 12:49:11PM +0300, Timo Alho wrote: > Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's > drvdata to be set during their probe. Currently this is not always the > case. Fix this by calling platform_set_drvdata() earlier during bpmp's > probe. > > Signed-off-by: Timo Alho <talho@nvidia.com> > --- > drivers/firmware/tegra/bpmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-4.14/firmware, thanks. Thierry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web