Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712798 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-08-16 11:30 +0200 |
| Last post | 2017-08-16 22:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static Colin King <colin.king@canonical.com> - 2017-08-16 11:30 +0200
Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static David Lechner <david@lechnology.com> - 2017-08-16 17:50 +0200
Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static Noralf Trønnes <noralf@tronnes.org> - 2017-08-16 22:00 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-08-16 11:30 +0200 |
| Subject | [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static |
| Message-ID | <uf2Of-5hi-25@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function st7586_pipe_enable is local to the source
and does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'st7586_pipe_enable' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/tinydrm/st7586.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c
index 1b39d3fb17f7..e4f88564b18f 100644
--- a/drivers/gpu/drm/tinydrm/st7586.c
+++ b/drivers/gpu/drm/tinydrm/st7586.c
@@ -172,7 +172,7 @@ static const struct drm_framebuffer_funcs st7586_fb_funcs = {
.dirty = st7586_fb_dirty,
};
-void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,
+static void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,
struct drm_crtc_state *crtc_state)
{
struct tinydrm_device *tdev = pipe_to_tinydrm(pipe);
--
2.11.0
[toc] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2017-08-16 17:50 +0200 |
| Subject | Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static |
| Message-ID | <uf8JY-pO-13@gated-at.bofh.it> |
| In reply to | #1712798 |
On 08/16/2017 04:23 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The function st7586_pipe_enable is local to the source > and does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'st7586_pipe_enable' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Acked-By: David Lechner <david@lechnology.com>
[toc] | [prev] | [next] | [standalone]
| From | Noralf Trønnes <noralf@tronnes.org> |
|---|---|
| Date | 2017-08-16 22:00 +0200 |
| Subject | Re: [PATCH][drm-next] drm/tinydrm: make function st7586_pipe_enable static |
| Message-ID | <ufcDU-2Ry-23@gated-at.bofh.it> |
| In reply to | #1713073 |
Den 16.08.2017 17.46, skrev David Lechner: > On 08/16/2017 04:23 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> The function st7586_pipe_enable is local to the source >> and does not need to be in global scope, so make it static. >> >> Cleans up sparse warning: >> symbol 'st7586_pipe_enable' was not declared. Should it be static? >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- > > Acked-By: David Lechner <david@lechnology.com> Thanks, applied to drm-misc. Noralf.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web