Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714249 > unrolled thread

[PATCH] tpm: vtpm: constify vio_device_id

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-17 19:40 +0200
Last post2017-08-23 16:10 +0200
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] tpm: vtpm: constify vio_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-17 19:40 +0200
    Re: [PATCH] tpm: vtpm: constify vio_device_id Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-08-17 21:20 +0200
      Re: [PATCH] tpm: vtpm: constify vio_device_id Michael Ellerman <mpe@ellerman.id.au> - 2017-08-18 13:40 +0200
        Re: [PATCH] tpm: vtpm: constify vio_device_id Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-08-18 22:40 +0200
          Re: [PATCH] tpm: vtpm: constify vio_device_id Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-08-19 19:30 +0200
            Re: [PATCH] tpm: vtpm: constify vio_device_id Michael Ellerman <mpe@ellerman.id.au> - 2017-08-23 16:10 +0200

#1714249 — [PATCH] tpm: vtpm: constify vio_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-17 19:40 +0200
Subject[PATCH] tpm: vtpm: constify vio_device_id
Message-ID<ufwVX-82Z-9@gated-at.bofh.it>
vio_device_id are not supposed to change at runtime. All functions
working with vio_device_id provided by <asm/vio.h> work with
const vio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index f01d083..d2ce46b 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -32,7 +32,7 @@
 
 static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
 
-static struct vio_device_id tpm_ibmvtpm_device_table[] = {
+static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
 	{ "IBM,vtpm", "IBM,vtpm"},
 	{ "", "" }
 };
-- 
2.7.4

[toc] | [next] | [standalone]

#1714331

FromJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date2017-08-17 21:20 +0200
Message-ID<ufyuK-KQ-27@gated-at.bofh.it>
In reply to#1714249
On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083..d2ce46b 100644
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -32,7 +32,7 @@
>  
>  static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
>  
> -static struct vio_device_id tpm_ibmvtpm_device_table[] = {
> +static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
>  	{ "IBM,vtpm", "IBM,vtpm"},
>  	{ "", "" }
>  };

[toc] | [prev] | [next] | [standalone]

#1714815

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-08-18 13:40 +0200
Message-ID<ufNN7-346-1@gated-at.bofh.it>
In reply to#1714331
Jason Gunthorpe <jgunthorpe@obsidianresearch.com> writes:

> On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
>> vio_device_id are not supposed to change at runtime. All functions
>> working with vio_device_id provided by <asm/vio.h> work with
>> const vio_device_id. So mark the non-const structs as const.
>> 
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Thanks Jason.

>>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-

Who merges changes for this driver? I assume it's Jarkko?

cheers

[toc] | [prev] | [next] | [standalone]

#1715450

FromJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date2017-08-18 22:40 +0200
Message-ID<ufWdI-9E-9@gated-at.bofh.it>
In reply to#1714815
On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:

> >>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> 
> Who merges changes for this driver? I assume it's Jarkko?

Yes

Jason

[toc] | [prev] | [next] | [standalone]

#1715694

FromJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Date2017-08-19 19:30 +0200
Message-ID<ugfJn-48Q-1@gated-at.bofh.it>
In reply to#1715450
On Fri, Aug 18, 2017 at 02:31:56PM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:
> 
> > >>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> > 
> > Who merges changes for this driver? I assume it's Jarkko?
> 
> Yes
> 
> Jason

Applied.

/Jarkko

[toc] | [prev] | [next] | [standalone]

#1718392

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-08-23 16:10 +0200
Message-ID<uhEw2-1x1-27@gated-at.bofh.it>
In reply to#1715694
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> writes:

> On Fri, Aug 18, 2017 at 02:31:56PM -0600, Jason Gunthorpe wrote:
>> On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:
>> 
>> > >>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>> > 
>> > Who merges changes for this driver? I assume it's Jarkko?
>> 
>> Yes
>> 
>> Jason
>
> Applied.

Thanks.

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web