Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1714998 > unrolled thread

[PATCH 3.16 073/134] IB/mlx4: Fix ib device initialization error flow

Started byBen Hutchings <ben@decadent.org.uk>
First post2017-08-18 15:40 +0200
Last post2017-08-18 15:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3.16 073/134] IB/mlx4: Fix ib device initialization error flow Ben Hutchings <ben@decadent.org.uk> - 2017-08-18 15:40 +0200

#1714998 — [PATCH 3.16 073/134] IB/mlx4: Fix ib device initialization error flow

FromBen Hutchings <ben@decadent.org.uk>
Date2017-08-18 15:40 +0200
Subject[PATCH 3.16 073/134] IB/mlx4: Fix ib device initialization error flow
Message-ID<ufPFh-4ln-39@gated-at.bofh.it>
3.16.47-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Jack Morgenstein <jackm@dev.mellanox.co.il>

commit 99e68909d5aba1861897fe7afc3306c3c81b6de0 upstream.

In mlx4_ib_add, procedure mlx4_ib_alloc_eqs is called to allocate EQs.

However, in the mlx4_ib_add error flow, procedure mlx4_ib_free_eqs is not
called to free the allocated EQs.

Fixes: e605b743f33d ("IB/mlx4: Increase the number of vectors (EQs) available for ULPs")
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 drivers/infiniband/hw/mlx4/main.c | 1 +
 1 file changed, 1 insertion(+)

--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -2281,6 +2281,7 @@ err_counter:
 			mlx4_counter_free(ibdev->dev, ibdev->counters[i - 1]);
 
 err_map:
+	mlx4_ib_free_eqs(dev, ibdev);
 	iounmap(ibdev->uar_map);
 
 err_uar:

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web