Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714996 > unrolled thread

[PATCH 0/3] JFS: Adjustments for several function implementations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] JFS: Adjustments for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-18 15:40 +0200
    [PATCH 1/3] jfs: Delete an error message for a failed memory  allocation in diMount() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-18 15:40 +0200

#1714996 — [PATCH 0/3] JFS: Adjustments for several function implementations

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 18 Aug 2017 15:22:11 +0200

Three update suggestions were taken into account
from static source code analysis.

Markus Elfring (3):
  Delete an error message for a failed memory allocation in diMount()
  Improve size determinations in five functions
  Adjust 67 checks for null pointers

 fs/jfs/jfs_dmap.c     | 44 ++++++++++++++++++++++----------------------
 fs/jfs/jfs_dtree.c    |  6 +++---
 fs/jfs/jfs_imap.c     | 31 ++++++++++++++-----------------
 fs/jfs/jfs_logmgr.c   | 26 ++++++++++++++------------
 fs/jfs/jfs_metapage.c |  7 +++----
 fs/jfs/jfs_mount.c    |  6 +++---
 fs/jfs/jfs_txnmgr.c   |  6 +++---
 fs/jfs/jfs_unicode.c  |  3 +--
 fs/jfs/jfs_xtree.c    |  6 +++---
 fs/jfs/namei.c        |  3 +--
 fs/jfs/resize.c       |  2 +-
 fs/jfs/super.c        |  6 +++---
 fs/jfs/xattr.c        | 10 +++++-----
 13 files changed, 76 insertions(+), 80 deletions(-)

-- 
2.14.0

[toc] | [next] | [standalone]

#1714997 — [PATCH 1/3] jfs: Delete an error message for a failed memory allocation in diMount()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 18 Aug 2017 09:19:24 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 fs/jfs/jfs_imap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c
index f36ef68905a7..da8051299e47 100644
--- a/fs/jfs/jfs_imap.c
+++ b/fs/jfs/jfs_imap.c
@@ -119,7 +119,5 @@ int diMount(struct inode *ipimap)
-	if (imap == NULL) {
-		jfs_err("diMount: kmalloc returned NULL!");
+	if (!imap)
 		return -ENOMEM;
-	}
 
 	/* read the on-disk inode map control structure. */
 
-- 
2.14.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web