Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714345 > unrolled thread

[PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup Waiman Long <longman@redhat.com> - 2017-08-17 21:40 +0200
    Re: [PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup Tejun Heo <tj@kernel.org> - 2017-08-18 13:40 +0200
      Re: [PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup Waiman Long <longman@redhat.com> - 2017-08-18 15:50 +0200

#1714345 — [PATCH v3 0/2] cpuset: Allow v2 behavior in v1 cgroup

v2->v3:
 - Change the generic CGRP_ROOT_V2_MODE flag to a cpuset specific
   CGRP_ROOT_CPUSET_V2_MODE flag.

v1->v2:
 - Drop the kernel command line option and use cgroupfs mount option
   instead to enable v2 controller behavior in v1 cgroup.

v1: https://lkml.org/lkml/2017/8/15/570

This patchset adds a new cgroupfs mount option "cpuset_v2_mode"
that enables the cpuset controller to use v2 behavior in a v1 cgroup.

Patch 1 adds the v1 cgroupfs mount option "cpuset_v2_mode" which set
a flag in the cgroup_root flags.

Patch 2 modifies the cpuset controller to check the cgroup_root flag
and switch to v2 behavior even in a v1 cgroup.

Waiman Long (2):
  cgroup: Add mount flag to enable cpuset to use v2 behavior in v1
    cgroup
  cpuset: Allow v2 behavior in v1 cgroup

 include/linux/cgroup-defs.h |  5 +++++
 kernel/cgroup/cgroup-v1.c   |  6 ++++++
 kernel/cgroup/cpuset.c      | 33 ++++++++++++++++++++-------------
 3 files changed, 31 insertions(+), 13 deletions(-)

-- 
1.8.3.1

[toc] | [next] | [standalone]

#1714823

On Thu, Aug 17, 2017 at 03:33:08PM -0400, Waiman Long wrote:
> v2->v3:
>  - Change the generic CGRP_ROOT_V2_MODE flag to a cpuset specific
>    CGRP_ROOT_CPUSET_V2_MODE flag.
> 
> v1->v2:
>  - Drop the kernel command line option and use cgroupfs mount option
>    instead to enable v2 controller behavior in v1 cgroup.
> 
> v1: https://lkml.org/lkml/2017/8/15/570

Waiman, patches look good to me but can you please take care of the
kbuild warnings on 32bit and maybe merge the two patches into one?

Thanks.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1715061

On 08/18/2017 07:29 AM, Tejun Heo wrote:
> On Thu, Aug 17, 2017 at 03:33:08PM -0400, Waiman Long wrote:
>> v2->v3:
>>  - Change the generic CGRP_ROOT_V2_MODE flag to a cpuset specific
>>    CGRP_ROOT_CPUSET_V2_MODE flag.
>>
>> v1->v2:
>>  - Drop the kernel command line option and use cgroupfs mount option
>>    instead to enable v2 controller behavior in v1 cgroup.
>>
>> v1: https://lkml.org/lkml/2017/8/15/570
> Waiman, patches look good to me but can you please take care of the
> kbuild warnings on 32bit and maybe merge the two patches into one?

The kbuild warning is in the __init code of the v1 patch for checking
the boot time argument. The __init code was gone in the v3 patch. So if
there is no further kbuild warning after a couple of days, I think it
should be OK.

Cheers,
Longman

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web