Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714557 > unrolled thread

[PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

Started byKai-Heng Feng <kai.heng.feng@canonical.com>
First post2017-08-18 06:30 +0200
Last post2017-08-18 10:20 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-08-18 06:30 +0200
    Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-18 09:30 +0200
      Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-08-18 10:10 +0200
        Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-18 10:20 +0200

#1714557 — [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

FromKai-Heng Feng <kai.heng.feng@canonical.com>
Date2017-08-18 06:30 +0200
Subject[PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk
Message-ID<ufH4Z-6G8-1@gated-at.bofh.it>
When plugging Logitech C920 webcam, warning messages filled up dmesg:
[77117.655018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
[77117.659018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
[77122.622952] handle_tx_event: 541 callbacks suppressed

No more warning messages with XHCI_TRUST_TX_LENGTH applied.

BugLink: https://bugs.launchpad.net/bugs/1710548
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 8071c8fdd15e..8566b43e19ba 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -202,8 +202,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->quirks |= XHCI_BROKEN_STREAMS;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
-			pdev->device == 0x0015)
+			pdev->device == 0x0015) {
 		xhci->quirks |= XHCI_RESET_ON_RESUME;
+		xhci->quirks |= XHCI_TRUST_TX_LENGTH;
+	}
 	if (pdev->vendor == PCI_VENDOR_ID_VIA)
 		xhci->quirks |= XHCI_RESET_ON_RESUME;
 
-- 
2.14.1

[toc] | [next] | [standalone]

#1714630

FromFelipe Balbi <felipe.balbi@linux.intel.com>
Date2017-08-18 09:30 +0200
Message-ID<ufJTc-7z-9@gated-at.bofh.it>
In reply to#1714557

[Multipart message — attachments visible in raw view] — view raw

hi,

Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
> When plugging Logitech C920 webcam, warning messages filled up dmesg:
> [77117.655018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
> [77117.659018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?

have you confirmed this is needed for this controller? Anybody from
Renesas has confirmed it? Do you have an errata document to refer to?

> [77122.622952] handle_tx_event: 541 callbacks suppressed
>
> No more warning messages with XHCI_TRUST_TX_LENGTH applied.
>
> BugLink: https://bugs.launchpad.net/bugs/1710548
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/usb/host/xhci-pci.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 8071c8fdd15e..8566b43e19ba 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -202,8 +202,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_BROKEN_STREAMS;
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> -			pdev->device == 0x0015)
> +			pdev->device == 0x0015) {

unnecessary

>  		xhci->quirks |= XHCI_RESET_ON_RESUME;
> +		xhci->quirks |= XHCI_TRUST_TX_LENGTH;

		xhci->quirks |= XHCI_RESET_ON_RESUME |
                		XHCI_TRUST_TX_LENGTH;

> +	}

unnecessary

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1714662

FromKai-Heng Feng <kai.heng.feng@canonical.com>
Date2017-08-18 10:10 +0200
Message-ID<ufKvT-Mj-9@gated-at.bofh.it>
In reply to#1714630
Hi,

On Fri, Aug 18, 2017 at 3:22 PM, Felipe Balbi
<felipe.balbi@linux.intel.com> wrote:
>
> hi,
>
> Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>> When plugging Logitech C920 webcam, warning messages filled up dmesg:
>> [77117.655018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
>> [77117.659018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
>
> have you confirmed this is needed for this controller?
I just found commit d2f48f05cd2a2 ("usb: xhci: ASMedia ASM1042A
chipset need shorts TX quirk") and did the same thing for this
controller.

> Anybody from Renesas has confirmed it?
No, it's a user reported problem, please check the bug report in the link.

> Do you have an errata document to refer to?
No. Probably need Renesas guy to provide it.

>
>> [77122.622952] handle_tx_event: 541 callbacks suppressed
>>
>> No more warning messages with XHCI_TRUST_TX_LENGTH applied.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1710548
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>>  drivers/usb/host/xhci-pci.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>> index 8071c8fdd15e..8566b43e19ba 100644
>> --- a/drivers/usb/host/xhci-pci.c
>> +++ b/drivers/usb/host/xhci-pci.c
>> @@ -202,8 +202,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>>               xhci->quirks |= XHCI_BROKEN_STREAMS;
>>       }
>>       if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
>> -                     pdev->device == 0x0015)
>> +                     pdev->device == 0x0015) {
>
> unnecessary
>
>>               xhci->quirks |= XHCI_RESET_ON_RESUME;
>> +             xhci->quirks |= XHCI_TRUST_TX_LENGTH;
>
>                 xhci->quirks |= XHCI_RESET_ON_RESUME |
>                                 XHCI_TRUST_TX_LENGTH;
>
>> +     }
>
> unnecessary

Do you mean that this quirk just hide the warning, it doesn't fix the
root cause?

>
> --
> balbi

[toc] | [prev] | [next] | [standalone]

#1714667

FromFelipe Balbi <felipe.balbi@linux.intel.com>
Date2017-08-18 10:20 +0200
Message-ID<ufKFz-RX-5@gated-at.bofh.it>
In reply to#1714662
Hi,

Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>>> When plugging Logitech C920 webcam, warning messages filled up dmesg:
>>> [77117.655018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
>>> [77117.659018] xhci_hcd 0000:0c:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk?
>>
>> have you confirmed this is needed for this controller?
> I just found commit d2f48f05cd2a2 ("usb: xhci: ASMedia ASM1042A
> chipset need shorts TX quirk") and did the same thing for this
> controller.
>
>> Anybody from Renesas has confirmed it?
> No, it's a user reported problem, please check the bug report in the link.
>
>> Do you have an errata document to refer to?
> No. Probably need Renesas guy to provide it.

or confirm it. Yoshihiro, do you know if this is needed?

>>> [77122.622952] handle_tx_event: 541 callbacks suppressed
>>>
>>> No more warning messages with XHCI_TRUST_TX_LENGTH applied.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1710548
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>> ---
>>>  drivers/usb/host/xhci-pci.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>>> index 8071c8fdd15e..8566b43e19ba 100644
>>> --- a/drivers/usb/host/xhci-pci.c
>>> +++ b/drivers/usb/host/xhci-pci.c
>>> @@ -202,8 +202,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>>>               xhci->quirks |= XHCI_BROKEN_STREAMS;
>>>       }
>>>       if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
>>> -                     pdev->device == 0x0015)
>>> +                     pdev->device == 0x0015) {
>>
>> unnecessary
>>
>>>               xhci->quirks |= XHCI_RESET_ON_RESUME;
>>> +             xhci->quirks |= XHCI_TRUST_TX_LENGTH;
>>
>>                 xhci->quirks |= XHCI_RESET_ON_RESUME |
>>                                 XHCI_TRUST_TX_LENGTH;
>>
>>> +     }
>>
>> unnecessary
>
> Do you mean that this quirk just hide the warning, it doesn't fix the
> root cause?

no, I meant that you need to add {} if you make a single statement out
of the quirks.

-- 
balbi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web