Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1714507 > unrolled thread
| Started by | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| First post | 2017-08-18 03:30 +0200 |
| Last post | 2017-08-18 08:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-08-18 03:30 +0200
Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API Coly Li <i@coly.li> - 2017-08-18 08:10 +0200
Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-08-18 08:20 +0200
| From | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| Date | 2017-08-18 03:30 +0200 |
| Subject | Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API |
| Message-ID | <ufEgO-4CU-3@gated-at.bofh.it> |
On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.
Any opinions about this?
>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> Acked-by: Coly Li <colyli@suse.de>
> ---
> drivers/md/bcache/closure.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> index 864e673..7d5286b 100644
> --- a/drivers/md/bcache/closure.c
> +++ b/drivers/md/bcache/closure.c
> @@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
> list = llist_del_all(&wait_list->list);
>
> /* We first reverse the list to preserve FIFO ordering and fairness */
> -
> - while (list) {
> - struct llist_node *t = list;
> - list = llist_next(list);
> -
> - t->next = reverse;
> - reverse = t;
> - }
> + reverse = llist_reverse_order(list);
>
> /* Then do the wakeups */
> -
> - while (reverse) {
> - cl = container_of(reverse, struct closure, list);
> - reverse = llist_next(reverse);
> -
> + llist_for_each_entry(cl, reverse, list) {
> closure_set_waiting(cl, 0);
> closure_sub(cl, CLOSURE_WAITING + 1);
> }
> --
> 1.9.1
[toc] | [next] | [standalone]
| From | Coly Li <i@coly.li> |
|---|---|
| Date | 2017-08-18 08:10 +0200 |
| Message-ID | <ufIDL-7Ok-11@gated-at.bofh.it> |
| In reply to | #1714507 |
On 2017/8/18 上午9:24, Byungchul Park wrote:
> On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote:
>> Although llist provides proper APIs, they are not used. Make them used.
>
> Any opinions about this?
>
The patch is good. If Eric has no time, I will take care of it later.
Thanks.
Coly
>>
>> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
>> Acked-by: Coly Li <colyli@suse.de>
>> ---
>> drivers/md/bcache/closure.c | 15 ++-------------
>> 1 file changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
>> index 864e673..7d5286b 100644
>> --- a/drivers/md/bcache/closure.c
>> +++ b/drivers/md/bcache/closure.c
>> @@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
>> list = llist_del_all(&wait_list->list);
>>
>> /* We first reverse the list to preserve FIFO ordering and fairness */
>> -
>> - while (list) {
>> - struct llist_node *t = list;
>> - list = llist_next(list);
>> -
>> - t->next = reverse;
>> - reverse = t;
>> - }
>> + reverse = llist_reverse_order(list);
>>
>> /* Then do the wakeups */
>> -
>> - while (reverse) {
>> - cl = container_of(reverse, struct closure, list);
>> - reverse = llist_next(reverse);
>> -
>> + llist_for_each_entry(cl, reverse, list) {
>> closure_set_waiting(cl, 0);
>> closure_sub(cl, CLOSURE_WAITING + 1);
>> }
>> --
>> 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Byungchul Park <byungchul.park@lge.com> |
|---|---|
| Date | 2017-08-18 08:20 +0200 |
| Message-ID | <ufINr-7RS-7@gated-at.bofh.it> |
| In reply to | #1714590 |
On Fri, Aug 18, 2017 at 02:04:20PM +0800, Coly Li wrote: > On 2017/8/18 上午9:24, Byungchul Park wrote: > > On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote: > >> Although llist provides proper APIs, they are not used. Make them used. > > > > Any opinions about this? > > > > The patch is good. If Eric has no time, I will take care of it later. Hi, Coly Thanks a lot. :)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web