Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712787 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-08-16 11:20 +0200 |
| Last post | 2017-08-21 14:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] [media]: make snd_kcontrol_new const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-16 11:20 +0200
[PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-16 11:20 +0200
Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const Ismael Luceno <ismael@iodev.co.uk> - 2017-08-21 14:20 +0200
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-16 11:20 +0200 |
| Subject | [PATCH 0/2] [media]: make snd_kcontrol_new const |
| Message-ID | <uf2Ey-5e4-13@gated-at.bofh.it> |
Make these const. Done using Coccinelle. Bhumika Goyal (2): [media] cx88: make snd_kcontrol_new const [media] solo6x10: make snd_kcontrol_new const drivers/media/pci/cx88/cx88-alsa.c | 2 +- drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-08-16 11:20 +0200 |
| Subject | [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const |
| Message-ID | <uf2Ey-5e4-19@gated-at.bofh.it> |
| In reply to | #1712787 |
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
index 3ca9470..81be1b8 100644
--- a/drivers/media/pci/solo6x10/solo6x10-g723.c
+++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
@@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
return 1;
}
-static struct snd_kcontrol_new snd_solo_capture_volume = {
+static const struct snd_kcontrol_new snd_solo_capture_volume = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "Capture Volume",
.info = snd_solo_capture_volume_info,
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Ismael Luceno <ismael@iodev.co.uk> |
|---|---|
| Date | 2017-08-21 14:20 +0200 |
| Subject | Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const |
| Message-ID | <ugTQt-4ge-3@gated-at.bofh.it> |
| In reply to | #1712789 |
[Multipart message — attachments visible in raw view] — view raw
On 16/Aug/2017 14:47, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
> index 3ca9470..81be1b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
> @@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
> return 1;
> }
>
> -static struct snd_kcontrol_new snd_solo_capture_volume = {
> +static const struct snd_kcontrol_new snd_solo_capture_volume = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Capture Volume",
> .info = snd_solo_capture_volume_info,
> --
> 1.9.1
>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web