Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1711402 > unrolled thread

Re: [PATCH] selftests: timers: freq-step: fix compile error

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] selftests: timers: freq-step: fix compile error Shuah Khan <shuahkh@osg.samsung.com> - 2017-08-14 22:20 +0200
    Re: [PATCH] selftests: timers: freq-step: fix compile error John Stultz <john.stultz@linaro.org> - 2017-08-14 22:40 +0200
    Re: [PATCH] selftests: timers: freq-step: fix compile error John Stultz <john.stultz@linaro.org> - 2017-08-14 23:00 +0200

#1711402 — Re: [PATCH] selftests: timers: freq-step: fix compile error

On 08/14/2017 02:12 PM, John Stultz wrote:
> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>
>> freq-step.c: In function ‘init_test’:
>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>    ksft_exit_skip();
>>    ^~~~~~~~~~~~~~
>> In file included from freq-step.c:26:0:
>> ../kselftest.h:167:19: note: declared here
>>  static inline int ksft_exit_skip(const char *msg, ...)
>>                    ^~~~~~~~~~~~~~
>> <builtin>: recipe for target 'freq-step' failed
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> 
> 
> Acked-by: John Stultz <john.stultz@linaro.org>
> 
> This is a build regression in 4.13-rc so should go-to Linus promptly.
> 
> (Shuah: Let me know if you want me to send this in via Thomas, or you
> want to send it in directly)
> 
> thanks
> -john
> 

John,

I am planning to send it to Linus with a few other fixes in linux-kselftest
fixes branch for 4.13-rc6

thanks,
-- Shuah

[toc] | [next] | [standalone]

#1711429

On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 08/14/2017 02:12 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>>
>>> freq-step.c: In function ‘init_test’:
>>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>>    ksft_exit_skip();
>>>    ^~~~~~~~~~~~~~
>>> In file included from freq-step.c:26:0:
>>> ../kselftest.h:167:19: note: declared here
>>>  static inline int ksft_exit_skip(const char *msg, ...)
>>>                    ^~~~~~~~~~~~~~
>>> <builtin>: recipe for target 'freq-step' failed
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>
>>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> This is a build regression in 4.13-rc so should go-to Linus promptly.
>>
>> (Shuah: Let me know if you want me to send this in via Thomas, or you
>> want to send it in directly)
>>
>> thanks
>> -john
>>
>
> John,
>
> I am planning to send it to Linus with a few other fixes in linux-kselftest
> fixes branch for 4.13-rc6

Great! Thanks again for sending this out and sorry for not replying sooner!

-john

[toc] | [prev] | [next] | [standalone]

#1711447

On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 08/14/2017 02:12 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>>
>>> freq-step.c: In function ‘init_test’:
>>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>>    ksft_exit_skip();
>>>    ^~~~~~~~~~~~~~
>>> In file included from freq-step.c:26:0:
>>> ../kselftest.h:167:19: note: declared here
>>>  static inline int ksft_exit_skip(const char *msg, ...)
>>>                    ^~~~~~~~~~~~~~
>>> <builtin>: recipe for target 'freq-step' failed
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>
>>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> This is a build regression in 4.13-rc so should go-to Linus promptly.
>>
>> (Shuah: Let me know if you want me to send this in via Thomas, or you
>> want to send it in directly)
>>
>> thanks
>> -john
>>
>
> John,
>
> I am planning to send it to Linus with a few other fixes in linux-kselftest
> fixes branch for 4.13-rc6

I also have two more less critical build fixups to that test to add,
which I'll send out here in a second for review.

thanks
-john

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web