Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710829 > unrolled thread
| Started by | Cihangir Akturk <cakturk@gmail.com> |
|---|---|
| First post | 2017-08-14 13:10 +0200 |
| Last post | 2017-08-14 22:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Cihangir Akturk <cakturk@gmail.com> - 2017-08-14 13:10 +0200
Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Steve Longerbeam <slongerbeam@gmail.com> - 2017-08-14 20:00 +0200
Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Cihangir Akturk <cakturk@gmail.com> - 2017-08-14 22:20 +0200
| From | Cihangir Akturk <cakturk@gmail.com> |
|---|---|
| Date | 2017-08-14 13:10 +0200 |
| Subject | [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API |
| Message-ID | <uelpT-3qt-9@gated-at.bofh.it> |
This driver uses various v4l2_subdev_get_try_*() functions provided by V4L2 sub-device userspace API. Current configuration of Kconfig file allows us to enable VIDEO_IMX_MEDIA without enabling this API. This breaks the build of driver. Depend on VIDEO_V4L2_SUBDEV_API to fix this issue. Signed-off-by: Cihangir Akturk <cakturk@gmail.com> --- drivers/staging/media/imx/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig index 7eff50b..d8c3890 100644 --- a/drivers/staging/media/imx/Kconfig +++ b/drivers/staging/media/imx/Kconfig @@ -1,6 +1,7 @@ config VIDEO_IMX_MEDIA tristate "i.MX5/6 V4L2 media core driver" - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \ + ARCH_MXC && IMX_IPUV3_CORE select V4L2_FWNODE ---help--- Say yes here to enable support for video4linux media controller -- 2.7.4
[toc] | [next] | [standalone]
| From | Steve Longerbeam <slongerbeam@gmail.com> |
|---|---|
| Date | 2017-08-14 20:00 +0200 |
| Subject | Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API |
| Message-ID | <uerOF-79Q-9@gated-at.bofh.it> |
| In reply to | #1710829 |
Hi Akturk, this has already been fixed, see
4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
Steve
On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> This driver uses various v4l2_subdev_get_try_*() functions provided by
> V4L2 sub-device userspace API. Current configuration of Kconfig file
> allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> breaks the build of driver.
>
> Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50b..d8c3890 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> + ARCH_MXC && IMX_IPUV3_CORE
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
[toc] | [prev] | [next] | [standalone]
| From | Cihangir Akturk <cakturk@gmail.com> |
|---|---|
| Date | 2017-08-14 22:20 +0200 |
| Subject | Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API |
| Message-ID | <ueu0b-dy-29@gated-at.bofh.it> |
| In reply to | #1711300 |
On Mon, Aug 14, 2017 at 10:57:46AM -0700, Steve Longerbeam wrote:
> Hi Akturk, this has already been fixed, see
Sorry. Apparently, I missed to update my tree, somehow.
>
> 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
>
> Steve
>
> On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> > This driver uses various v4l2_subdev_get_try_*() functions provided by
> > V4L2 sub-device userspace API. Current configuration of Kconfig file
> > allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> > breaks the build of driver.
> >
> > Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
> >
> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> > ---
> > drivers/staging/media/imx/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> > index 7eff50b..d8c3890 100644
> > --- a/drivers/staging/media/imx/Kconfig
> > +++ b/drivers/staging/media/imx/Kconfig
> > @@ -1,6 +1,7 @@
> > config VIDEO_IMX_MEDIA
> > tristate "i.MX5/6 V4L2 media core driver"
> > - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> > + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> > + ARCH_MXC && IMX_IPUV3_CORE
> > select V4L2_FWNODE
> > ---help---
> > Say yes here to enable support for video4linux media controller
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web