Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710465 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-13 11:50 +0200 |
| Last post | 2017-08-22 15:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] CPUFREQ: Loongson2: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-13 11:50 +0200
Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id Viresh Kumar <viresh.kumar@linaro.org> - 2017-08-16 05:30 +0200
Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-22 15:40 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-13 11:50 +0200 |
| Subject | [PATCH] CPUFREQ: Loongson2: constify platform_device_id |
| Message-ID | <udXGW-5y4-11@gated-at.bofh.it> |
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/cpufreq/loongson2_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
index 9ac27b2..da34469 100644
--- a/drivers/cpufreq/loongson2_cpufreq.c
+++ b/drivers/cpufreq/loongson2_cpufreq.c
@@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
.attr = cpufreq_generic_attr,
};
-static struct platform_device_id platform_device_ids[] = {
+static const struct platform_device_id platform_device_ids[] = {
{
.name = "loongson2_cpufreq",
},
--
2.7.4
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-08-16 05:30 +0200 |
| Message-ID | <ueXbP-1L3-1@gated-at.bofh.it> |
| In reply to | #1710465 |
On 13-08-17, 15:10, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> index 9ac27b2..da34469 100644
> --- a/drivers/cpufreq/loongson2_cpufreq.c
> +++ b/drivers/cpufreq/loongson2_cpufreq.c
> @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
> .attr = cpufreq_generic_attr,
> };
>
> -static struct platform_device_id platform_device_ids[] = {
> +static const struct platform_device_id platform_device_ids[] = {
> {
> .name = "loongson2_cpufreq",
> },
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-08-22 15:40 +0200 |
| Message-ID | <uhhzs-31r-7@gated-at.bofh.it> |
| In reply to | #1712629 |
On Wednesday, August 16, 2017 5:25:59 AM CEST Viresh Kumar wrote:
> On 13-08-17, 15:10, Arvind Yadav wrote:
> > platform_device_id are not supposed to change at runtime. All functions
> > working with platform_device_id provided by <linux/platform_device.h>
> > work with const platform_device_id. So mark the non-const structs as
> > const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> > index 9ac27b2..da34469 100644
> > --- a/drivers/cpufreq/loongson2_cpufreq.c
> > +++ b/drivers/cpufreq/loongson2_cpufreq.c
> > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
> > .attr = cpufreq_generic_attr,
> > };
> >
> > -static struct platform_device_id platform_device_ids[] = {
> > +static const struct platform_device_id platform_device_ids[] = {
> > {
> > .name = "loongson2_cpufreq",
> > },
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Applied, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web