Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712173 > unrolled thread
| Started by | Jun Gao <jun.gao@mediatek.com> |
|---|---|
| First post | 2017-08-15 15:10 +0200 |
| Last post | 2017-08-16 04:30 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao <jun.gao@mediatek.com> - 2017-08-15 15:10 +0200
[PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao <jun.gao@mediatek.com> - 2017-08-15 15:10 +0200
Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Sean Wang <sean.wang@mediatek.com> - 2017-08-16 05:10 +0200
[PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao <jun.gao@mediatek.com> - 2017-08-15 15:10 +0200
Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Sean Wang <sean.wang@mediatek.com> - 2017-08-16 04:30 +0200
| From | Jun Gao <jun.gao@mediatek.com> |
|---|---|
| Date | 2017-08-15 15:10 +0200 |
| Subject | [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC |
| Message-ID | <ueJLA-1Ix-13@gated-at.bofh.it> |
This patch series based on v4.13-rc1, include MT7622 i2c dt-binding and compatible. changes since v2: - Remove all the length settings from mt7622_i2c_quirks changes since v1: - Modify commit message - Revise dt-binding documentation Jun Gao (2): dt-bindings: i2c: Add MediaTek MT7622 i2c binding i2c: mediatek: Add i2c compatible for MediaTek MT7622 Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 5 deletions(-) -- 1.8.1.1
[toc] | [next] | [standalone]
| From | Jun Gao <jun.gao@mediatek.com> |
|---|---|
| Date | 2017-08-15 15:10 +0200 |
| Subject | [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 |
| Message-ID | <ueJLA-1Ix-15@gated-at.bofh.it> |
| In reply to | #1712173 |
From: Jun Gao <jun.gao@mediatek.com>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..09d288c 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,10 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +194,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +214,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
[toc] | [prev] | [next] | [standalone]
| From | Sean Wang <sean.wang@mediatek.com> |
|---|---|
| Date | 2017-08-16 05:10 +0200 |
| Subject | Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 |
| Message-ID | <ueWSt-1ER-7@gated-at.bofh.it> |
| In reply to | #1712174 |
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limits message numbers to 255, and does not support 4GB
> DMA mode.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
you seemed missing a Reviewed-by tag from Joe.C
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009975.html
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 9bedf0b..09d288c 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,6 +172,10 @@ struct mtk_i2c {
> .max_comb_2nd_msg_len = 31,
> };
>
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> +};
> +
> static const struct mtk_i2c_compatible mt6577_compat = {
> .quirks = &mt6577_i2c_quirks,
> .pmic_i2c = 0,
> @@ -190,6 +194,15 @@ struct mtk_i2c {
> .support_33bits = 0,
> };
>
> +static const struct mtk_i2c_compatible mt7622_compat = {
> + .quirks = &mt7622_i2c_quirks,
> + .pmic_i2c = 0,
> + .dcm = 1,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .support_33bits = 0,
> +};
> +
> static const struct mtk_i2c_compatible mt8173_compat = {
> .pmic_i2c = 0,
> .dcm = 1,
> @@ -201,6 +214,7 @@ struct mtk_i2c {
> static const struct of_device_id mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> {}
> };
[toc] | [prev] | [next] | [standalone]
| From | Jun Gao <jun.gao@mediatek.com> |
|---|---|
| Date | 2017-08-15 15:10 +0200 |
| Subject | [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding |
| Message-ID | <ueJLA-1Ix-19@gated-at.bofh.it> |
| In reply to | #1712173 |
From: Jun Gao <jun.gao@mediatek.com>
Add MT7622 i2c binding to binding file and change the compatible
information formats of all SoCs to the same.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..71fc0b3 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
[toc] | [prev] | [next] | [standalone]
| From | Sean Wang <sean.wang@mediatek.com> |
|---|---|
| Date | 2017-08-16 04:30 +0200 |
| Subject | Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding |
| Message-ID | <ueWfN-1az-13@gated-at.bofh.it> |
| In reply to | #1712175 |
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote: > From: Jun Gao <jun.gao@mediatek.com> > > Add MT7622 i2c binding to binding file and change the compatible > information formats of all SoCs to the same. > > Signed-off-by: Jun Gao <jun.gao@mediatek.com> > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > index bd5a7be..71fc0b3 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > Required properties: > - compatible: value should be either of the following. > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > + "mediatek,mt6577-i2c": for Mediatek MT6577 > + "mediatek,mt6589-i2c": for Mediatek MT6589 > + "mediatek,mt7622-i2c": for Mediatek MT7622 > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > + "mediatek,mt8173-i2c": for Mediatek MT8173 > - reg: physical base address of the controller and dma base, length of memory > mapped region. > - interrupts: interrupt number to the cpu. Hi, Jun the patch for new soc support and clean-ups should better be in separate patch following previous Matthias suggestion. http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html And also spelling for Mediatek should be corrected using MediaTek. Sean
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web