Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712324 > unrolled thread

[PATCH 2/3] MIPS: dts: Add VoCore2 board

Started byHarvey Hunt <harvey.hunt@imgtec.com>
First post2017-08-15 18:40 +0200
Last post2017-08-18 15:30 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/3] MIPS: dts: Add VoCore2 board Harvey Hunt <harvey.hunt@imgtec.com> - 2017-08-15 18:40 +0200
    Re: [PATCH 2/3] MIPS: dts: Add VoCore2 board kbuild test robot <lkp@intel.com> - 2017-08-17 12:20 +0200
    Re: [PATCH 2/3] MIPS: dts: Add VoCore2 board Rob Herring <robh@kernel.org> - 2017-08-17 23:40 +0200
      Re: [PATCH 2/3] MIPS: dts: Add VoCore2 board Harvey Hunt <Harvey.Hunt@imgtec.com> - 2017-08-18 15:30 +0200

#1712324 — [PATCH 2/3] MIPS: dts: Add VoCore2 board

FromHarvey Hunt <harvey.hunt@imgtec.com>
Date2017-08-15 18:40 +0200
Subject[PATCH 2/3] MIPS: dts: Add VoCore2 board
Message-ID<ueN2N-3DK-3@gated-at.bofh.it>
The VoCore2 board is a low cost MT7628A based board with 128MB RAM, 16MB
flash and multiple external peripherals.

This initial DTS provides enough support to get to userland and use the USB
port.

Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-mips@linux-mips.org
---
 MAINTAINERS                           |  6 ++++++
 arch/mips/boot/dts/ralink/Makefile    |  1 +
 arch/mips/boot/dts/ralink/vocore2.dts | 18 ++++++++++++++++++
 arch/mips/ralink/Kconfig              |  5 +++++
 4 files changed, 30 insertions(+)
 create mode 100644 arch/mips/boot/dts/ralink/vocore2.dts

diff --git a/MAINTAINERS b/MAINTAINERS
index 6f7721d..82dcc6f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14127,6 +14127,12 @@ L:	netdev@vger.kernel.org
 S:	Maintained
 F:	drivers/net/vmxnet3/
 
+VOCORE VOCORE2 BOARD
+M:	Harvey Hunt <harveyhuntnexus@gmail.com>
+L:	linux-mips@linux-mips.org
+S:	Maintained
+F:	arch/mips/boot/dts/ralink/vocore2.dts
+
 VOLTAGE AND CURRENT REGULATOR FRAMEWORK
 M:	Liam Girdwood <lgirdwood@gmail.com>
 M:	Mark Brown <broonie@kernel.org>
diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
index 2a72259..a191788 100644
--- a/arch/mips/boot/dts/ralink/Makefile
+++ b/arch/mips/boot/dts/ralink/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_DTB_RT2880_EVAL)	+= rt2880_eval.dtb
 dtb-$(CONFIG_DTB_RT305X_EVAL)	+= rt3052_eval.dtb
 dtb-$(CONFIG_DTB_RT3883_EVAL)	+= rt3883_eval.dtb
 dtb-$(CONFIG_DTB_MT7620A_EVAL)	+= mt7620a_eval.dtb
+dtb-$(CONFIG_DTB_VOCORE2)		+= vocore2.dtb
 
 obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
 
diff --git a/arch/mips/boot/dts/ralink/vocore2.dts b/arch/mips/boot/dts/ralink/vocore2.dts
new file mode 100644
index 0000000..7591340
--- /dev/null
+++ b/arch/mips/boot/dts/ralink/vocore2.dts
@@ -0,0 +1,18 @@
+/dts-v1/;
+
+#include "mt7628a.dtsi"
+
+/ {
+	compatible = "vocore,vocore2", "ralink,mt7628a-soc";
+	model = "VoCore2";
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x8000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttyS2,115200";
+		stdout-path = "serial2:115200";
+	};
+};
diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
index 710b04c..c2b2c2d 100644
--- a/arch/mips/ralink/Kconfig
+++ b/arch/mips/ralink/Kconfig
@@ -82,6 +82,11 @@ choice
 		depends on SOC_MT7620
 		select BUILTIN_DTB
 
+	config DTB_VOCORE2
+		bool "VoCore2"
+		depends on SOC_MT7620
+		select BUILTIN_DTB
+
 endchoice
 
 endif
-- 
2.7.4

[toc] | [next] | [standalone]

#1713774

Fromkbuild test robot <lkp@intel.com>
Date2017-08-17 12:20 +0200
Message-ID<ufq4a-3s3-33@gated-at.bofh.it>
In reply to#1712324

[Multipart message — attachments visible in raw view] — view raw

Hi Harvey,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc5 next-20170816]
[cannot apply to robh/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Harvey-Hunt/dt-bindings-vendors-Add-VoCore-as-a-vendor/20170817-150402
config: mips-xilfpga_defconfig (attached as .config)
compiler: mipsel-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All errors (new ones prefixed by >>):

>> arch/mips/boot/dts/ralink/vocore2.dts:3:24: fatal error: mt7628a.dtsi: No such file or directory
    #include "mt7628a.dtsi"
                           ^
   compilation terminated.

vim +3 arch/mips/boot/dts/ralink/vocore2.dts

     2	
   > 3	#include "mt7628a.dtsi"
     4	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1714403

FromRob Herring <robh@kernel.org>
Date2017-08-17 23:40 +0200
Message-ID<ufAGf-2aJ-57@gated-at.bofh.it>
In reply to#1712324
On Tue, Aug 15, 2017 at 05:32:52PM +0100, Harvey Hunt wrote:
> The VoCore2 board is a low cost MT7628A based board with 128MB RAM, 16MB
> flash and multiple external peripherals.
> 
> This initial DTS provides enough support to get to userland and use the USB
> port.
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> ---
>  MAINTAINERS                           |  6 ++++++
>  arch/mips/boot/dts/ralink/Makefile    |  1 +
>  arch/mips/boot/dts/ralink/vocore2.dts | 18 ++++++++++++++++++
>  arch/mips/ralink/Kconfig              |  5 +++++
>  4 files changed, 30 insertions(+)
>  create mode 100644 arch/mips/boot/dts/ralink/vocore2.dts
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6f7721d..82dcc6f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14127,6 +14127,12 @@ L:	netdev@vger.kernel.org
>  S:	Maintained
>  F:	drivers/net/vmxnet3/
>  
> +VOCORE VOCORE2 BOARD
> +M:	Harvey Hunt <harveyhuntnexus@gmail.com>
> +L:	linux-mips@linux-mips.org
> +S:	Maintained
> +F:	arch/mips/boot/dts/ralink/vocore2.dts
> +
>  VOLTAGE AND CURRENT REGULATOR FRAMEWORK
>  M:	Liam Girdwood <lgirdwood@gmail.com>
>  M:	Mark Brown <broonie@kernel.org>
> diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
> index 2a72259..a191788 100644
> --- a/arch/mips/boot/dts/ralink/Makefile
> +++ b/arch/mips/boot/dts/ralink/Makefile
> @@ -2,6 +2,7 @@ dtb-$(CONFIG_DTB_RT2880_EVAL)	+= rt2880_eval.dtb
>  dtb-$(CONFIG_DTB_RT305X_EVAL)	+= rt3052_eval.dtb
>  dtb-$(CONFIG_DTB_RT3883_EVAL)	+= rt3883_eval.dtb
>  dtb-$(CONFIG_DTB_MT7620A_EVAL)	+= mt7620a_eval.dtb
> +dtb-$(CONFIG_DTB_VOCORE2)		+= vocore2.dtb
>  
>  obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
>  
> diff --git a/arch/mips/boot/dts/ralink/vocore2.dts b/arch/mips/boot/dts/ralink/vocore2.dts
> new file mode 100644
> index 0000000..7591340
> --- /dev/null
> +++ b/arch/mips/boot/dts/ralink/vocore2.dts
> @@ -0,0 +1,18 @@
> +/dts-v1/;
> +
> +#include "mt7628a.dtsi"
> +
> +/ {
> +	compatible = "vocore,vocore2", "ralink,mt7628a-soc";

Is vocore,vocore2 documented?

> +	model = "VoCore2";
> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x8000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS2,115200";
> +		stdout-path = "serial2:115200";
> +	};
> +};
> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
> index 710b04c..c2b2c2d 100644
> --- a/arch/mips/ralink/Kconfig
> +++ b/arch/mips/ralink/Kconfig
> @@ -82,6 +82,11 @@ choice
>  		depends on SOC_MT7620
>  		select BUILTIN_DTB
>  
> +	config DTB_VOCORE2
> +		bool "VoCore2"
> +		depends on SOC_MT7620
> +		select BUILTIN_DTB
> +
>  endchoice
>  
>  endif
> -- 
> 2.7.4
>

[toc] | [prev] | [next] | [standalone]

#1714968

FromHarvey Hunt <Harvey.Hunt@imgtec.com>
Date2017-08-18 15:30 +0200
Message-ID<ufPvC-4h9-55@gated-at.bofh.it>
In reply to#1714403
Hi Rob,

Thanks for the review.

On 17/08/17 22:36, Rob Herring wrote:
> On Tue, Aug 15, 2017 at 05:32:52PM +0100, Harvey Hunt wrote:
>> The VoCore2 board is a low cost MT7628A based board with 128MB RAM, 16MB
>> flash and multiple external peripherals.
>>
>> This initial DTS provides enough support to get to userland and use the USB
>> port.
>>
>> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-mips@linux-mips.org
>> ---
>>   MAINTAINERS                           |  6 ++++++
>>   arch/mips/boot/dts/ralink/Makefile    |  1 +
>>   arch/mips/boot/dts/ralink/vocore2.dts | 18 ++++++++++++++++++
>>   arch/mips/ralink/Kconfig              |  5 +++++
>>   4 files changed, 30 insertions(+)
>>   create mode 100644 arch/mips/boot/dts/ralink/vocore2.dts
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6f7721d..82dcc6f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14127,6 +14127,12 @@ L:	netdev@vger.kernel.org
>>   S:	Maintained
>>   F:	drivers/net/vmxnet3/
>>   
>> +VOCORE VOCORE2 BOARD
>> +M:	Harvey Hunt <harveyhuntnexus@gmail.com>
>> +L:	linux-mips@linux-mips.org
>> +S:	Maintained
>> +F:	arch/mips/boot/dts/ralink/vocore2.dts
>> +
>>   VOLTAGE AND CURRENT REGULATOR FRAMEWORK
>>   M:	Liam Girdwood <lgirdwood@gmail.com>
>>   M:	Mark Brown <broonie@kernel.org>
>> diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
>> index 2a72259..a191788 100644
>> --- a/arch/mips/boot/dts/ralink/Makefile
>> +++ b/arch/mips/boot/dts/ralink/Makefile
>> @@ -2,6 +2,7 @@ dtb-$(CONFIG_DTB_RT2880_EVAL)	+= rt2880_eval.dtb
>>   dtb-$(CONFIG_DTB_RT305X_EVAL)	+= rt3052_eval.dtb
>>   dtb-$(CONFIG_DTB_RT3883_EVAL)	+= rt3883_eval.dtb
>>   dtb-$(CONFIG_DTB_MT7620A_EVAL)	+= mt7620a_eval.dtb
>> +dtb-$(CONFIG_DTB_VOCORE2)		+= vocore2.dtb
>>   
>>   obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
>>   
>> diff --git a/arch/mips/boot/dts/ralink/vocore2.dts b/arch/mips/boot/dts/ralink/vocore2.dts
>> new file mode 100644
>> index 0000000..7591340
>> --- /dev/null
>> +++ b/arch/mips/boot/dts/ralink/vocore2.dts
>> @@ -0,0 +1,18 @@
>> +/dts-v1/;
>> +
>> +#include "mt7628a.dtsi"
>> +
>> +/ {
>> +	compatible = "vocore,vocore2", "ralink,mt7628a-soc";
> 
> Is vocore,vocore2 documented?

It's not, do you want me to add a file in 
Documentation/devicetree/bindings/mips?

If so, shall I just create a vocore.txt file or create a "vocore" 
directory with vocore2.txt in it?

Thanks,

Harvey

> 
>> +	model = "VoCore2";
>> +
>> +	memory@0 {
>> +		device_type = "memory";
>> +		reg = <0x0 0x8000000>;
>> +	};
>> +
>> +	chosen {
>> +		bootargs = "console=ttyS2,115200";
>> +		stdout-path = "serial2:115200";
>> +	};
>> +};
>> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
>> index 710b04c..c2b2c2d 100644
>> --- a/arch/mips/ralink/Kconfig
>> +++ b/arch/mips/ralink/Kconfig
>> @@ -82,6 +82,11 @@ choice
>>   		depends on SOC_MT7620
>>   		select BUILTIN_DTB
>>   
>> +	config DTB_VOCORE2
>> +		bool "VoCore2"
>> +		depends on SOC_MT7620
>> +		select BUILTIN_DTB
>> +
>>   endchoice
>>   
>>   endif
>> -- 
>> 2.7.4
>>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web