Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712223 > unrolled thread

[PATCH] iio: adc: select triggered buffer for sama5d2 adc

Back to article view | Back to linux.kernel

Contents

  [PATCH] iio: adc: select triggered buffer for sama5d2 adc Arnd Bergmann <arnd@arndb.de> - 2017-08-15 16:50 +0200
    Re: [PATCH] iio: adc: select triggered buffer for sama5d2 adc Jonathan Cameron <jic23@kernel.org> - 2017-08-17 16:40 +0200

#1712223 — [PATCH] iio: adc: select triggered buffer for sama5d2 adc

Without the triggered buffer code, we get a link error:

drivers/iio/adc/at91-sama5d2_adc.o: In function `at91_adc_probe':
at91-sama5d2_adc.c:(.text+0x938): undefined reference to `devm_iio_triggered_buffer_setup'

This adds a Kconfig 'select' statement like other ADC
drivers have it already.

Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index e4eeebac5297..57625653fcb6 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
 	tristate "Atmel AT91 SAMA5D2 ADC"
 	depends on ARCH_AT91 || COMPILE_TEST
 	depends on HAS_IOMEM
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for Atmel SAMA5D2 ADC which is
 	  available on SAMA5D2 SoC family.
-- 
2.9.0

[toc] | [next] | [standalone]

#1714085

On Tue, 15 Aug 2017 16:46:31 +0200
Arnd Bergmann <arnd@arndb.de> wrote:

> Without the triggered buffer code, we get a link error:
> 
> drivers/iio/adc/at91-sama5d2_adc.o: In function `at91_adc_probe':
> at91-sama5d2_adc.c:(.text+0x938): undefined reference to `devm_iio_triggered_buffer_setup'
> 
> This adds a Kconfig 'select' statement like other ADC
> drivers have it already.
> 
> Fixes: 5e1a1da0f8c9 ("iio: adc: at91-sama5d2_adc: add hw trigger and buffer support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Doh. Shouldn't have missed this one.

Thanks Arnd,

Applied to the togreg branch of iio.git will head for Greg and hence linux-next
in a few days.

Jonathan
> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index e4eeebac5297..57625653fcb6 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -158,6 +158,7 @@ config AT91_SAMA5D2_ADC
>  	tristate "Atmel AT91 SAMA5D2 ADC"
>  	depends on ARCH_AT91 || COMPILE_TEST
>  	depends on HAS_IOMEM
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say yes here to build support for Atmel SAMA5D2 ADC which is
>  	  available on SAMA5D2 SoC family.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web