Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712087 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-15 13:30 +0200 |
| Last post | 2017-08-17 15:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] constify media platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 13:30 +0200
[PATCH 3/3] [media] omap3isp: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 13:30 +0200
[PATCH 2/3] [media] davinci: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 13:30 +0200
Re: [PATCH 2/3] [media] davinci: constify platform_device_id "Lad, Prabhakar" <prabhakar.csengg@gmail.com> - 2017-08-17 15:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-15 13:30 +0200 |
| Subject | [PATCH 0/3] constify media platform_device_id |
| Message-ID | <ueIcN-DE-7@gated-at.bofh.it> |
platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by <linux/platform_device.h> work with const platform_device_id. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] [media] coda: constify platform_device_id [PATCH 2/3] [media] davinci: constify platform_device_id [PATCH 3/3] [media] omap3isp: constify platform_device_id drivers/media/platform/coda/coda-common.c | 2 +- drivers/media/platform/davinci/vpbe_osd.c | 2 +- drivers/media/platform/davinci/vpbe_venc.c | 2 +- drivers/media/platform/omap3isp/isp.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-15 13:30 +0200 |
| Subject | [PATCH 3/3] [media] omap3isp: constify platform_device_id |
| Message-ID | <ueIcN-DE-11@gated-at.bofh.it> |
| In reply to | #1712087 |
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/media/platform/omap3isp/isp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 9df64c1..ddb2cf5 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2373,7 +2373,7 @@ static const struct dev_pm_ops omap3isp_pm_ops = {
.complete = isp_pm_complete,
};
-static struct platform_device_id omap3isp_id_table[] = {
+static const struct platform_device_id omap3isp_id_table[] = {
{ "omap3isp", 0 },
{ },
};
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-15 13:30 +0200 |
| Subject | [PATCH 2/3] [media] davinci: constify platform_device_id |
| Message-ID | <ueIcN-DE-13@gated-at.bofh.it> |
| In reply to | #1712087 |
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/media/platform/davinci/vpbe_osd.c | 2 +-
drivers/media/platform/davinci/vpbe_venc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/davinci/vpbe_osd.c b/drivers/media/platform/davinci/vpbe_osd.c
index df042e8..6644979 100644
--- a/drivers/media/platform/davinci/vpbe_osd.c
+++ b/drivers/media/platform/davinci/vpbe_osd.c
@@ -37,7 +37,7 @@
#define MODULE_NAME "davinci-vpbe-osd"
-static struct platform_device_id vpbe_osd_devtype[] = {
+static const struct platform_device_id vpbe_osd_devtype[] = {
{
.name = DM644X_VPBE_OSD_SUBDEV_NAME,
.driver_data = VPBE_VERSION_1,
diff --git a/drivers/media/platform/davinci/vpbe_venc.c b/drivers/media/platform/davinci/vpbe_venc.c
index 8bfe90a..3a4e785 100644
--- a/drivers/media/platform/davinci/vpbe_venc.c
+++ b/drivers/media/platform/davinci/vpbe_venc.c
@@ -36,7 +36,7 @@
#define MODULE_NAME "davinci-vpbe-venc"
-static struct platform_device_id vpbe_venc_devtype[] = {
+static const struct platform_device_id vpbe_venc_devtype[] = {
{
.name = DM644X_VPBE_VENC_SUBDEV_NAME,
.driver_data = VPBE_VERSION_1,
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | "Lad, Prabhakar" <prabhakar.csengg@gmail.com> |
|---|---|
| Date | 2017-08-17 15:20 +0200 |
| Subject | Re: [PATCH 2/3] [media] davinci: constify platform_device_id |
| Message-ID | <ufsSn-5nC-31@gated-at.bofh.it> |
| In reply to | #1712090 |
On Tue, Aug 15, 2017 at 12:23 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by <linux/platform_device.h> > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Cheers, --Prabhakar Lad
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web