Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712112 > unrolled thread
| Started by | Petr Mladek <pmladek@suse.com> |
|---|---|
| First post | 2017-08-15 14:00 +0200 |
| Last post | 2017-08-15 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Petr Mladek <pmladek@suse.com> - 2017-08-15 14:00 +0200
Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Kees Cook <keescook@chromium.org> - 2017-08-15 21:10 +0200
| From | Petr Mladek <pmladek@suse.com> |
|---|---|
| Date | 2017-08-15 14:00 +0200 |
| Subject | Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" |
| Message-ID | <ueIFQ-RA-5@gated-at.bofh.it> |
On Thu 2017-08-10 13:36:35, Kees Cook wrote: > This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with > various conflict clean-ups. > > With the default root directory mode set to 0750 now, the capability > check was redundant. > > Suggested-by: Nick Kralevich <nnk@google.com> > Signed-off-by: Kees Cook <keescook@chromium.org> The patch looks correct from the code side. I looked at it because it touched printk.c. Note that I am not security expert. Reviewed-by: Petr Mladek <pmladek@suse.cz> Best Regards, Petr
[toc] | [next] | [standalone]
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2017-08-15 21:10 +0200 |
| Subject | Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" |
| Message-ID | <uePnY-5ik-9@gated-at.bofh.it> |
| In reply to | #1712112 |
On Tue, Aug 15, 2017 at 4:55 AM, Petr Mladek <pmladek@suse.com> wrote: > On Thu 2017-08-10 13:36:35, Kees Cook wrote: >> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with >> various conflict clean-ups. >> >> With the default root directory mode set to 0750 now, the capability >> check was redundant. >> >> Suggested-by: Nick Kralevich <nnk@google.com> >> Signed-off-by: Kees Cook <keescook@chromium.org> > > The patch looks correct from the code side. I looked at > it because it touched printk.c. Note that I am not > security expert. > > Reviewed-by: Petr Mladek <pmladek@suse.cz> Thanks! -Kees -- Kees Cook Pixel Security
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web