Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1711279 > unrolled thread

[PATCH] sound: emu8000: constify emu8000_ops

Started byJulia Lawall <Julia.Lawall@lip6.fr>
First post2017-08-14 19:40 +0200
Last post2017-08-15 08:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] sound: emu8000: constify emu8000_ops Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-14 19:40 +0200
    Re: [PATCH] sound: emu8000: constify emu8000_ops Takashi Iwai <tiwai@suse.de> - 2017-08-15 08:30 +0200

#1711279 — [PATCH] sound: emu8000: constify emu8000_ops

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2017-08-14 19:40 +0200
Subject[PATCH] sound: emu8000: constify emu8000_ops
Message-ID<uervk-72Y-31@gated-at.bofh.it>
The structure emu8000_ops is only copied into another structure, so
it can be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 sound/isa/sb/emu8000_callback.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/isa/sb/emu8000_callback.c b/sound/isa/sb/emu8000_callback.c
index d28d712..5a48550 100644
--- a/sound/isa/sb/emu8000_callback.c
+++ b/sound/isa/sb/emu8000_callback.c
@@ -62,7 +62,7 @@ static int load_fx(struct snd_emux *emu, int type, int mode,
 /*
  * set up operators
  */
-static struct snd_emux_operators emu8000_ops = {
+static const struct snd_emux_operators emu8000_ops = {
 	.owner =	THIS_MODULE,
 	.get_voice =	get_voice,
 	.prepare =	start_voice,

[toc] | [next] | [standalone]


#1711875

FromTakashi Iwai <tiwai@suse.de>
Date2017-08-15 08:30 +0200
Message-ID<ueDwv-6d6-37@gated-at.bofh.it>
In reply to#1711279
On Mon, 14 Aug 2017 19:13:26 +0200,
Julia Lawall wrote:
> 
> The structure emu8000_ops is only copied into another structure, so
> it can be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.


Takashi

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web