Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1709900 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-08-11 20:10 +0200 |
| Last post | 2017-08-12 23:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-11 20:10 +0200
Re: [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() Daniel Mack <daniel@zonque.org> - 2017-08-12 09:50 +0200
Re: [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:30 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-08-11 20:10 +0200 |
| Subject | [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() |
| Message-ID | <udmxI-6Oo-13@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 11 Aug 2017 19:39:06 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/usb/caiaq/audio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c
index 8f66ba730d69..1f306155e76a 100644
--- a/sound/usb/caiaq/audio.c
+++ b/sound/usb/caiaq/audio.c
@@ -731,7 +731,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL);
if (!urbs) {
- dev_err(dev, "unable to kmalloc() urbs, OOM!?\n");
*ret = -ENOMEM;
return NULL;
}
@@ -746,7 +745,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
urbs[i]->transfer_buffer =
kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL);
if (!urbs[i]->transfer_buffer) {
- dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n");
*ret = -ENOMEM;
return urbs;
}
--
2.14.0
[toc] | [next] | [standalone]
| From | Daniel Mack <daniel@zonque.org> |
|---|---|
| Date | 2017-08-12 09:50 +0200 |
| Message-ID | <udzlf-69b-11@gated-at.bofh.it> |
| In reply to | #1709900 |
On 08/11/2017 08:00 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 11 Aug 2017 19:39:06 +0200
>
> Omit extra messages for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Daniel Mack <daniel@zonque.org>
> ---
> sound/usb/caiaq/audio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c
> index 8f66ba730d69..1f306155e76a 100644
> --- a/sound/usb/caiaq/audio.c
> +++ b/sound/usb/caiaq/audio.c
> @@ -731,7 +731,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
>
> urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL);
> if (!urbs) {
> - dev_err(dev, "unable to kmalloc() urbs, OOM!?\n");
> *ret = -ENOMEM;
> return NULL;
> }
> @@ -746,7 +745,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
> urbs[i]->transfer_buffer =
> kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL);
> if (!urbs[i]->transfer_buffer) {
> - dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n");
> *ret = -ENOMEM;
> return urbs;
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-08-12 23:30 +0200 |
| Subject | Re: [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs() |
| Message-ID | <udM8O-6gz-27@gated-at.bofh.it> |
| In reply to | #1709900 |
On Fri, 11 Aug 2017 20:00:30 +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 11 Aug 2017 19:39:06 +0200 > > Omit extra messages for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied, thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web