Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1710184 > unrolled thread

[PATCH] omapfb: constify omap_video_timings structures

Started byJulia Lawall <Julia.Lawall@lip6.fr>
First post2017-08-12 08:50 +0200
Last post2017-08-21 16:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] omapfb: constify omap_video_timings structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-12 08:50 +0200
    Re: [PATCH] omapfb: constify omap_video_timings structures Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-08-21 16:50 +0200

#1710184 — [PATCH] omapfb: constify omap_video_timings structures

FromJulia Lawall <Julia.Lawall@lip6.fr>
Date2017-08-12 08:50 +0200
Subject[PATCH] omapfb: constify omap_video_timings structures
Message-ID<udypb-5Ac-7@gated-at.bofh.it>
These omap_video_timings structures are only copied into other
structures, so they can be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |    2 +-
 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index f14691c..6cd759c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -18,7 +18,7 @@
 
 #include <video/omapfb_dss.h>
 
-static struct omap_video_timings lb035q02_timings = {
+static const struct omap_video_timings lb035q02_timings = {
 	.x_res = 320,
 	.y_res = 240,
 
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
index b529a8c..57e9e14 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
@@ -41,7 +41,7 @@ struct panel_drv_data {
 	struct spi_device *spi_dev;
 };
 
-static struct omap_video_timings td028ttec1_panel_timings = {
+static const struct omap_video_timings td028ttec1_panel_timings = {
 	.x_res		= 480,
 	.y_res		= 640,
 	.pixelclock	= 22153000,

[toc] | [next] | [standalone]


#1716560

FromBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date2017-08-21 16:50 +0200
Message-ID<ugWbE-5BL-1@gated-at.bofh.it>
In reply to#1710184
On Saturday, August 12, 2017 08:20:36 AM Julia Lawall wrote:
> These omap_video_timings structures are only copied into other
> structures, so they can be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web