Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1709952 > unrolled thread

[PATCH 1/3] ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-08-11 22:50 +0200
Last post2017-08-14 18:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/3] ASoC: blackfin: Delete an error message for a failed  memory allocation in sport_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-11 22:50 +0200
    Applied "ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-08-14 18:50 +0200

#1709952 — [PATCH 1/3] ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-08-11 22:50 +0200
Subject[PATCH 1/3] ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()
Message-ID<udp2y-89B-3@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 11 Aug 2017 21:45:37 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/blackfin/bf6xx-sport.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/blackfin/bf6xx-sport.c b/sound/soc/blackfin/bf6xx-sport.c
index dfb744381c42..1bc3e0a47a57 100644
--- a/sound/soc/blackfin/bf6xx-sport.c
+++ b/sound/soc/blackfin/bf6xx-sport.c
@@ -388,10 +388,9 @@ struct sport_device *sport_create(struct platform_device *pdev)
 	int ret;
 
 	sport = kzalloc(sizeof(*sport), GFP_KERNEL);
-	if (!sport) {
-		dev_err(dev, "Unable to allocate memory for sport device\n");
+	if (!sport)
 		return NULL;
-	}
+
 	sport->pdev = pdev;
 
 	ret = sport_get_resource(sport);
-- 
2.14.0

[toc] | [next] | [standalone]


#1711229 — Applied "ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()" to the asoc tree

FromMark Brown <broonie@kernel.org>
Date2017-08-14 18:50 +0200
SubjectApplied "ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()" to the asoc tree
Message-ID<ueqIX-6xI-41@gated-at.bofh.it>
In reply to#1709952
The patch

   ASoC: blackfin: Delete an error message for a failed memory allocation in sport_create()

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 60ea0394a602d5abc24bd2381fa0966a8720eec1 Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 11 Aug 2017 21:45:37 +0200
Subject: [PATCH] ASoC: blackfin: Delete an error message for a failed memory
 allocation in sport_create()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/blackfin/bf6xx-sport.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/blackfin/bf6xx-sport.c b/sound/soc/blackfin/bf6xx-sport.c
index dfb744381c42..1bc3e0a47a57 100644
--- a/sound/soc/blackfin/bf6xx-sport.c
+++ b/sound/soc/blackfin/bf6xx-sport.c
@@ -388,10 +388,9 @@ struct sport_device *sport_create(struct platform_device *pdev)
 	int ret;
 
 	sport = kzalloc(sizeof(*sport), GFP_KERNEL);
-	if (!sport) {
-		dev_err(dev, "Unable to allocate memory for sport device\n");
+	if (!sport)
 		return NULL;
-	}
+
 	sport->pdev = pdev;
 
 	ret = sport_get_resource(sport);
-- 
2.13.2

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web