Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1709908 > unrolled thread
| Started by | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| First post | 2017-08-11 20:40 +0200 |
| Last post | 2017-08-11 20:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Matthias Kaehlcke <mka@chromium.org> - 2017-08-11 20:40 +0200
Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Rodrigo Vivi <rodrigo.vivi@gmail.com> - 2017-08-11 20:40 +0200
| From | Matthias Kaehlcke <mka@chromium.org> |
|---|---|
| Date | 2017-08-11 20:40 +0200 |
| Subject | Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V |
| Message-ID | <udn0J-6Yw-11@gated-at.bofh.it> |
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
>
> The error was pointed out by this clang warning:
>
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
ping, it seems this patch went under the radar.
[toc] | [next] | [standalone]
| From | Rodrigo Vivi <rodrigo.vivi@gmail.com> |
|---|---|
| Date | 2017-08-11 20:40 +0200 |
| Subject | Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V |
| Message-ID | <udn0K-6Yw-43@gated-at.bofh.it> |
| In reply to | #1709908 |
On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>> 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>> [-Wunneeded-internal-declaration]
>> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> ping, it seems this patch went under the radar.
yes totally. sorry about that.
merged to dinq. Thanks for patch, review, and heads up
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web