Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1707511 > unrolled thread
| Started by | Eric Anholt <eric@anholt.net> |
|---|---|
| First post | 2017-08-09 19:00 +0200 |
| Last post | 2017-08-11 19:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/vc4: Fix leak of HDMI EDID Eric Anholt <eric@anholt.net> - 2017-08-09 19:00 +0200
Re: [PATCH] drm/vc4: Fix leak of HDMI EDID Daniel Vetter <daniel@ffwll.ch> - 2017-08-09 19:40 +0200
Re: [PATCH] drm/vc4: Fix leak of HDMI EDID Eric Anholt <eric@anholt.net> - 2017-08-14 23:20 +0200
Re: [PATCH] drm/vc4: Fix leak of HDMI EDID Stefan Wahren <stefan.wahren@i2se.com> - 2017-08-11 19:40 +0200
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2017-08-09 19:00 +0200 |
| Subject | [PATCH] drm/vc4: Fix leak of HDMI EDID |
| Message-ID | <ucCuT-1ua-27@gated-at.bofh.it> |
We don't keep a pointer to it around anywhere, so it's our job to free
it.
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://github.com/anholt/linux/issues/101
Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index ff09b8e2f9ee..937da8dd65b8 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
drm_mode_connector_update_edid_property(connector, edid);
ret = drm_add_edid_modes(connector, edid);
drm_edid_to_eld(connector, edid);
+ kfree(edid);
return ret;
}
--
2.13.3
[toc] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2017-08-09 19:40 +0200 |
| Message-ID | <ucD7z-1Xn-13@gated-at.bofh.it> |
| In reply to | #1707511 |
On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index ff09b8e2f9ee..937da8dd65b8 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -288,6 +288,7 @@ static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
> drm_mode_connector_update_edid_property(connector, edid);
> ret = drm_add_edid_modes(connector, edid);
> drm_edid_to_eld(connector, edid);
> + kfree(edid);
>
> return ret;
> }
> --
> 2.13.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [next] | [standalone]
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2017-08-14 23:20 +0200 |
| Message-ID | <ueuWe-Mv-15@gated-at.bofh.it> |
| In reply to | #1707625 |
[Multipart message — attachments visible in raw view] — view raw
Daniel Vetter <daniel@ffwll.ch> writes:
> On Tue, Aug 08, 2017 at 01:56:05PM -0700, Eric Anholt wrote:
>> We don't keep a pointer to it around anywhere, so it's our job to free
>> it.
>>
>> Cc: Stefan Wahren <stefan.wahren@i2se.com>
>> Link: https://github.com/anholt/linux/issues/101
>> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
>> Signed-off-by: Eric Anholt <eric@anholt.net>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed. Thanks!
[toc] | [prev] | [next] | [standalone]
| From | Stefan Wahren <stefan.wahren@i2se.com> |
|---|---|
| Date | 2017-08-11 19:40 +0200 |
| Message-ID | <udm4G-6pu-23@gated-at.bofh.it> |
| In reply to | #1707511 |
> Eric Anholt <eric@anholt.net> hat am 8. August 2017 um 22:56 geschrieben:
>
>
> We don't keep a pointer to it around anywhere, so it's our job to free
> it.
>
> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> Link: https://github.com/anholt/linux/issues/101
> Fixes: c8b75bca92cb ("drm/vc4: Add KMS support for Raspberry Pi.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web