Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709010 > unrolled thread

Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

Started byAlexandre Belloni <alexandre.belloni@free-electrons.com>
First post2017-08-10 22:40 +0200
Last post2017-08-14 15:20 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-10 22:40 +0200
    RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Miodrag Dinic <Miodrag.Dinic@imgtec.com> - 2017-08-11 18:50 +0200
      RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Aleksandar Markovic <Aleksandar.Markovic@imgtec.com> - 2017-08-14 14:50 +0200
        Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-14 15:20 +0200

#1709010 — Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-08-10 22:40 +0200
SubjectRe: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Message-ID<ud2pk-2qz-13@gated-at.bofh.it>
Hi,

On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
> 
> Add device driver for a virtual Goldfish RTC clock.
> 
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
> 
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
>  MAINTAINERS                |   1 +
>  drivers/rtc/Kconfig        |   8 ++
>  drivers/rtc/Makefile       |   1 +
>  drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 243 insertions(+)
>  create mode 100644 drivers/rtc/rtc-goldfish.c
> 

Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?

Thanks!


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [next] | [standalone]

#1709842

FromMiodrag Dinic <Miodrag.Dinic@imgtec.com>
Date2017-08-11 18:50 +0200
Message-ID<udlih-5Uh-15@gated-at.bofh.it>
In reply to#1709010
Hi Alexandre,

we have this sorted & plan to submit version 4 of this series next week.

Thank you.

Kind regards,
Miodrag
________________________________________
From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
Sent: Thursday, August 10, 2017 10:34 PM
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

Hi,

On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
>  MAINTAINERS                |   1 +
>  drivers/rtc/Kconfig        |   8 ++
>  drivers/rtc/Makefile       |   1 +
>  drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 243 insertions(+)
>  create mode 100644 drivers/rtc/rtc-goldfish.c
>

Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?

Thanks!


--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1710902

FromAleksandar Markovic <Aleksandar.Markovic@imgtec.com>
Date2017-08-14 14:50 +0200
Message-ID<uemYG-4c5-13@gated-at.bofh.it>
In reply to#1709842
Hello, Alexandre,

In addition, if you, and everybody else, don't object, I plan to change the title of this patch form:

"MIPS: ranchu: Add Goldfish RTC driver"

to

"rtc: Add Goldfish RTC driver",

to be more consistent with all commit messages for this kernel source directory.

Regards,
Aleksandar

________________________________________
From: Miodrag Dinic
Sent: Friday, August 11, 2017 9:46 AM
To: Alexandre Belloni; Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

Hi Alexandre,

we have this sorted & plan to submit version 4 of this series next week.

Thank you.

Kind regards,
Miodrag
________________________________________
From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
Sent: Thursday, August 10, 2017 10:34 PM
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

Hi,

On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
>  MAINTAINERS                |   1 +
>  drivers/rtc/Kconfig        |   8 ++
>  drivers/rtc/Makefile       |   1 +
>  drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 243 insertions(+)
>  create mode 100644 drivers/rtc/rtc-goldfish.c
>

Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?

Thanks!


--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]

#1710917

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-08-14 15:20 +0200
Message-ID<uenrJ-4CX-25@gated-at.bofh.it>
In reply to#1710902
On 14/08/2017 at 12:45:55 +0000, Aleksandar Markovic wrote:
> Hello, Alexandre,
> 
> In addition, if you, and everybody else, don't object, I plan to change the title of this patch form:
> 
> "MIPS: ranchu: Add Goldfish RTC driver"
> 
> to
> 
> "rtc: Add Goldfish RTC driver",
> 
> to be more consistent with all commit messages for this kernel source directory.
> 

Yes please, I would have changed it anyway.

> Regards,
> Aleksandar
> 
> ________________________________________
> From: Miodrag Dinic
> Sent: Friday, August 11, 2017 9:46 AM
> To: Alexandre Belloni; Aleksandar Markovic
> Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
> Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
> 
> Hi Alexandre,
> 
> we have this sorted & plan to submit version 4 of this series next week.
> 
> Thank you.
> 
> Kind regards,
> Miodrag
> ________________________________________
> From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
> Sent: Thursday, August 10, 2017 10:34 PM
> To: Aleksandar Markovic
> Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
> Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
> 
> Hi,
> 
> On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> > From: Miodrag Dinic <miodrag.dinic@imgtec.com>
> >
> > Add device driver for a virtual Goldfish RTC clock.
> >
> > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> > set. The compatible string used by OS for binding the driver is
> > defined as "google,goldfish-rtc".
> >
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> > ---
> >  MAINTAINERS                |   1 +
> >  drivers/rtc/Kconfig        |   8 ++
> >  drivers/rtc/Makefile       |   1 +
> >  drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 243 insertions(+)
> >  create mode 100644 drivers/rtc/rtc-goldfish.c
> >
> 
> Do you mind fixing the remaining checkpatch --strict issues, the two
> kbuild errors and the warning reported by Julia?
> 
> Thanks!
> 
> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web