Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709536 > unrolled thread

[PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers Cihangir Akturk <cakturk@gmail.com> - 2017-08-11 14:40 +0200
    Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers Eric Anholt <eric@anholt.net> - 2017-08-14 22:00 +0200
      Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put()  helpers Cihangir Akturk <cakturk@gmail.com> - 2017-08-14 22:10 +0200
        Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers Eric Anholt <eric@anholt.net> - 2017-08-14 23:20 +0200

#1709536 — [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
and drm_*_unreference() helpers.

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to
use the new APIs.

Generated by: scripts/coccinelle/api/drm-get-put.cocci

Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
 drivers/gpu/drm/vc4/vc4_bo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index facee39..3afdbf4 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -830,7 +830,7 @@ int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
 		ret = -ENOMEM;
 	mutex_unlock(&vc4->bo_lock);
 
-	drm_gem_object_unreference_unlocked(gem_obj);
+	drm_gem_object_put_unlocked(gem_obj);
 
 	return ret;
 }
-- 
2.7.4

[toc] | [next] | [standalone]

#1711387

[Multipart message — attachments visible in raw view] — view raw

Cihangir Akturk <cakturk@gmail.com> writes:

> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
>
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.

Mind if I change the subject line to "drm/vc4: Continue the switch to
drm_*_put() helpers"? to distinguish from the patch that already landed?

(Looks like your previous patch was generated before my BO labeling code
landed, so we got another little patch here cleaning up the new code as
well)

[toc] | [prev] | [next] | [standalone]

#1711395 — Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

On Mon, Aug 14, 2017 at 12:47:01PM -0700, Eric Anholt wrote:
> Cihangir Akturk <cakturk@gmail.com> writes:
> 
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> > and drm_*_unreference() helpers.
> >
> > drm_*_reference() and drm_*_unreference() functions are just
> > compatibility alias for drm_*_get() and drm_*_put() and should not be
> > used by new code. So convert all users of compatibility functions to
> > use the new APIs.
> 
> Mind if I change the subject line to "drm/vc4: Continue the switch to
> drm_*_put() helpers"? to distinguish from the patch that already landed?

It's OK with me. Go ahead, change to whatever you want.

> 
> (Looks like your previous patch was generated before my BO labeling code
> landed, so we got another little patch here cleaning up the new code as
> well)

Thanks, Cihangir.

[toc] | [prev] | [next] | [standalone]

#1711464

[Multipart message — attachments visible in raw view] — view raw

Cihangir Akturk <cakturk@gmail.com> writes:

> On Mon, Aug 14, 2017 at 12:47:01PM -0700, Eric Anholt wrote:
>> Cihangir Akturk <cakturk@gmail.com> writes:
>> 
>> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
>> > and drm_*_unreference() helpers.
>> >
>> > drm_*_reference() and drm_*_unreference() functions are just
>> > compatibility alias for drm_*_get() and drm_*_put() and should not be
>> > used by new code. So convert all users of compatibility functions to
>> > use the new APIs.
>> 
>> Mind if I change the subject line to "drm/vc4: Continue the switch to
>> drm_*_put() helpers"? to distinguish from the patch that already landed?
>
> It's OK with me. Go ahead, change to whatever you want.

Changed and pushed.  Thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web