Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709455 > unrolled thread

[PATCH] reset: sunxi: fix number of reset lines

Back to article view | Back to linux.kernel

Contents

  [PATCH] reset: sunxi: fix number of reset lines Philipp Zabel <p.zabel@pengutronix.de> - 2017-08-11 12:50 +0200
    Re: [PATCH] reset: sunxi: fix number of reset lines Chen-Yu Tsai <wens@csie.org> - 2017-08-11 17:50 +0200

#1709455 — [PATCH] reset: sunxi: fix number of reset lines

The Allwinner reset controller has 32-bit registers, but resource_size
is measured in bytes, not number of registers.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/reset/reset-sunxi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
index cd585cd2f04dd..2c7dd1fd08df6 100644
--- a/drivers/reset/reset-sunxi.c
+++ b/drivers/reset/reset-sunxi.c
@@ -107,7 +107,7 @@ static int sunxi_reset_init(struct device_node *np)
 	spin_lock_init(&data->lock);
 
 	data->rcdev.owner = THIS_MODULE;
-	data->rcdev.nr_resets = size * 32;
+	data->rcdev.nr_resets = size * 8;
 	data->rcdev.ops = &sunxi_reset_ops;
 	data->rcdev.of_node = np;
 
@@ -162,7 +162,7 @@ static int sunxi_reset_probe(struct platform_device *pdev)
 	spin_lock_init(&data->lock);
 
 	data->rcdev.owner = THIS_MODULE;
-	data->rcdev.nr_resets = resource_size(res) * 32;
+	data->rcdev.nr_resets = resource_size(res) * 8;
 	data->rcdev.ops = &sunxi_reset_ops;
 	data->rcdev.of_node = pdev->dev.of_node;
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1709766

On Fri, Aug 11, 2017 at 6:40 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> The Allwinner reset controller has 32-bit registers, but resource_size
> is measured in bytes, not number of registers.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Acked-by: Chen-Yu Tsai <wens@csie.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web