Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706068 > unrolled thread

Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled Juergen Gross <jgross@suse.com> - 2017-08-08 08:50 +0200
    Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-08 16:10 +0200
      Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled Juergen Gross <jgross@suse.com> - 2017-08-11 12:10 +0200
        Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled Ingo Molnar <mingo@kernel.org> - 2017-08-11 15:00 +0200

#1706068 — Re: [PATCH v2 0/3] fix xen hvm guest with kaslr enabled

On 28/07/17 12:23, Juergen Gross wrote:
> This patch series fixes a regression introduced in 4.13-rc1: A Xen
> HVM guest with KASLR enabled wouldn't boot any longer due to the usage
> of __va() before kernel_randomize_memory() was called.
> 
> Changes in V2:
> - patch 1: test for x86_hyper being not NULL
> 
> Juergen Gross (3):
>   x86: provide an init_mem_mapping hypervisor hook
>   xen: split up xen_hvm_init_shared_info()
>   xen: fix hvm guest with kaslr enabled
> 
>  arch/x86/include/asm/hypervisor.h | 10 +++++++
>  arch/x86/mm/init.c                |  3 ++
>  arch/x86/xen/enlighten_hvm.c      | 59 ++++++++++++++++++++++++---------------
>  3 files changed, 50 insertions(+), 22 deletions(-)
> 

Could I have some feedback, please?

I'd like to get this regression fixed in 4.13.

In case nobody objects this week I'll just add the patches to the Xen
tree for rc5.


Juergen

[toc] | [next] | [standalone]

#1706596

On 08/08/2017 02:46 AM, Juergen Gross wrote:
> On 28/07/17 12:23, Juergen Gross wrote:
>> This patch series fixes a regression introduced in 4.13-rc1: A Xen
>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage
>> of __va() before kernel_randomize_memory() was called.
>>
>> Changes in V2:
>> - patch 1: test for x86_hyper being not NULL
>>
>> Juergen Gross (3):
>>   x86: provide an init_mem_mapping hypervisor hook
>>   xen: split up xen_hvm_init_shared_info()
>>   xen: fix hvm guest with kaslr enabled
>>
>>  arch/x86/include/asm/hypervisor.h | 10 +++++++
>>  arch/x86/mm/init.c                |  3 ++
>>  arch/x86/xen/enlighten_hvm.c      | 59 ++++++++++++++++++++++++---------------
>>  3 files changed, 50 insertions(+), 22 deletions(-)
>>
> Could I have some feedback, please?
>
> I'd like to get this regression fixed in 4.13.
>
> In case nobody objects this week I'll just add the patches to the Xen
> tree for rc5.


As I said before I think .init_mem_mapping() could live in
x86_platform_ops() but this works too, so

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

But this still wants x86 maintainers' ACK.


-boris

[toc] | [prev] | [next] | [standalone]

#1709436

On 08/08/17 16:00, Boris Ostrovsky wrote:
> On 08/08/2017 02:46 AM, Juergen Gross wrote:
>> On 28/07/17 12:23, Juergen Gross wrote:
>>> This patch series fixes a regression introduced in 4.13-rc1: A Xen
>>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage
>>> of __va() before kernel_randomize_memory() was called.
>>>
>>> Changes in V2:
>>> - patch 1: test for x86_hyper being not NULL
>>>
>>> Juergen Gross (3):
>>>   x86: provide an init_mem_mapping hypervisor hook
>>>   xen: split up xen_hvm_init_shared_info()
>>>   xen: fix hvm guest with kaslr enabled
>>>
>>>  arch/x86/include/asm/hypervisor.h | 10 +++++++
>>>  arch/x86/mm/init.c                |  3 ++
>>>  arch/x86/xen/enlighten_hvm.c      | 59 ++++++++++++++++++++++++---------------
>>>  3 files changed, 50 insertions(+), 22 deletions(-)
>>>
>> Could I have some feedback, please?
>>
>> I'd like to get this regression fixed in 4.13.
>>
>> In case nobody objects this week I'll just add the patches to the Xen
>> tree for rc5.
> 
> 
> As I said before I think .init_mem_mapping() could live in
> x86_platform_ops() but this works too, so
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> But this still wants x86 maintainers' ACK.

x86 maintainers, could you please comment on at least patch 1?


Juergen

[toc] | [prev] | [next] | [standalone]

#1709580

* Juergen Gross <jgross@suse.com> wrote:

> On 08/08/17 16:00, Boris Ostrovsky wrote:
> > On 08/08/2017 02:46 AM, Juergen Gross wrote:
> >> On 28/07/17 12:23, Juergen Gross wrote:
> >>> This patch series fixes a regression introduced in 4.13-rc1: A Xen
> >>> HVM guest with KASLR enabled wouldn't boot any longer due to the usage
> >>> of __va() before kernel_randomize_memory() was called.
> >>>
> >>> Changes in V2:
> >>> - patch 1: test for x86_hyper being not NULL
> >>>
> >>> Juergen Gross (3):
> >>>   x86: provide an init_mem_mapping hypervisor hook
> >>>   xen: split up xen_hvm_init_shared_info()
> >>>   xen: fix hvm guest with kaslr enabled
> >>>
> >>>  arch/x86/include/asm/hypervisor.h | 10 +++++++
> >>>  arch/x86/mm/init.c                |  3 ++
> >>>  arch/x86/xen/enlighten_hvm.c      | 59 ++++++++++++++++++++++++---------------
> >>>  3 files changed, 50 insertions(+), 22 deletions(-)
> >>>
> >> Could I have some feedback, please?
> >>
> >> I'd like to get this regression fixed in 4.13.
> >>
> >> In case nobody objects this week I'll just add the patches to the Xen
> >> tree for rc5.
> > 
> > 
> > As I said before I think .init_mem_mapping() could live in
> > x86_platform_ops() but this works too, so
> > 
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > 
> > But this still wants x86 maintainers' ACK.
> 
> x86 maintainers, could you please comment on at least patch 1?

LGTM:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web