Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706036 > unrolled thread

[PATCH 1/4] usb: mtu3: add generic compatible string

Started byChunfeng Yun <chunfeng.yun@mediatek.com>
First post2017-08-08 07:50 +0200
Last post2017-08-11 09:10 +0200
Articles 8 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/4] usb: mtu3: add generic compatible string Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-08 07:50 +0200
    [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-08 07:50 +0200
      Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and  rename file Rob Herring <robh@kernel.org> - 2017-08-11 05:00 +0200
        Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible  and rename file Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-11 09:10 +0200
    [PATCH 2/4] usb: xhci-mtk: add generic compatible string Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-08 07:50 +0200
    [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-08 07:50 +0200
      Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and  rename file Rob Herring <robh@kernel.org> - 2017-08-11 05:00 +0200
        Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible  and rename file Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-08-11 09:10 +0200

#1706036 — [PATCH 1/4] usb: mtu3: add generic compatible string

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-08 07:50 +0200
Subject[PATCH 1/4] usb: mtu3: add generic compatible string
Message-ID<uc5yV-3pV-1@gated-at.bofh.it>
The mtu3 driver is a generic driver for MediaTek usb3 DRD IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/mtu3/mtu3_plat.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
index 0d3ebb3..088e3e6 100644
--- a/drivers/usb/mtu3/mtu3_plat.c
+++ b/drivers/usb/mtu3/mtu3_plat.c
@@ -500,6 +500,7 @@ static int __maybe_unused mtu3_resume(struct device *dev)
 
 static const struct of_device_id mtu3_of_match[] = {
 	{.compatible = "mediatek,mt8173-mtu3",},
+	{.compatible = "mediatek,mtu3",},
 	{},
 };
 
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1706037 — [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-08 07:50 +0200
Subject[PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
Message-ID<uc5yV-3pV-3@gated-at.bofh.it>
In reply to#1706036
The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to xhci-mtk.txt to reflect that.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
 rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)

diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
similarity index 92%
rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt
index 0acfc8a..1ce77c7 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
@@ -11,7 +11,9 @@ into two parts.
 ------------------------------------------------------------------------
 
 Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be one of
+	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
+	"mediatek,xhci-mtk"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
  - interrupts : interrupt used by the controller
@@ -68,10 +70,12 @@ usb30: usb@11270000 {
 
 In the case, xhci is added as subnode to mtu3. An example and the DT binding
 details of mtu3 can be found in:
-Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+Documentation/devicetree/bindings/usb/mtu3.txt
 
 Required properties:
- - compatible : should contain "mediatek,mt8173-xhci"
+ - compatible : should be one of
+	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
+	"mediatek,xhci-mtk"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for xHCI MAC
  - interrupts : interrupt used by the host controller
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1709187 — Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file

FromRob Herring <robh@kernel.org>
Date2017-08-11 05:00 +0200
SubjectRe: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
Message-ID<ud8l3-6e3-5@gated-at.bofh.it>
In reply to#1706037
On Tue, Aug 08, 2017 at 01:42:52PM +0800, Chunfeng Yun wrote:
> The mt8173-xhci.txt actually holds the bindings for all mediatek
> SoCs with xHCI controller, so add a generic compatible and change
> the name to xhci-mtk.txt to reflect that.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> similarity index 92%
> rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt

mediatek,mtk-xhci.txt

> index 0acfc8a..1ce77c7 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> @@ -11,7 +11,9 @@ into two parts.
>  ------------------------------------------------------------------------
>  
>  Required properties:
> - - compatible : should contain "mediatek,mt8173-xhci"
> + - compatible : should be one of
> +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),

NAK for same reason.

> +	"mediatek,xhci-mtk"

mediatek,mtk-xhci would be more in line with conventions.

>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
>   - interrupts : interrupt used by the controller
> @@ -68,10 +70,12 @@ usb30: usb@11270000 {
>  
>  In the case, xhci is added as subnode to mtu3. An example and the DT binding
>  details of mtu3 can be found in:
> -Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +Documentation/devicetree/bindings/usb/mtu3.txt
>  
>  Required properties:
> - - compatible : should contain "mediatek,mt8173-xhci"
> + - compatible : should be one of
> +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> +	"mediatek,xhci-mtk"
>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for xHCI MAC
>   - interrupts : interrupt used by the host controller
> -- 
> 1.7.9.5
>

[toc] | [prev] | [next] | [standalone]

#1709325 — Re: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-11 09:10 +0200
SubjectRe: [PATCH 4/4] dt-bindings: mt8173-xhci: add generic compatible and rename file
Message-ID<udceZ-tJ-7@gated-at.bofh.it>
In reply to#1709187
On Thu, 2017-08-10 at 21:56 -0500, Rob Herring wrote:
> On Tue, Aug 08, 2017 at 01:42:52PM +0800, Chunfeng Yun wrote:
> > The mt8173-xhci.txt actually holds the bindings for all mediatek
> > SoCs with xHCI controller, so add a generic compatible and change
> > the name to xhci-mtk.txt to reflect that.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} |   10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >  rename Documentation/devicetree/bindings/usb/{mt8173-xhci.txt => xhci-mtk.txt} (92%)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> > similarity index 92%
> > rename from Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > rename to Documentation/devicetree/bindings/usb/xhci-mtk.txt
> 
> mediatek,mtk-xhci.txt
Ok
> 
> > index 0acfc8a..1ce77c7 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/xhci-mtk.txt
> > @@ -11,7 +11,9 @@ into two parts.
> >  ------------------------------------------------------------------------
> >  
> >  Required properties:
> > - - compatible : should contain "mediatek,mt8173-xhci"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> 
> NAK for same reason.
It's backward compatible
> 
> > +	"mediatek,xhci-mtk"
> 
> mediatek,mtk-xhci would be more in line with conventions.
Ok
> 
> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for xHCI MAC and "ippc" for IP port control
> >   - interrupts : interrupt used by the controller
> > @@ -68,10 +70,12 @@ usb30: usb@11270000 {
> >  
> >  In the case, xhci is added as subnode to mtu3. An example and the DT binding
> >  details of mtu3 can be found in:
> > -Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +Documentation/devicetree/bindings/usb/mtu3.txt
> >  
> >  Required properties:
> > - - compatible : should contain "mediatek,mt8173-xhci"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-xhci" (deprecated, use "mediatek,xhci-mtk" instead),
> > +	"mediatek,xhci-mtk"
> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for xHCI MAC
> >   - interrupts : interrupt used by the host controller
> > -- 
> > 1.7.9.5
> >

[toc] | [prev] | [next] | [standalone]

#1706039 — [PATCH 2/4] usb: xhci-mtk: add generic compatible string

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-08 07:50 +0200
Subject[PATCH 2/4] usb: xhci-mtk: add generic compatible string
Message-ID<uc5yV-3pV-11@gated-at.bofh.it>
In reply to#1706036
The xhci-mtk driver is a generic driver for MediaTek xHCI IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 drivers/usb/host/xhci-mtk.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 67d5dc7..d2934b9 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -795,6 +795,7 @@ static int __maybe_unused xhci_mtk_resume(struct device *dev)
 #ifdef CONFIG_OF
 static const struct of_device_id mtk_xhci_of_match[] = {
 	{ .compatible = "mediatek,mt8173-xhci"},
+	{ .compatible = "mediatek,xhci-mtk"},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, mtk_xhci_of_match);
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1706040 — [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-08 07:50 +0200
Subject[PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
Message-ID<uc5yV-3pV-7@gated-at.bofh.it>
In reply to#1706036
The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mtu3.txt.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)

diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
similarity index 95%
rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
rename to Documentation/devicetree/bindings/usb/mtu3.txt
index 1d7c3bc..832741d 100644
--- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
+++ b/Documentation/devicetree/bindings/usb/mtu3.txt
@@ -1,7 +1,9 @@
 The device node for Mediatek USB3.0 DRD controller
 
 Required properties:
- - compatible : should be "mediatek,mt8173-mtu3"
+ - compatible : should be one of
+	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
+	"mediatek,mtu3"
  - reg : specifies physical base address and size of the registers
  - reg-names: should be "mac" for device IP and "ippc" for IP port control
  - interrupts : interrupt used by the device IP
@@ -44,7 +46,7 @@ Optional properties:
 Sub-nodes:
 The xhci should be added as subnode to mtu3 as shown in the following example
 if host mode is enabled. The DT binding details of xhci can be found in:
-Documentation/devicetree/bindings/usb/mt8173-xhci.txt
+Documentation/devicetree/bindings/usb/xhci-mtk.txt
 
 Example:
 ssusb: usb@11271000 {
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1709185 — Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

FromRob Herring <robh@kernel.org>
Date2017-08-11 05:00 +0200
SubjectRe: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
Message-ID<ud8l3-6e3-1@gated-at.bofh.it>
In reply to#1706040
On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> SoCs with usb3 DRD IP, so add a generic compatible and change the
> name to mtu3.txt.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>  rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> similarity index 95%
> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> rename to Documentation/devicetree/bindings/usb/mtu3.txt
> index 1d7c3bc..832741d 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +++ b/Documentation/devicetree/bindings/usb/mtu3.txt

mediatek,mtu3.txt

> @@ -1,7 +1,9 @@
>  The device node for Mediatek USB3.0 DRD controller
>  
>  Required properties:
> - - compatible : should be "mediatek,mt8173-mtu3"
> + - compatible : should be one of
> +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),

NAK. You can add generic compatibles, but you need SoC specific ones in 
addition.

> +	"mediatek,mtu3"
>   - reg : specifies physical base address and size of the registers
>   - reg-names: should be "mac" for device IP and "ippc" for IP port control
>   - interrupts : interrupt used by the device IP
> @@ -44,7 +46,7 @@ Optional properties:
>  Sub-nodes:
>  The xhci should be added as subnode to mtu3 as shown in the following example
>  if host mode is enabled. The DT binding details of xhci can be found in:
> -Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> +Documentation/devicetree/bindings/usb/xhci-mtk.txt

This should be in the patch that renames this file.

>  
>  Example:
>  ssusb: usb@11271000 {
> -- 
> 1.7.9.5
>

[toc] | [prev] | [next] | [standalone]

#1709322 — Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

FromChunfeng Yun <chunfeng.yun@mediatek.com>
Date2017-08-11 09:10 +0200
SubjectRe: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file
Message-ID<udceZ-tJ-1@gated-at.bofh.it>
In reply to#1709185
On Thu, 2017-08-10 at 21:54 -0500, Rob Herring wrote:
> On Tue, Aug 08, 2017 at 01:42:51PM +0800, Chunfeng Yun wrote:
> > The mt8173-mtu3.txt actually holds the bindings for all mediatek
> > SoCs with usb3 DRD IP, so add a generic compatible and change the
> > name to mtu3.txt.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> >  .../bindings/usb/{mt8173-mtu3.txt => mtu3.txt}     |    6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >  rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mtu3.txt} (95%)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> > similarity index 95%
> > rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > rename to Documentation/devicetree/bindings/usb/mtu3.txt
> > index 1d7c3bc..832741d 100644
> > --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> > +++ b/Documentation/devicetree/bindings/usb/mtu3.txt
> 
> mediatek,mtu3.txt
Ok
> 
> > @@ -1,7 +1,9 @@
> >  The device node for Mediatek USB3.0 DRD controller
> >  
> >  Required properties:
> > - - compatible : should be "mediatek,mt8173-mtu3"
> > + - compatible : should be one of
> > +	"mediatek,mt8173-mtu3" (deprecated, use "mediatek,mtu3" instead),
> 
> NAK. You can add generic compatibles, but you need SoC specific ones in 
> addition.
It's for backward compatibility

> 
> > +	"mediatek,mtu3"
Is it appropriate if changed to "mediatek,generic-mtu3"?

> >   - reg : specifies physical base address and size of the registers
> >   - reg-names: should be "mac" for device IP and "ippc" for IP port control
> >   - interrupts : interrupt used by the device IP
> > @@ -44,7 +46,7 @@ Optional properties:
> >  Sub-nodes:
> >  The xhci should be added as subnode to mtu3 as shown in the following example
> >  if host mode is enabled. The DT binding details of xhci can be found in:
> > -Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > +Documentation/devicetree/bindings/usb/xhci-mtk.txt
> 
> This should be in the patch that renames this file.
Ok
> 
> >  
> >  Example:
> >  ssusb: usb@11271000 {
> > -- 
> > 1.7.9.5
> >

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web