Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710457 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-13 11:10 +0200 |
| Last post | 2017-08-22 10:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] crypto: sahara: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-13 11:10 +0200
Re: [PATCH] crypto: sahara: constify platform_device_id Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-22 10:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-13 11:10 +0200 |
| Subject | [PATCH] crypto: sahara: constify platform_device_id |
| Message-ID | <udX4e-5hn-9@gated-at.bofh.it> |
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/sahara.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 1d9ecd3..39efa65 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1376,7 +1376,7 @@ static void sahara_unregister_algs(struct sahara_dev *dev)
crypto_unregister_ahash(&sha_v4_algs[i]);
}
-static struct platform_device_id sahara_platform_ids[] = {
+static const struct platform_device_id sahara_platform_ids[] = {
{ .name = "sahara-imx27" },
{ /* sentinel */ }
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2017-08-22 10:00 +0200 |
| Message-ID | <uhcgq-7KH-23@gated-at.bofh.it> |
| In reply to | #1710457 |
On Sun, Aug 13, 2017 at 02:34:00PM +0530, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by <linux/platform_device.h> > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web