Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710434 > unrolled thread

[PATCH 05/11] serial: uuc_uart: constify uart_ops structures

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 05/11] serial: uuc_uart: constify uart_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-13 08:50 +0200
    Re: [PATCH 05/11] serial: uuc_uart: constify uart_ops structures Timur Tabi <timur@tabi.org> - 2017-08-15 16:50 +0200

#1710434 — [PATCH 05/11] serial: uuc_uart: constify uart_ops structures

These uart_ops structures are only stored in the ops field of a
uart_port structure and this fields is const, so the uart_ops
structures can also be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/tty/serial/ucc_uart.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index 481eb29..55b7027 100644
--- a/drivers/tty/serial/ucc_uart.c
+++ b/drivers/tty/serial/ucc_uart.c
@@ -1085,7 +1085,7 @@ static int qe_uart_verify_port(struct uart_port *port,
  *
  * Details on these functions can be found in Documentation/serial/driver
  */
-static struct uart_ops qe_uart_pops = {
+static const struct uart_ops qe_uart_pops = {
 	.tx_empty       = qe_uart_tx_empty,
 	.set_mctrl      = qe_uart_set_mctrl,
 	.get_mctrl      = qe_uart_get_mctrl,

[toc] | [next] | [standalone]

#1712227

On 8/13/17 1:21 AM, Julia Lawall wrote:
> These uart_ops structures are only stored in the ops field of a
> uart_port structure and this fields is const, so the uart_ops
> structures can also be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall<Julia.Lawall@lip6.fr>

Acked-by: Timur Tabi <timur@tabi.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web