Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710332 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-08-12 19:00 +0200 |
| Last post | 2017-08-12 23:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 19:00 +0200
Re: [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:40 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-08-12 19:00 +0200 |
| Subject | [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() |
| Message-ID | <udHVw-3nQ-13@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 18:45:42 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/pci/mixart/mixart.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index 6d7fbf30618b..84f6b2651bf3 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -1052,10 +1052,8 @@ static int snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *card, int
};
chip = kzalloc(sizeof(*chip), GFP_KERNEL);
- if (! chip) {
- dev_err(card->dev, "cannot allocate chip\n");
+ if (!chip)
return -ENOMEM;
- }
chip->card = card;
chip->chip_idx = idx;
--
2.14.0
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-08-12 23:40 +0200 |
| Subject | Re: [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create() |
| Message-ID | <udMiu-6kh-9@gated-at.bofh.it> |
| In reply to | #1710332 |
On Sat, 12 Aug 2017 18:51:51 +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 12 Aug 2017 18:45:42 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied, thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web