Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710334 > unrolled thread
| Started by | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| First post | 2017-08-12 19:40 +0200 |
| Last post | 2017-08-12 19:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] au0828: fix unbalanced lock/unlock in au0828_usb_probe "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-12 19:40 +0200
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-08-12 19:40 +0200 |
| Subject | [PATCH] au0828: fix unbalanced lock/unlock in au0828_usb_probe |
| Message-ID | <udIye-3S9-9@gated-at.bofh.it> |
Call mutex_unlock and free dev on failure.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/media/usb/au0828/au0828-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c
index 739df61..cd363a2 100644
--- a/drivers/media/usb/au0828/au0828-core.c
+++ b/drivers/media/usb/au0828/au0828-core.c
@@ -628,6 +628,8 @@ static int au0828_usb_probe(struct usb_interface *interface,
if (retval) {
pr_err("%s() au0282_dev_register failed to register on V4L2\n",
__func__);
+ mutex_unlock(&dev->lock);
+ kfree(dev);
goto done;
}
--
2.5.0
Back to top | Article view | linux.kernel
csiph-web