Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710315 > unrolled thread

[PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const

Started byBhumika Goyal <bhumirks@gmail.com>
First post2017-08-12 17:40 +0200
Last post2017-08-12 23:40 +0200
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    [PATCH 06/16] ALSA: emu10k1: make snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    [PATCH 02/16] ALSA: ca0106: make snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    [PATCH 08/16] ALSA: lx6464es: make snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    [PATCH 12/16] ALSA: riptide: make snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    [PATCH 10/16] ALSA: ctxfi: make snd_pcm_hardware const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-12 17:40 +0200
    Re: [PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:40 +0200

#1710315 — [PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const
Message-ID<udGG5-2Bj-3@gated-at.bofh.it>
Declare snd_pcm_hardware const. 
Done using Coccinelle.

Bhumika Goyal (16):
  ALSA: aw2: make snd_pcm_hardware const
  ALSA: ca0106: make snd_pcm_hardware const
  ALSA: cs46xx: make snd_pcm_hardware const
  ALSA: korg1212: make snd_pcm_hardware const
  ALSA: cs5535audio: make snd_pcm_hardware const
  ALSA: emu10k1: make snd_pcm_hardware const
  ALSA: lola: make snd_pcm_hardware const
  ALSA: lx6464es: make snd_pcm_hardware const
  ALSA: mixart: make snd_pcm_hardware const
  ALSA: ctxfi: make snd_pcm_hardware const
  ALSA: pcxhr: make snd_pcm_hardware const
  ALSA: riptide: make snd_pcm_hardware const
  ALSA: rme9652: make snd_pcm_hardware const
  ALSA: trident: make snd_pcm_hardware const
  ALSA: ymfpci: make snd_pcm_hardware const
  ALSA: pci: make snd_pcm_hardware const

 sound/pci/ad1889.c                      |  4 ++--
 sound/pci/als300.c                      |  4 ++--
 sound/pci/als4000.c                     |  4 ++--
 sound/pci/atiixp.c                      |  2 +-
 sound/pci/atiixp_modem.c                |  2 +-
 sound/pci/aw2/aw2-alsa.c                |  4 ++--
 sound/pci/bt87x.c                       |  4 ++--
 sound/pci/ca0106/ca0106_main.c          |  4 ++--
 sound/pci/cmipci.c                      | 12 ++++++------
 sound/pci/cs4281.c                      |  4 ++--
 sound/pci/cs46xx/cs46xx_lib.c           |  4 ++--
 sound/pci/cs5535audio/cs5535audio_pcm.c |  4 ++--
 sound/pci/ctxfi/ctpcm.c                 |  6 +++---
 sound/pci/emu10k1/emu10k1x.c            |  4 ++--
 sound/pci/emu10k1/emupcm.c              | 10 +++++-----
 sound/pci/emu10k1/p16v.c                |  4 ++--
 sound/pci/ens1370.c                     |  6 +++---
 sound/pci/es1938.c                      |  4 ++--
 sound/pci/es1968.c                      |  4 ++--
 sound/pci/fm801.c                       |  4 ++--
 sound/pci/intel8x0.c                    |  2 +-
 sound/pci/intel8x0m.c                   |  2 +-
 sound/pci/korg1212/korg1212.c           |  4 ++--
 sound/pci/lola/lola_pcm.c               |  2 +-
 sound/pci/lx6464es/lx6464es.c           |  2 +-
 sound/pci/maestro3.c                    |  4 ++--
 sound/pci/mixart/mixart.c               |  4 ++--
 sound/pci/pcxhr/pcxhr.c                 |  2 +-
 sound/pci/riptide/riptide.c             |  4 ++--
 sound/pci/rme32.c                       |  8 ++++----
 sound/pci/rme96.c                       |  8 ++++----
 sound/pci/rme9652/hdsp.c                |  4 ++--
 sound/pci/rme9652/rme9652.c             |  4 ++--
 sound/pci/sis7019.c                     |  4 ++--
 sound/pci/sonicvibes.c                  |  4 ++--
 sound/pci/trident/trident_main.c        | 10 +++++-----
 sound/pci/via82xx.c                     |  2 +-
 sound/pci/via82xx_modem.c               |  2 +-
 sound/pci/ymfpci/ymfpci_main.c          |  4 ++--
 39 files changed, 85 insertions(+), 85 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1710316 — [PATCH 06/16] ALSA: emu10k1: make snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 06/16] ALSA: emu10k1: make snd_pcm_hardware const
Message-ID<udGG7-2Bj-45@gated-at.bofh.it>
In reply to#1710315
Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 sound/pci/emu10k1/emu10k1x.c |  4 ++--
 sound/pci/emu10k1/emupcm.c   | 10 +++++-----
 sound/pci/emu10k1/p16v.c     |  4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/sound/pci/emu10k1/emu10k1x.c b/sound/pci/emu10k1/emu10k1x.c
index 77a4413..2c2b12a 100644
--- a/sound/pci/emu10k1/emu10k1x.c
+++ b/sound/pci/emu10k1/emu10k1x.c
@@ -254,7 +254,7 @@ struct emu10k1x {
 };
 
 /* hardware definition */
-static struct snd_pcm_hardware snd_emu10k1x_playback_hw = {
+static const struct snd_pcm_hardware snd_emu10k1x_playback_hw = {
 	.info =			(SNDRV_PCM_INFO_MMAP | 
 				 SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -273,7 +273,7 @@ struct emu10k1x {
 	.fifo_size =		0,
 };
 
-static struct snd_pcm_hardware snd_emu10k1x_capture_hw = {
+static const struct snd_pcm_hardware snd_emu10k1x_capture_hw = {
 	.info =			(SNDRV_PCM_INFO_MMAP | 
 				 SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c
index 5c9054a..2683b97 100644
--- a/sound/pci/emu10k1/emupcm.c
+++ b/sound/pci/emu10k1/emupcm.c
@@ -556,7 +556,7 @@ static int snd_emu10k1_efx_playback_prepare(struct snd_pcm_substream *substream)
 	return 0;
 }
 
-static struct snd_pcm_hardware snd_emu10k1_efx_playback =
+static const struct snd_pcm_hardware snd_emu10k1_efx_playback =
 {
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_NONINTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -975,7 +975,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
  *  Playback support device description
  */
 
-static struct snd_pcm_hardware snd_emu10k1_playback =
+static const struct snd_pcm_hardware snd_emu10k1_playback =
 {
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -999,7 +999,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
  *  Capture support device description
  */
 
-static struct snd_pcm_hardware snd_emu10k1_capture =
+static const struct snd_pcm_hardware snd_emu10k1_capture =
 {
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -1019,7 +1019,7 @@ static snd_pcm_uframes_t snd_emu10k1_capture_pointer(struct snd_pcm_substream *s
 	.fifo_size =		0,
 };
 
-static struct snd_pcm_hardware snd_emu10k1_capture_efx =
+static const struct snd_pcm_hardware snd_emu10k1_capture_efx =
 {
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -1742,7 +1742,7 @@ static snd_pcm_uframes_t snd_emu10k1_fx8010_playback_pointer(struct snd_pcm_subs
 	return snd_pcm_indirect_playback_pointer(substream, &pcm->pcm_rec, ptr);
 }
 
-static struct snd_pcm_hardware snd_emu10k1_fx8010_playback =
+static const struct snd_pcm_hardware snd_emu10k1_fx8010_playback =
 {
 	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_RESUME |
diff --git a/sound/pci/emu10k1/p16v.c b/sound/pci/emu10k1/p16v.c
index c11f1a2..a30da78 100644
--- a/sound/pci/emu10k1/p16v.c
+++ b/sound/pci/emu10k1/p16v.c
@@ -122,7 +122,7 @@
  */
 
  /* hardware definition */
-static struct snd_pcm_hardware snd_p16v_playback_hw = {
+static const struct snd_pcm_hardware snd_p16v_playback_hw = {
 	.info =			SNDRV_PCM_INFO_MMAP | 
 				SNDRV_PCM_INFO_INTERLEAVED |
 				SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -143,7 +143,7 @@
 	.fifo_size =		0,
 };
 
-static struct snd_pcm_hardware snd_p16v_capture_hw = {
+static const struct snd_pcm_hardware snd_p16v_capture_hw = {
 	.info =			(SNDRV_PCM_INFO_MMAP |
 				 SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1710317 — [PATCH 02/16] ALSA: ca0106: make snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 02/16] ALSA: ca0106: make snd_pcm_hardware const
Message-ID<udGG7-2Bj-47@gated-at.bofh.it>
In reply to#1710315
Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 sound/pci/ca0106/ca0106_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index 6165a57..2be30b8 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -296,7 +296,7 @@
 };
 
 /* hardware definition */
-static struct snd_pcm_hardware snd_ca0106_playback_hw = {
+static const struct snd_pcm_hardware snd_ca0106_playback_hw = {
 	.info =			SNDRV_PCM_INFO_MMAP | 
 				SNDRV_PCM_INFO_INTERLEAVED |
 				SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -317,7 +317,7 @@
 	.fifo_size =		0,
 };
 
-static struct snd_pcm_hardware snd_ca0106_capture_hw = {
+static const struct snd_pcm_hardware snd_ca0106_capture_hw = {
 	.info =			(SNDRV_PCM_INFO_MMAP | 
 				 SNDRV_PCM_INFO_INTERLEAVED |
 				 SNDRV_PCM_INFO_BLOCK_TRANSFER |
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1710318 — [PATCH 08/16] ALSA: lx6464es: make snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 08/16] ALSA: lx6464es: make snd_pcm_hardware const
Message-ID<udGG7-2Bj-55@gated-at.bofh.it>
In reply to#1710315
Make this const as it is only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 sound/pci/lx6464es/lx6464es.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
index f9c3e86..9655b08 100644
--- a/sound/pci/lx6464es/lx6464es.c
+++ b/sound/pci/lx6464es/lx6464es.c
@@ -77,7 +77,7 @@
 
 
 /* alsa callbacks */
-static struct snd_pcm_hardware lx_caps = {
+static const struct snd_pcm_hardware lx_caps = {
 	.info             = (SNDRV_PCM_INFO_MMAP |
 			     SNDRV_PCM_INFO_INTERLEAVED |
 			     SNDRV_PCM_INFO_MMAP_VALID |
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1710320 — [PATCH 12/16] ALSA: riptide: make snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 12/16] ALSA: riptide: make snd_pcm_hardware const
Message-ID<udGG7-2Bj-57@gated-at.bofh.it>
In reply to#1710315
Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 sound/pci/riptide/riptide.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index f067c76..44f3b48 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -1315,7 +1315,7 @@ static int riptide_reset(struct cmdif *cif, struct snd_riptide *chip)
 	return 0;
 }
 
-static struct snd_pcm_hardware snd_riptide_playback = {
+static const struct snd_pcm_hardware snd_riptide_playback = {
 	.info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
 		 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP_VALID),
@@ -1334,7 +1334,7 @@ static int riptide_reset(struct cmdif *cif, struct snd_riptide *chip)
 	.periods_max = 64,
 	.fifo_size = 0,
 };
-static struct snd_pcm_hardware snd_riptide_capture = {
+static const struct snd_pcm_hardware snd_riptide_capture = {
 	.info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
 		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
 		 SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP_VALID),
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1710321 — [PATCH 10/16] ALSA: ctxfi: make snd_pcm_hardware const

FromBhumika Goyal <bhumirks@gmail.com>
Date2017-08-12 17:40 +0200
Subject[PATCH 10/16] ALSA: ctxfi: make snd_pcm_hardware const
Message-ID<udGG7-2Bj-59@gated-at.bofh.it>
In reply to#1710315
Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 sound/pci/ctxfi/ctpcm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c
index 9749780..358f520 100644
--- a/sound/pci/ctxfi/ctpcm.c
+++ b/sound/pci/ctxfi/ctpcm.c
@@ -21,7 +21,7 @@
 #include <sound/pcm.h>
 
 /* Hardware descriptions for playback */
-static struct snd_pcm_hardware ct_pcm_playback_hw = {
+static const struct snd_pcm_hardware ct_pcm_playback_hw = {
 	.info			= (SNDRV_PCM_INFO_MMAP |
 				   SNDRV_PCM_INFO_INTERLEAVED |
 				   SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -46,7 +46,7 @@
 	.fifo_size		= 0,
 };
 
-static struct snd_pcm_hardware ct_spdif_passthru_playback_hw = {
+static const struct snd_pcm_hardware ct_spdif_passthru_playback_hw = {
 	.info			= (SNDRV_PCM_INFO_MMAP |
 				   SNDRV_PCM_INFO_INTERLEAVED |
 				   SNDRV_PCM_INFO_BLOCK_TRANSFER |
@@ -69,7 +69,7 @@
 };
 
 /* Hardware descriptions for capture */
-static struct snd_pcm_hardware ct_pcm_capture_hw = {
+static const struct snd_pcm_hardware ct_pcm_capture_hw = {
 	.info			= (SNDRV_PCM_INFO_MMAP |
 				   SNDRV_PCM_INFO_INTERLEAVED |
 				   SNDRV_PCM_INFO_BLOCK_TRANSFER |
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1710373

FromTakashi Iwai <tiwai@suse.de>
Date2017-08-12 23:40 +0200
Message-ID<udMiu-6kh-3@gated-at.bofh.it>
In reply to#1710315
On Sat, 12 Aug 2017 17:31:12 +0200,
Bhumika Goyal wrote:
> 
> Declare snd_pcm_hardware const. 
> Done using Coccinelle.
> 
> Bhumika Goyal (16):
>   ALSA: aw2: make snd_pcm_hardware const
>   ALSA: ca0106: make snd_pcm_hardware const
>   ALSA: cs46xx: make snd_pcm_hardware const
>   ALSA: korg1212: make snd_pcm_hardware const
>   ALSA: cs5535audio: make snd_pcm_hardware const
>   ALSA: emu10k1: make snd_pcm_hardware const
>   ALSA: lola: make snd_pcm_hardware const
>   ALSA: lx6464es: make snd_pcm_hardware const
>   ALSA: mixart: make snd_pcm_hardware const
>   ALSA: ctxfi: make snd_pcm_hardware const
>   ALSA: pcxhr: make snd_pcm_hardware const
>   ALSA: riptide: make snd_pcm_hardware const
>   ALSA: rme9652: make snd_pcm_hardware const
>   ALSA: trident: make snd_pcm_hardware const
>   ALSA: ymfpci: make snd_pcm_hardware const
>   ALSA: pci: make snd_pcm_hardware const

Applied all 16 patches.  Thanks.


Takashi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web