Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710144 > unrolled thread

[PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao <jun.gao@mediatek.com> - 2017-08-12 05:00 +0200
    Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek  MT7622 Wolfram Sang <wsa@the-dreams.de> - 2017-08-12 16:50 +0200
      Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek  MT7622 Jun Gao <jun.gao@mediatek.com> - 2017-08-14 03:40 +0200
        Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek  MT7622 Wolfram Sang <wsa@the-dreams.de> - 2017-08-14 21:50 +0200

#1710144 — [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

From: Jun Gao <jun.gao@mediatek.com>

Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.

Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
 drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..2c7f847 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,14 @@ struct mtk_i2c {
 	.max_comb_2nd_msg_len = 31,
 };
 
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+	.max_num_msgs = 255,
+	.max_write_len = 65535,
+	.max_read_len = 65535,
+	.max_comb_1st_msg_len = 65535,
+	.max_comb_2nd_msg_len = 65535,
+};
+
 static const struct mtk_i2c_compatible mt6577_compat = {
 	.quirks = &mt6577_i2c_quirks,
 	.pmic_i2c = 0,
@@ -190,6 +198,15 @@ struct mtk_i2c {
 	.support_33bits = 0,
 };
 
+static const struct mtk_i2c_compatible mt7622_compat = {
+	.quirks = &mt7622_i2c_quirks,
+	.pmic_i2c = 0,
+	.dcm = 1,
+	.auto_restart = 1,
+	.aux_len_reg = 1,
+	.support_33bits = 0,
+};
+
 static const struct mtk_i2c_compatible mt8173_compat = {
 	.pmic_i2c = 0,
 	.dcm = 1,
@@ -201,6 +218,7 @@ struct mtk_i2c {
 static const struct of_device_id mtk_i2c_of_match[] = {
 	{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
 	{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
 	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
 	{}
 };
-- 
1.8.1.1

[toc] | [next] | [standalone]

#1710298 — Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

[Multipart message — attachments visible in raw view] — view raw

> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> +	.max_num_msgs = 255,
> +	.max_write_len = 65535,
> +	.max_read_len = 65535,
> +	.max_comb_1st_msg_len = 65535,
> +	.max_comb_2nd_msg_len = 65535,
> +};

That looks like no quirks? Then just leave the quirks pointer below
empty.

[toc] | [prev] | [next] | [standalone]

#1710602 — Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > +	.max_num_msgs = 255,
> > +	.max_write_len = 65535,
> > +	.max_read_len = 65535,
> > +	.max_comb_1st_msg_len = 65535,
> > +	.max_comb_2nd_msg_len = 65535,
> > +};
> 
> That looks like no quirks? Then just leave the quirks pointer below
> empty.
> 
Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.

Jun

[toc] | [prev] | [next] | [standalone]

#1711386 — Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 14, 2017 at 09:36:56AM +0800, Jun Gao wrote:
> On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > > +	.max_num_msgs = 255,
> > > +	.max_write_len = 65535,
> > > +	.max_read_len = 65535,
> > > +	.max_comb_1st_msg_len = 65535,
> > > +	.max_comb_2nd_msg_len = 65535,
> > > +};
> > 
> > That looks like no quirks? Then just leave the quirks pointer below
> > empty.
> > 
> Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.

I see. But you can safely drop all the length settings. The i2c core has
this comment in quirk handling:

/* Check if val is exceeding the quirk IFF quirk is non 0 */

IFF means "if and only if".

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web