Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708978 > unrolled thread

Re: [PATCH 16/29] scsi: esas2r: constify pci_device_id.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 16/29] scsi: esas2r: constify pci_device_id. Bradley Grove <bgrove@attotech.com> - 2017-08-10 21:20 +0200

#1708978 — Re: [PATCH 16/29] scsi: esas2r: constify pci_device_id.

Looks good.

Acked-by: Bradley Grove <bgrove@attotech.com>


On 07/30/2017 04:40 AM, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>   drivers/scsi/esas2r/esas2r_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/esas2r/esas2r_main.c b/drivers/scsi/esas2r/esas2r_main.c
> index f2e9d8a..81f226b 100644
> --- a/drivers/scsi/esas2r/esas2r_main.c
> +++ b/drivers/scsi/esas2r/esas2r_main.c
> @@ -309,7 +309,7 @@ MODULE_PARM_DESC(interrupt_mode,
>   		 "Defines the interrupt mode to use.  0 for legacy"
>   		 ", 1 for MSI.  Default is MSI (1).");
>   
> -static struct pci_device_id
> +static const struct pci_device_id
>   	esas2r_pci_table[] = {
>   	{ ATTO_VENDOR_ID, 0x0049,	  ATTO_VENDOR_ID, 0x0049,
>   	  0,
> 




This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.   

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web