Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1700398 > unrolled thread

[PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA

Started byArnd Bergmann <arnd@arndb.de>
First post2017-07-31 23:20 +0200
Last post2017-08-09 16:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA Arnd Bergmann <arnd@arndb.de> - 2017-07-31 23:20 +0200
    Re: [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-09 16:00 +0200

#1700398 — [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA

FromArnd Bergmann <arnd@arndb.de>
Date2017-07-31 23:20 +0200
Subject[PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA
Message-ID<u9qgy-2Se-17@gated-at.bofh.it>
Without the base RSA code, we run into a link error:

ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!

Like the other drivers implementing RSA in hardware, this
can be avoided by always enabling the base support when we build
CCP.

Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/crypto/ccp/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
index 15b63fd3d180..6d626606b9c5 100644
--- a/drivers/crypto/ccp/Kconfig
+++ b/drivers/crypto/ccp/Kconfig
@@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO
 	select CRYPTO_HASH
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AUTHENC
+	select CRYPTO_RSA
 	help
 	  Support for using the cryptographic API with the AMD Cryptographic
 	  Coprocessor. This module supports offload of SHA and AES algorithms.
-- 
2.9.0

[toc] | [next] | [standalone]


#1707351

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2017-08-09 16:00 +0200
Message-ID<uczGF-85m-3@gated-at.bofh.it>
In reply to#1700398
On Mon, Jul 31, 2017 at 11:10:57PM +0200, Arnd Bergmann wrote:
> Without the base RSA code, we run into a link error:
> 
> ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
> ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
> 
> Like the other drivers implementing RSA in hardware, this
> can be avoided by always enabling the base support when we build
> CCP.
> 
> Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web