Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705218 > unrolled thread

Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-07 10:20 +0200
    Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to  usb/common Lu Baolu <baolu.lu@linux.intel.com> - 2017-08-08 03:30 +0200
      Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-08-08 08:20 +0200
        Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to  usb/common Lu Baolu <baolu.lu@linux.intel.com> - 2017-08-09 04:40 +0200

#1705218 — Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

[Multipart message — attachments visible in raw view] — view raw

Hi,

Lu Baolu <baolu.lu@linux.intel.com> writes:
> The component u_serial provides a glue layer between TTY layer
> and a USB gadget device needed to provide a basic serial port
> functionality. Currently, u_serial sits under gadget/function
> and depends on CONFIG_USB_GADGET to be compiled and used.
>
> Most of the serial gadget devices are based on a UDC (USB device
> controller) and implemented by making use of the Linux gadget
> frameworks. But we are facing other implementions as well. One
> example can be found with xHCI debug capability. The xHCI debug
> capability implements a serial gadget with hardware and firmware,
> and provides an interface similar with xHCI host for submitting
> and reaping the transfer requests.
>
> In order to make better use of u_serial when implementing xHCI
> debug capability in xHCI driver, this patch moves u_serial.c
> from gadget/function to usb/common, and moves u_serial.h from
> gadget/function to include/linux/usb.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

NAK, u_serial uses the gadget API. It's definitely not COMMON.

-- 
balbi

[toc] | [next] | [standalone]

#1705938 — Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi,

On 08/07/2017 04:13 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@linux.intel.com> writes:
>> The component u_serial provides a glue layer between TTY layer
>> and a USB gadget device needed to provide a basic serial port
>> functionality. Currently, u_serial sits under gadget/function
>> and depends on CONFIG_USB_GADGET to be compiled and used.
>>
>> Most of the serial gadget devices are based on a UDC (USB device
>> controller) and implemented by making use of the Linux gadget
>> frameworks. But we are facing other implementions as well. One
>> example can be found with xHCI debug capability. The xHCI debug
>> capability implements a serial gadget with hardware and firmware,
>> and provides an interface similar with xHCI host for submitting
>> and reaping the transfer requests.
>>
>> In order to make better use of u_serial when implementing xHCI
>> debug capability in xHCI driver, this patch moves u_serial.c
>> from gadget/function to usb/common, and moves u_serial.h from
>> gadget/function to include/linux/usb.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> NAK, u_serial uses the gadget API. It's definitely not COMMON.
>

Okay. It seems that I can't use u_serial anyway. I will implement
a new tty glue for my case.

Best regards,
Lu Baolu

[toc] | [prev] | [next] | [standalone]

#1706054

Hi,

Lu Baolu <baolu.lu@linux.intel.com> writes:
>> Lu Baolu <baolu.lu@linux.intel.com> writes:
>>> The component u_serial provides a glue layer between TTY layer
>>> and a USB gadget device needed to provide a basic serial port
>>> functionality. Currently, u_serial sits under gadget/function
>>> and depends on CONFIG_USB_GADGET to be compiled and used.
>>>
>>> Most of the serial gadget devices are based on a UDC (USB device
>>> controller) and implemented by making use of the Linux gadget
>>> frameworks. But we are facing other implementions as well. One
>>> example can be found with xHCI debug capability. The xHCI debug
>>> capability implements a serial gadget with hardware and firmware,
>>> and provides an interface similar with xHCI host for submitting
>>> and reaping the transfer requests.
>>>
>>> In order to make better use of u_serial when implementing xHCI
>>> debug capability in xHCI driver, this patch moves u_serial.c
>>> from gadget/function to usb/common, and moves u_serial.h from
>>> gadget/function to include/linux/usb.
>>>
>>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> NAK, u_serial uses the gadget API. It's definitely not COMMON.
>>
>
> Okay. It seems that I can't use u_serial anyway. I will implement
> a new tty glue for my case.

have you looked at drivers/usb/serial/?

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1707020 — Re: [PATCH v2 2/4] usb: common: Move u_serial from gadget/function to usb/common

Hi,

On 08/08/2017 02:14 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@linux.intel.com> writes:
>>> Lu Baolu <baolu.lu@linux.intel.com> writes:
>>>> The component u_serial provides a glue layer between TTY layer
>>>> and a USB gadget device needed to provide a basic serial port
>>>> functionality. Currently, u_serial sits under gadget/function
>>>> and depends on CONFIG_USB_GADGET to be compiled and used.
>>>>
>>>> Most of the serial gadget devices are based on a UDC (USB device
>>>> controller) and implemented by making use of the Linux gadget
>>>> frameworks. But we are facing other implementions as well. One
>>>> example can be found with xHCI debug capability. The xHCI debug
>>>> capability implements a serial gadget with hardware and firmware,
>>>> and provides an interface similar with xHCI host for submitting
>>>> and reaping the transfer requests.
>>>>
>>>> In order to make better use of u_serial when implementing xHCI
>>>> debug capability in xHCI driver, this patch moves u_serial.c
>>>> from gadget/function to usb/common, and moves u_serial.h from
>>>> gadget/function to include/linux/usb.
>>>>
>>>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>>> NAK, u_serial uses the gadget API. It's definitely not COMMON.
>>>
>> Okay. It seems that I can't use u_serial anyway. I will implement
>> a new tty glue for my case.
> have you looked at drivers/usb/serial/?
>

Yes, I've checked that. I think usb-serial framework is too complex
for this case. XHCI debug capability is a simple gadget attached to
xHCI host.

Best regards,
Lu Baolu

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web