Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1705296 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-07 11:40 +0200 |
| Last post | 2017-08-09 06:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] hwmon: adt7475: constify attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-07 11:40 +0200
Re: [v2] hwmon: adt7475: constify attribute_group structures Guenter Roeck <linux@roeck-us.net> - 2017-08-09 04:10 +0200
Re: [v2] hwmon: adt7475: constify attribute_group structures Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 06:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-07 11:40 +0200 |
| Subject | [PATCH v2] hwmon: adt7475: constify attribute_group structures |
| Message-ID | <ubMFX-6qF-5@gated-at.bofh.it> |
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
change in v2:
subject was not correct. Removed 'wusbhc' and '.'.
drivers/hwmon/adt7475.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 1baa213..9ef8499 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR,
NULL
};
-static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
-static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
-static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
-static struct attribute_group in0_attr_group = { .attrs = in0_attrs };
-static struct attribute_group in3_attr_group = { .attrs = in3_attrs };
-static struct attribute_group in4_attr_group = { .attrs = in4_attrs };
-static struct attribute_group in5_attr_group = { .attrs = in5_attrs };
-static struct attribute_group vid_attr_group = { .attrs = vid_attrs };
+static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
+static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
+static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
+static const struct attribute_group in0_attr_group = { .attrs = in0_attrs };
+static const struct attribute_group in3_attr_group = { .attrs = in3_attrs };
+static const struct attribute_group in4_attr_group = { .attrs = in4_attrs };
+static const struct attribute_group in5_attr_group = { .attrs = in5_attrs };
+static const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
static int adt7475_detect(struct i2c_client *client,
struct i2c_board_info *info)
--
1.9.1
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-08-09 04:10 +0200 |
| Subject | Re: [v2] hwmon: adt7475: constify attribute_group structures |
| Message-ID | <ucoBB-kV-7@gated-at.bofh.it> |
| In reply to | #1705296 |
On Mon, Aug 07, 2017 at 03:06:29PM +0530, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Kind of confused by this one. I applied a similar patch from you
back in July ??
Guenter
> ---
> change in v2:
> subject was not correct. Removed 'wusbhc' and '.'.
>
> drivers/hwmon/adt7475.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 1baa213..9ef8499 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR,
> NULL
> };
>
> -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
> -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
> -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
> -static struct attribute_group in0_attr_group = { .attrs = in0_attrs };
> -static struct attribute_group in3_attr_group = { .attrs = in3_attrs };
> -static struct attribute_group in4_attr_group = { .attrs = in4_attrs };
> -static struct attribute_group in5_attr_group = { .attrs = in5_attrs };
> -static struct attribute_group vid_attr_group = { .attrs = vid_attrs };
> +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
> +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
> +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
> +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs };
> +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs };
> +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs };
> +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs };
> +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>
> static int adt7475_detect(struct i2c_client *client,
> struct i2c_board_info *info)
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-09 06:20 +0200 |
| Subject | Re: [v2] hwmon: adt7475: constify attribute_group structures |
| Message-ID | <ucqDn-1IM-1@gated-at.bofh.it> |
| In reply to | #1707005 |
yes, Sorry for noise. After rebase, it' was showing unchanged.
On Wednesday 09 August 2017 07:35 AM, Guenter Roeck wrote:
> On Mon, Aug 07, 2017 at 03:06:29PM +0530, Arvind Yadav wrote:
>> attribute_group are not supposed to change at runtime. All functions
>> working with attribute_group provided by <linux/sysfs.h> work with
>> const attribute_group. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Kind of confused by this one. I applied a similar patch from you
> back in July ??
>
> Guenter
>
>> ---
>> change in v2:
>> subject was not correct. Removed 'wusbhc' and '.'.
>>
>> drivers/hwmon/adt7475.c | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
>> index 1baa213..9ef8499 100644
>> --- a/drivers/hwmon/adt7475.c
>> +++ b/drivers/hwmon/adt7475.c
>> @@ -1319,14 +1319,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_stall_disable, S_IRUGO | S_IWUSR,
>> NULL
>> };
>>
>> -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
>> -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
>> -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
>> -static struct attribute_group in0_attr_group = { .attrs = in0_attrs };
>> -static struct attribute_group in3_attr_group = { .attrs = in3_attrs };
>> -static struct attribute_group in4_attr_group = { .attrs = in4_attrs };
>> -static struct attribute_group in5_attr_group = { .attrs = in5_attrs };
>> -static struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>> +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs };
>> +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs };
>> +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs };
>> +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs };
>> +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs };
>> +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs };
>> +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs };
>> +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>>
>> static int adt7475_detect(struct i2c_client *client,
>> struct i2c_board_info *info)
~arvind
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web