Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1704897 > unrolled thread
| Started by | Mikko Rapeli <mikko.rapeli@iki.fi> |
|---|---|
| First post | 2017-08-06 19:10 +0200 |
| Last post | 2017-08-09 01:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t Mikko Rapeli <mikko.rapeli@iki.fi> - 2017-08-06 19:10 +0200
Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t Arnd Bergmann <arnd@arndb.de> - 2017-08-07 17:20 +0200
Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t "Dmitry V. Levin" <ldv@altlinux.org> - 2017-08-09 01:20 +0200
| From | Mikko Rapeli <mikko.rapeli@iki.fi> |
|---|---|
| Date | 2017-08-06 19:10 +0200 |
| Subject | [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t |
| Message-ID | <ubxdV-50T-51@gated-at.bofh.it> |
Fixes userspace compilation error:
error: unknown type name ‘size_t’
size_t bufsz;
Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: kexec@lists.infradead.org
Cc: Eric Biederman <ebiederm@xmission.com>
---
include/uapi/linux/kexec.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/kexec.h b/include/uapi/linux/kexec.h
index aae5ebf2022b..f964d83b2757 100644
--- a/include/uapi/linux/kexec.h
+++ b/include/uapi/linux/kexec.h
@@ -51,9 +51,9 @@
*/
struct kexec_segment {
const void *buf;
- size_t bufsz;
+ __kernel_size_t bufsz;
const void *mem;
- size_t memsz;
+ __kernel_size_t memsz;
};
#endif /* __KERNEL__ */
--
2.13.3
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-08-07 17:20 +0200 |
| Subject | Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t |
| Message-ID | <ubRYZ-1OG-21@gated-at.bofh.it> |
| In reply to | #1704897 |
On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli <mikko.rapeli@iki.fi> wrote: > Fixes userspace compilation error: > > error: unknown type name ‘size_t’ > size_t bufsz; > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > Cc: kexec@lists.infradead.org > Cc: Eric Biederman <ebiederm@xmission.com> Acked-by: Arnd Bergmann <arnd@arndb.de>
[toc] | [prev] | [next] | [standalone]
| From | "Dmitry V. Levin" <ldv@altlinux.org> |
|---|---|
| Date | 2017-08-09 01:20 +0200 |
| Subject | Re: [PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t |
| Message-ID | <uclX4-70m-17@gated-at.bofh.it> |
| In reply to | #1704897 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, Aug 06, 2017 at 06:44:12PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: unknown type name ‘size_t’
> size_t bufsz;
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> Cc: kexec@lists.infradead.org
> Cc: Eric Biederman <ebiederm@xmission.com>
> ---
> include/uapi/linux/kexec.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/kexec.h b/include/uapi/linux/kexec.h
> index aae5ebf2022b..f964d83b2757 100644
> --- a/include/uapi/linux/kexec.h
> +++ b/include/uapi/linux/kexec.h
> @@ -51,9 +51,9 @@
> */
> struct kexec_segment {
> const void *buf;
> - size_t bufsz;
> + __kernel_size_t bufsz;
> const void *mem;
> - size_t memsz;
> + __kernel_size_t memsz;
No, this is definitely wrong as it breaks x32.
I submitted an alternative fix some time ago, see
http://lkml.kernel.org/r/20170222224646.GC14311@altlinux.org
--
ldv
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web