Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706499 > unrolled thread

Question about bh1770glc.ko

Back to article view | Back to linux.kernel

Contents

  Question about bh1770glc.ko Anton Volkov <avolkov@ispras.ru> - 2017-08-08 14:50 +0200
    Re: Question about bh1770glc.ko Greg KH <gregkh@linuxfoundation.org> - 2017-08-08 17:00 +0200

#1706499 — Question about bh1770glc.ko

Hello.

In drivers/misc/bh1770glc.c several functions have comments stating that 
they must be called under lock protection, e.g. 
bh1770_prox_mode_control, bh1770_lux_interrupt_control, bh1770_lux_rate, 
bh1770_chip_on. However there are places where they are called without 
lock being held, e.g. during the bh1770_resume. Do you know anything 
about whether this is intended or this is a bug?

Thank you for your time.

-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avolkov@ispras.ru

[toc] | [next] | [standalone]

#1706636

On Tue, Aug 08, 2017 at 03:46:18PM +0300, Anton Volkov wrote:
> Hello.
> 
> In drivers/misc/bh1770glc.c several functions have comments stating that
> they must be called under lock protection, e.g. bh1770_prox_mode_control,
> bh1770_lux_interrupt_control, bh1770_lux_rate, bh1770_chip_on. However there
> are places where they are called without lock being held, e.g. during the
> bh1770_resume. Do you know anything about whether this is intended or this
> is a bug?
> 
> Thank you for your time.

I have no idea, sorry.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web