Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1706031 > unrolled thread
| Started by | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| First post | 2017-08-08 07:30 +0200 |
| Last post | 2017-08-10 17:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-08 07:30 +0200
Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect Tony Lindgren <tony@atomide.com> - 2017-08-10 00:10 +0200
Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect Kishon Vijay Abraham I <kishon@ti.com> - 2017-08-10 09:50 +0200
Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect Tony Lindgren <tony@atomide.com> - 2017-08-10 17:20 +0200
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-08-08 07:30 +0200 |
| Subject | [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect |
| Message-ID | <uc5fA-3gQ-13@gated-at.bofh.it> |
The GPIO polarity for MMC1 card detect is set to '0' which means
active-high. However the polarity should be active-low. Fix it
here.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
arch/arm/boot/dts/am571x-idk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am571x-idk.dts b/arch/arm/boot/dts/am571x-idk.dts
index 7b207835b2d1..adc70fb091a2 100644
--- a/arch/arm/boot/dts/am571x-idk.dts
+++ b/arch/arm/boot/dts/am571x-idk.dts
@@ -68,7 +68,7 @@
status = "okay";
vmmc-supply = <&ldo1_reg>;
bus-width = <4>;
- cd-gpios = <&gpio6 27 0>; /* gpio 219 */
+ cd-gpios = <&gpio6 27 GPIO_ACTIVE_LOW>; /* gpio 219 */
};
&omap_dwc3_2 {
--
2.11.0
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-08-10 00:10 +0200 |
| Subject | Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect |
| Message-ID | <ucHkU-4V7-81@gated-at.bofh.it> |
| In reply to | #1706031 |
* Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: > The GPIO polarity for MMC1 card detect is set to '0' which means > active-high. However the polarity should be active-low. Fix it > here. Can these wait for v4.14 merge window or do these fix known issues? Regards, Tony
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-08-10 09:50 +0200 |
| Subject | Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect |
| Message-ID | <ucQo9-2pY-9@gated-at.bofh.it> |
| In reply to | #1708012 |
Tony, On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote: > * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: >> The GPIO polarity for MMC1 card detect is set to '0' which means >> active-high. However the polarity should be active-low. Fix it >> here. > > Can these wait for v4.14 merge window or do these fix known > issues? These can go in the next merge window. I didn't observe any issue without this in omap_hsmmc driver. Thanks Kishon
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-08-10 17:20 +0200 |
| Subject | Re: [PATCH 1/2] ARM: dts: am571x-idk: Fix GPIO polarity for MMC1 card detect |
| Message-ID | <ucXpE-7qP-31@gated-at.bofh.it> |
| In reply to | #1708287 |
* Kishon Vijay Abraham I <kishon@ti.com> [170810 00:46]: > Tony, > > On Thursday 10 August 2017 03:38 AM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I <kishon@ti.com> [170807 22:22]: > >> The GPIO polarity for MMC1 card detect is set to '0' which means > >> active-high. However the polarity should be active-low. Fix it > >> here. > > > > Can these wait for v4.14 merge window or do these fix known > > issues? > > These can go in the next merge window. I didn't observe any issue without this > in omap_hsmmc driver. OK applying both into omap-for-v4.14/dt thanks. Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web