Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708540 > unrolled thread

[tip:sched/core] sched/cpupri: Don't re-initialize 'struct cpupri'

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [tip:sched/core] sched/cpupri: Don't re-initialize 'struct cpupri' tip-bot for Viresh Kumar <tipbot@zytor.com> - 2017-08-10 14:20 +0200

#1708540 — [tip:sched/core] sched/cpupri: Don't re-initialize 'struct cpupri'

Commit-ID:  1c2a4861dbfca373fea1ff2cf9e9793933d024ce
Gitweb:     http://git.kernel.org/tip/1c2a4861dbfca373fea1ff2cf9e9793933d024ce
Author:     Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Thu, 13 Apr 2017 14:45:50 +0530
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 10 Aug 2017 12:18:14 +0200

sched/cpupri: Don't re-initialize 'struct cpupri'

The 'struct cpupri' passed to cpupri_init() is already initialized to
zero. Don't do that again.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linaro-kernel@lists.linaro.org
Link: http://lkml.kernel.org/r/8a71d48c5a077500b6ddc1a41484c0ac8d3aad94.1492065513.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/cpupri.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/cpupri.c b/kernel/sched/cpupri.c
index 981fcd7..2511aba 100644
--- a/kernel/sched/cpupri.c
+++ b/kernel/sched/cpupri.c
@@ -209,8 +209,6 @@ int cpupri_init(struct cpupri *cp)
 {
 	int i;
 
-	memset(cp, 0, sizeof(*cp));
-
 	for (i = 0; i < CPUPRI_NR_PRIORITIES; i++) {
 		struct cpupri_vec *vec = &cp->pri_to_cpu[i];
 

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web