Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1708385 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2017-08-10 12:00 +0200 |
| Last post | 2017-08-11 23:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-10 12:00 +0200
Re: [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port() David Miller <davem@davemloft.net> - 2017-08-11 23:40 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-08-10 12:00 +0200 |
| Subject | [PATCH 1/2 net-next] hns3pf: fix hns3_del_tunnel_port() |
| Message-ID | <ucSpX-3Sk-1@gated-at.bofh.it> |
This function has a copy and paste bug so it accidentally calls the add
function instead of the delete function.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
index 069ae426aa24..e519795dff7c 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c
@@ -1138,7 +1138,7 @@ static void hns3_del_tunnel_port(struct net_device *netdev, u16 port,
udp_tnl->dst_port = 0;
/* TBD send command to hardware to del port */
if (h->ae_algo->ops->del_tunnel_udp)
- h->ae_algo->ops->add_tunnel_udp(h, port);
+ h->ae_algo->ops->del_tunnel_udp(h, port);
}
/* hns3_nic_udp_tunnel_add - Get notifiacetion about UDP tunnel ports
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-08-11 23:40 +0200 |
| Message-ID | <udpOW-eI-23@gated-at.bofh.it> |
| In reply to | #1708385 |
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 10 Aug 2017 12:54:59 +0300
> This function has a copy and paste bug so it accidentally calls the add
> function instead of the delete function.
>
> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web