Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1707401 > unrolled thread
| Started by | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| First post | 2017-08-09 17:10 +0200 |
| Last post | 2017-08-10 09:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 15/15] perf tests attr: Fix task term values Jiri Olsa <jolsa@redhat.com> - 2017-08-09 17:10 +0200
Re: [PATCH 15/15] perf tests attr: Fix task term values Thomas Richter <tmricht@linux.vnet.ibm.com> - 2017-08-10 09:10 +0200
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Date | 2017-08-09 17:10 +0200 |
| Subject | Re: [PATCH 15/15] perf tests attr: Fix task term values |
| Message-ID | <ucAMq-D4-17@gated-at.bofh.it> |
On Mon, Jul 03, 2017 at 04:50:30PM +0200, Jiri Olsa wrote: > The perf_event_attr::task is 1 by default for first (tracking) > event in the session. Setting task=1 as default and adding > task=0 for cases that need it. hm, looks like this one was overlooked.. thanks, jirka > > Link: http://lkml.kernel.org/n/tip-w4uuxbwcrf8cjjjbko3ujs95@git.kernel.org > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/tests/attr/base-record | 2 +- > tools/perf/tests/attr/test-record-group | 1 + > tools/perf/tests/attr/test-record-group-sampling | 2 +- > tools/perf/tests/attr/test-record-group1 | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record > index 31e0b1da830b..37940665f736 100644 > --- a/tools/perf/tests/attr/base-record > +++ b/tools/perf/tests/attr/base-record > @@ -23,7 +23,7 @@ comm=1 > freq=1 > inherit_stat=0 > enable_on_exec=1 > -task=0 > +task=1 > watermark=0 > precise_ip=0|1|2|3 > mmap_data=0 > diff --git a/tools/perf/tests/attr/test-record-group b/tools/perf/tests/attr/test-record-group > index 6e7961f6f7a5..618ba1c17474 100644 > --- a/tools/perf/tests/attr/test-record-group > +++ b/tools/perf/tests/attr/test-record-group > @@ -17,5 +17,6 @@ sample_type=327 > read_format=4 > mmap=0 > comm=0 > +task=0 > enable_on_exec=0 > disabled=0 > diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/tests/attr/test-record-group-sampling > index ef59afd6d635..f906b793196f 100644 > --- a/tools/perf/tests/attr/test-record-group-sampling > +++ b/tools/perf/tests/attr/test-record-group-sampling > @@ -23,7 +23,7 @@ sample_type=343 > > # PERF_FORMAT_ID | PERF_FORMAT_GROUP > read_format=12 > - > +task=0 > mmap=0 > comm=0 > enable_on_exec=0 > diff --git a/tools/perf/tests/attr/test-record-group1 b/tools/perf/tests/attr/test-record-group1 > index 87a222d014d8..48e8bd12fe46 100644 > --- a/tools/perf/tests/attr/test-record-group1 > +++ b/tools/perf/tests/attr/test-record-group1 > @@ -18,5 +18,6 @@ sample_type=327 > read_format=4 > mmap=0 > comm=0 > +task=0 > enable_on_exec=0 > disabled=0 > -- > 2.9.4 >
[toc] | [next] | [standalone]
| From | Thomas Richter <tmricht@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-08-10 09:10 +0200 |
| Message-ID | <ucPLs-2cT-19@gated-at.bofh.it> |
| In reply to | #1707401 |
On Wed, Aug 09, 2017 at 05:00:49PM +0200, Jiri Olsa wrote: > On Mon, Jul 03, 2017 at 04:50:30PM +0200, Jiri Olsa wrote: > > The perf_event_attr::task is 1 by default for first (tracking) > > event in the session. Setting task=1 as default and adding > > task=0 for cases that need it. > > hm, looks like this one was overlooked.. > > thanks, > jirka > > I have pull perf/core yesterday afternoon and could not find. However when this is already fixed, I will remove it from my patch list Thanks Thomas > > Link: http://lkml.kernel.org/n/tip-w4uuxbwcrf8cjjjbko3ujs95@git.kernel.org > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > --- > > tools/perf/tests/attr/base-record | 2 +- > > tools/perf/tests/attr/test-record-group | 1 + > > tools/perf/tests/attr/test-record-group-sampling | 2 +- > > tools/perf/tests/attr/test-record-group1 | 1 + > > 4 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/tests/attr/base-record b/tools/perf/tests/attr/base-record > > index 31e0b1da830b..37940665f736 100644 > > --- a/tools/perf/tests/attr/base-record > > +++ b/tools/perf/tests/attr/base-record > > @@ -23,7 +23,7 @@ comm=1 > > freq=1 > > inherit_stat=0 > > enable_on_exec=1 > > -task=0 > > +task=1 > > watermark=0 > > precise_ip=0|1|2|3 > > mmap_data=0 > > diff --git a/tools/perf/tests/attr/test-record-group b/tools/perf/tests/attr/test-record-group > > index 6e7961f6f7a5..618ba1c17474 100644 > > --- a/tools/perf/tests/attr/test-record-group > > +++ b/tools/perf/tests/attr/test-record-group > > @@ -17,5 +17,6 @@ sample_type=327 > > read_format=4 > > mmap=0 > > comm=0 > > +task=0 > > enable_on_exec=0 > > disabled=0 > > diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/tests/attr/test-record-group-sampling > > index ef59afd6d635..f906b793196f 100644 > > --- a/tools/perf/tests/attr/test-record-group-sampling > > +++ b/tools/perf/tests/attr/test-record-group-sampling > > @@ -23,7 +23,7 @@ sample_type=343 > > > > # PERF_FORMAT_ID | PERF_FORMAT_GROUP > > read_format=12 > > - > > +task=0 > > mmap=0 > > comm=0 > > enable_on_exec=0 > > diff --git a/tools/perf/tests/attr/test-record-group1 b/tools/perf/tests/attr/test-record-group1 > > index 87a222d014d8..48e8bd12fe46 100644 > > --- a/tools/perf/tests/attr/test-record-group1 > > +++ b/tools/perf/tests/attr/test-record-group1 > > @@ -18,5 +18,6 @@ sample_type=327 > > read_format=4 > > mmap=0 > > comm=0 > > +task=0 > > enable_on_exec=0 > > disabled=0 > > -- > > 2.9.4 > > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web