Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1708208 > unrolled thread
| Started by | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| First post | 2017-08-10 07:00 +0200 |
| Last post | 2017-08-11 03:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-10 07:00 +0200
Re: [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property Mark Brown <broonie@kernel.org> - 2017-08-10 17:00 +0200
Re: [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property jeffy <jeffy.chen@rock-chips.com> - 2017-08-11 03:40 +0200
| From | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-08-10 07:00 +0200 |
| Subject | [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property |
| Message-ID | <ucNJD-Jv-3@gated-at.bofh.it> |
Add a new rockchip,codec-names property, so that the driver can parse
the codecs by name.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v2:
Let rockchip,codec-names be a required property.
Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
index eac91db..05351df 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
@@ -5,6 +5,7 @@ Required properties:
- rockchip,cpu: The phandle of the Rockchip I2S controller that's
connected to the codecs
- rockchip,codec: The phandle of the MAX98357A/RT5514/DA7219 codecs
+- rockchip,codec-names: The names of the MAX98357A/RT5514/DA7219 codecs
Optional properties:
- dmic-wakeup-delay-ms : specify delay time (ms) for DMIC ready.
@@ -18,5 +19,6 @@ sound {
compatible = "rockchip,rk3399-gru-sound";
rockchip,cpu = <&i2s0>;
rockchip,codec = <&max98357a &rt5514 &da7219>;
+ rockchip,codec-names = "MAX98357A", "RT5514", "DA7219";
dmic-wakeup-delay-ms = <20>;
};
--
2.1.4
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-08-10 17:00 +0200 |
| Subject | Re: [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property |
| Message-ID | <ucX6h-723-3@gated-at.bofh.it> |
| In reply to | #1708208 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: > Add a new rockchip,codec-names property, so that the driver can parse > the codecs by name. Why? You're already referencing the CODECs by phandle and these names are not part of any ABI...
[toc] | [prev] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-08-11 03:40 +0200 |
| Subject | Re: [PATCH v2 3/3] dt-bindings: ASoC: rockchip: Add rockchip,codec-names property |
| Message-ID | <ud75E-5qQ-13@gated-at.bofh.it> |
| In reply to | #1708693 |
Hi Mark, On 08/10/2017 10:56 PM, Mark Brown wrote: > On Thu, Aug 10, 2017 at 12:54:58PM +0800, Jeffy Chen wrote: >> Add a new rockchip,codec-names property, so that the driver can parse >> the codecs by name. > > Why? You're already referencing the CODECs by phandle and these names > are not part of any ABI... > currently we are binding the phandles to a fixed codec list in the driver. but we want to make it dynamic, since some exist codecs could be optional, and some new codecs could be add for new board too. and the support of this new property in the driver is added in https://patchwork.kernel.org/patch/9892737
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web