Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1701602 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2017-08-02 02:30 +0200 |
| Last post | 2017-08-10 01:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / dock: constify attribute_group structure Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-08-02 02:30 +0200
Re: [PATCH] ACPI / dock: constify attribute_group structure "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-08-10 01:00 +0200
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2017-08-02 02:30 +0200 |
| Subject | [PATCH] ACPI / dock: constify attribute_group structure |
| Message-ID | <u9PHX-2zV-7@gated-at.bofh.it> |
Functions working with attribute_groups provided by <linux/sysfs.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
7902 3528 64 11494 2ce6 drivers/acpi/dock.o
File size after:
text data bss dec hex filename
7998 3432 64 11494 2ce6 drivers/acpi/dock.o
This change was made with the help of Coccinelle.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/acpi/dock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 0c00208..2305e1a 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -585,7 +585,7 @@ static struct attribute *dock_attributes[] = {
NULL
};
-static struct attribute_group dock_attribute_group = {
+static const struct attribute_group dock_attribute_group = {
.attrs = dock_attributes
};
--
2.7.4
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-08-10 01:00 +0200 |
| Message-ID | <ucI7g-5hs-11@gated-at.bofh.it> |
| In reply to | #1701602 |
On Wednesday, August 2, 2017 2:28:46 AM CEST Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/sysfs.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 7902 3528 64 11494 2ce6 drivers/acpi/dock.o
>
> File size after:
> text data bss dec hex filename
> 7998 3432 64 11494 2ce6 drivers/acpi/dock.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/acpi/dock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index 0c00208..2305e1a 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -585,7 +585,7 @@ static struct attribute *dock_attributes[] = {
> NULL
> };
>
> -static struct attribute_group dock_attribute_group = {
> +static const struct attribute_group dock_attribute_group = {
> .attrs = dock_attributes
> };
>
>
Applied, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web