Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1708017 > unrolled thread

Re: [PATCH] nvmem: Convert to using %pOF instead of full_name

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] nvmem: Convert to using %pOF instead of full_name Rob Herring <robh@kernel.org> - 2017-08-10 00:20 +0200
    Re: [PATCH] nvmem: Convert to using %pOF instead of full_name Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2017-08-10 11:00 +0200

#1708017 — Re: [PATCH] nvmem: Convert to using %pOF instead of full_name

On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/nvmem/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ping?

>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 4c49285168fb..b0c60338296a 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>
>         addr = of_get_property(cell_np, "reg", &len);
>         if (!addr || (len < 2 * sizeof(u32))) {
> -               dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
> -                       cell_np->full_name);
> +               dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
> +                       cell_np);
>                 rval  = -EINVAL;
>                 goto err_mem;
>         }
> --
> 2.11.0
>

[toc] | [next] | [standalone]

#1708339

On 09/08/17 23:14, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>>   drivers/nvmem/core.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Ping?
I have already sent this patch to Greg to queue up for next.

Thanks,
srini

> 
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 4c49285168fb..b0c60338296a 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>>
>>          addr = of_get_property(cell_np, "reg", &len);
>>          if (!addr || (len < 2 * sizeof(u32))) {
>> -               dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
>> -                       cell_np->full_name);
>> +               dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
>> +                       cell_np);
>>                  rval  = -EINVAL;
>>                  goto err_mem;
>>          }
>> --
>> 2.11.0
>>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web