Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1707627 > unrolled thread

[PATCH 0/3] constify usb usb_device_id

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-09 19:50 +0200
Last post2017-08-09 19:50 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/3] constify usb usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 19:50 +0200
    [PATCH 1/3] usb: speedtch: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 19:50 +0200
    [PATCH 2/3] usb: hwa-hc: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-09 19:50 +0200

#1707627 — [PATCH 0/3] constify usb usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-09 19:50 +0200
Subject[PATCH 0/3] constify usb usb_device_id
Message-ID<ucDhf-20H-3@gated-at.bofh.it>
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] usb: speedtch: constify usb_device_id
  [PATCH 2/3] usb: hwa-hc: constify usb_device_id
  [PATCH 3/3] usb: yurex: constify usb_device_id

 drivers/usb/atm/speedtch.c | 2 +-
 drivers/usb/host/hwa-hc.c  | 2 +-
 drivers/usb/misc/yurex.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]


#1707629 — [PATCH 1/3] usb: speedtch: constify usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-09 19:50 +0200
Subject[PATCH 1/3] usb: speedtch: constify usb_device_id
Message-ID<ucDhg-20H-9@gated-at.bofh.it>
In reply to#1707627
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/usb/atm/speedtch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c
index 5083eb5..701ed37 100644
--- a/drivers/usb/atm/speedtch.c
+++ b/drivers/usb/atm/speedtch.c
@@ -738,7 +738,7 @@ static int speedtch_post_reset(struct usb_interface *intf)
 **  USB  **
 **********/
 
-static struct usb_device_id speedtch_usb_ids[] = {
+static const struct usb_device_id speedtch_usb_ids[] = {
 	{USB_DEVICE(0x06b9, 0x4061)},
 	{}
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1707630 — [PATCH 2/3] usb: hwa-hc: constify usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-09 19:50 +0200
Subject[PATCH 2/3] usb: hwa-hc: constify usb_device_id
Message-ID<ucDhg-20H-11@gated-at.bofh.it>
In reply to#1707627
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/usb/host/hwa-hc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa-hc.c
index 1db0626..b37cf20 100644
--- a/drivers/usb/host/hwa-hc.c
+++ b/drivers/usb/host/hwa-hc.c
@@ -860,7 +860,7 @@ static void hwahc_disconnect(struct usb_interface *usb_iface)
 	usb_put_hcd(usb_hcd);
 }
 
-static struct usb_device_id hwahc_id_table[] = {
+static const struct usb_device_id hwahc_id_table[] = {
 	/* Alereon 5310 */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x13dc, 0x5310, 0xe0, 0x02, 0x01),
 	  .driver_info = WUSB_QUIRK_ALEREON_HWA_CONCAT_ISOC |
-- 
2.7.4

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web