Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706055 > unrolled thread

[RESEND PATCH 0/2] Fix clock name in Aspeed GPIO bindings and driver

Back to article view | Back to linux.kernel

Contents

  [RESEND PATCH 0/2] Fix clock name in Aspeed GPIO bindings and driver Andrew Jeffery <andrew@aj.id.au> - 2017-08-08 08:20 +0200
    [RESEND PATCH 2/2] gpio: aspeed: Remove reference to clock name in debounce warning message Andrew Jeffery <andrew@aj.id.au> - 2017-08-08 08:20 +0200
      Re: [RESEND PATCH 2/2] gpio: aspeed: Remove reference to clock name  in debounce warning message Joel Stanley <joel@jms.id.au> - 2017-08-11 05:10 +0200

#1706055 — [RESEND PATCH 0/2] Fix clock name in Aspeed GPIO bindings and driver

Resending to fix Ryan's email address. I think I'll step away from computers
now.

Hello,

Joel discovered I brain-farted the referenced clock name in the patches
introducing the debounce capability for the Aspeed driver. The datasheet says
PCLK but I wrote HPLL for whatever reason, so clean up that mistake by simply
removing references to HPLL and put the onus on the devicetree author to
get it right.

Cheers,

Andrew

Andrew Jeffery (2):
  dt-bindings: gpio: aspeed: Remove reference to clock name
  gpio: aspeed: Remove reference to clock name in debounce warning
    message

 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 2 +-
 drivers/gpio/gpio-aspeed.c                             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1706056 — [RESEND PATCH 2/2] gpio: aspeed: Remove reference to clock name in debounce warning message

HPLL was in fact not the clock we need. Remove description of which
clock to avoid any further error.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---
 drivers/gpio/gpio-aspeed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 4ca436e66bdb..bfc53995064a 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -834,7 +834,7 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
 	gpio->clk = of_clk_get(pdev->dev.of_node, 0);
 	if (IS_ERR(gpio->clk)) {
 		dev_warn(&pdev->dev,
-				"No HPLL clock phandle provided, debouncing disabled\n");
+				"Failed to get clock from devicetree, debouncing disabled\n");
 		gpio->clk = NULL;
 	}
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1709192 — Re: [RESEND PATCH 2/2] gpio: aspeed: Remove reference to clock name in debounce warning message

On Tue, Aug 8, 2017 at 3:46 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> HPLL was in fact not the clock we need. Remove description of which
> clock to avoid any further error.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Acked-by: Joel Stanley <joel@jms.id.au>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web