Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704380 > unrolled thread

[PATCH 3.18 00/50] 3.18.64-stable review

Back to article view | Back to linux.kernel

Contents

  [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:40 +0200
    [PATCH 3.18 21/50] mailbox: always wait in mbox_send_message for blocking Tx mode Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:40 +0200
    [PATCH 3.18 01/50] af_key: Add lock to key dump Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:50 +0200
    [PATCH 3.18 02/50] pstore: Make spinlock per zone instead of global Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:50 +0200
    [PATCH 3.18 04/50] powerpc/pseries: Fix of_node_put() underflow during reconfig remove Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:50 +0200
    [PATCH 3.18 03/50] net: reduce skb_warn_bad_offload() noise Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 01:50 +0200
    Re: [PATCH 3.18 00/50] 3.18.64-stable review Guenter Roeck <linux@roeck-us.net> - 2017-08-05 03:50 +0200
      Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 04:50 +0200
        Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 05:00 +0200
          Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 05:10 +0200
            Re: [PATCH 3.18 00/50] 3.18.64-stable review Guenter Roeck <linux@roeck-us.net> - 2017-08-05 06:10 +0200
              Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 17:50 +0200
          Re: [PATCH 3.18 00/50] 3.18.64-stable review Willy Tarreau <w@1wt.eu> - 2017-08-05 08:00 +0200
            Re: [PATCH 3.18 00/50] 3.18.64-stable review Willy Tarreau <w@1wt.eu> - 2017-08-05 08:10 +0200
              Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 17:50 +0200
                Re: [PATCH 3.18 00/50] 3.18.64-stable review Guenter Roeck <linux@roeck-us.net> - 2017-08-05 21:20 +0200
                  Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-07 21:40 +0200
                    Re: [PATCH 3.18 00/50] 3.18.64-stable review Guenter Roeck <linux@roeck-us.net> - 2017-08-08 06:20 +0200
        Re: [PATCH 3.18 00/50] 3.18.64-stable review Guenter Roeck <linux@roeck-us.net> - 2017-08-05 06:00 +0200
          Re: [PATCH 3.18 00/50] 3.18.64-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-05 17:50 +0200
    Re: [PATCH 3.18 00/50] 3.18.64-stable review Shuah Khan <shuahkh@osg.samsung.com> - 2017-08-05 04:00 +0200

Page 1 of 2  [1] 2  Next page →

#1704380 — [PATCH 3.18 00/50] 3.18.64-stable review

This is the start of the stable review cycle for the 3.18.64 release.
There are 50 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.18.64-rc1.gz
or in the git tree and branch at:
  git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 3.18.64-rc1

Steffen Klassert <steffen.klassert@secunet.com>
    xfrm: Don't use sk_family for socket policy lookups

Mike Manning <mmanning@brocade.com>
    vlan: Propagate MAC address to VLANs

Phil Reid <preid@electromag.com.au>
    spi: dw: Make debugfs name unique between instances

Peter Ujfalusi <peter.ujfalusi@ti.com>
    ASoC: tlv320aic3x: Mark the RESET register as volatile

Arnd Bergmann <arnd@arndb.de>
    vfio-pci: use 32-bit comparisons for register address for gcc-4.5

Jordan Crouse <jcrouse@codeaurora.org>
    drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set

Jordan Crouse <jcrouse@codeaurora.org>
    drm/msm: Ensure that the hardware write pointer is valid

Leon Romanovsky <leonro@mellanox.com>
    net/mlx4: Remove BUG_ON from ICM allocation routine

Zheng Li <james.z.li@ericsson.com>
    ipv6: Should use consistent conditional judgement for ip6 fragment between __ip6_append_data and ip6_finish_output

Pali Rohár <pali.rohar@gmail.com>
    ARM: dts: n900: Mark eMMC slot with no-sdio and no-sd flags

Chun-Hao Lin <hau@realtek.com>
    r8169: add support for RTL8168 series add-on card.

Thomas Gleixner <tglx@linutronix.de>
    x86/mce/AMD: Make the init code more robust

Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    tpm: fix a kernel memory leak in tpm-sysfs.c

Eric Dumazet <edumazet@google.com>
    net: skb_needs_check() accepts CHECKSUM_NONE for tx

Kees Cook <keescook@chromium.org>
    pstore: Use dynamic spinlock initializer

Kees Cook <keescook@chromium.org>
    pstore: Correctly initialize spinlock and flags

Joel Fernandes <joelaf@google.com>
    pstore: Allow prz to control need for locking

Andrzej Hajda <a.hajda@samsung.com>
    v4l: s5c73m3: fix negation operator

Al Viro <viro@zeniv.linux.org.uk>
    dentry name snapshots

Valentin Vidic <Valentin.Vidic@CARNet.hr>
    ipmi/watchdog: fix watchdog timeout set on reboot

Daniel Borkmann <daniel@iogearbox.net>
    net, sched: fix soft lockup in tc_classify

Ben Hutchings <ben.hutchings@codethink.co.uk>
    sh_eth: Fix ethtool operation crash when net device is down

Daniel Borkmann <dborkman@redhat.com>
    net: sctp: fix race for one-to-many sockets in sendmsg's auto associate

Jan Stancek <jstancek@redhat.com>
    ipv6: fix possible deadlock in ip6_fl_purge / ip6_fl_gc

Oliver Neukum <oneukum@suse.com>
    kaweth: fix oops upon failed memory allocation

Oliver Neukum <oneukum@suse.com>
    kaweth: fix firmware download

Calvin Owens <calvinowens@fb.com>
    mpt3sas: Don't overreach ioc->reply_post[] during initialization

Sudeep Holla <sudeep.holla@arm.com>
    mailbox: handle empty message in tx_tick

Sudeep Holla <sudeep.holla@arm.com>
    mailbox: skip complete wait event if timer expired

Sudeep Holla <sudeep.holla@arm.com>
    mailbox: always wait in mbox_send_message for blocking Tx mode

Lior David <qca_liord@qca.qualcomm.com>
    wil6210: fix deadlock when using fw_no_recovery option

Annie Cherkaev <annie.cherk@gmail.com>
    isdn/i4l: fix buffer overflow

Chris Metcalf <cmetcalf@ezchip.com>
    strscpy: zero any trailing garbage bytes in the destination

Chris Metcalf <cmetcalf@ezchip.com>
    string: provide strscpy()

Jia-Ju Bai <baijiaju1990@163.com>
    isdn: Fix a sleep-in-atomic bug

Florian Fainelli <f.fainelli@gmail.com>
    net: phy: Do not perform software reset for Generic PHY

Al Viro <viro@zeniv.linux.org.uk>
    Bluetooth: cmtp: cmtp_add_connection() should verify that it's dealing with l2cap socket

Johan Hedberg <johan.hedberg@intel.com>
    Bluetooth: Fix potential NULL dereference

Al Viro <viro@zeniv.linux.org.uk>
    Bluetooth: bnep: bnep_add_connection() should verify that it's dealing with l2cap socket

Cheah Kok Cheong <thrust73@gmail.com>
    Staging: comedi: comedi_fops: Avoid orphaned proc entry

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Revert "powerpc/numa: Fix percpu allocations to be NUMA aware"

Paul Mackerras <paulus@ozlabs.org>
    KVM: PPC: Book3S HV: Save/restore host values of debug registers

Paul Mackerras <paulus@ozlabs.org>
    KVM: PPC: Book3S HV: Reload HTM registers explicitly

Paul Mackerras <paulus@ozlabs.org>
    KVM: PPC: Book3S HV: Restore critical SPRs to host values on guest exit

Sinclair Yeh <syeh@vmware.com>
    drm/vmwgfx: Fix gcc-7.1.1 warning

Ofer Heifetz <oferh@marvell.com>
    md/raid5: add thread_group worker async_tx_issue_pending_all

Laurent Vivier <lvivier@redhat.com>
    powerpc/pseries: Fix of_node_put() underflow during reconfig remove

Eric Dumazet <edumazet@google.com>
    net: reduce skb_warn_bad_offload() noise

Joel Fernandes <joelaf@google.com>
    pstore: Make spinlock per zone instead of global

Yuejie Shi <syjcnss@gmail.com>
    af_key: Add lock to key dump


-------------

Diffstat:

 Makefile                                  |  4 +-
 arch/arm/boot/dts/omap3-n900.dts          |  2 +
 arch/powerpc/include/asm/topology.h       | 14 -----
 arch/powerpc/kernel/setup_64.c            |  4 +-
 arch/powerpc/kvm/book3s_hv.c              | 29 ++++++++--
 arch/powerpc/kvm/book3s_hv_rmhandlers.S   | 37 +++++++++++--
 arch/powerpc/platforms/pseries/reconfig.c |  1 -
 arch/x86/kernel/cpu/mcheck/mce_amd.c      |  3 ++
 drivers/char/ipmi/ipmi_watchdog.c         |  7 +--
 drivers/char/tpm/tpm-sysfs.c              |  2 +
 drivers/gpu/drm/msm/adreno/adreno_gpu.c   |  9 +++-
 drivers/gpu/drm/msm/msm_gem_submit.c      |  3 +-
 drivers/gpu/drm/msm/msm_ringbuffer.c      |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c   |  2 +-
 drivers/isdn/i4l/isdn_common.c            |  1 +
 drivers/isdn/i4l/isdn_net.c               |  5 +-
 drivers/isdn/i4l/isdn_ppp.c               |  2 +-
 drivers/mailbox/mailbox.c                 | 13 +++--
 drivers/md/raid5.c                        |  2 +
 drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c |  2 +-
 drivers/net/ethernet/mellanox/mlx4/icm.c  |  7 ++-
 drivers/net/ethernet/realtek/r8169.c      |  1 +
 drivers/net/ethernet/renesas/sh_eth.c     | 10 ++++
 drivers/net/phy/phy_device.c              |  2 +-
 drivers/net/usb/kaweth.c                  | 10 ++--
 drivers/net/wireless/ath/wil6210/main.c   | 15 +++---
 drivers/scsi/mpt3sas/mpt3sas_base.c       | 33 ++++++------
 drivers/spi/spi-dw.c                      |  5 +-
 drivers/staging/comedi/comedi_fops.c      |  6 +--
 drivers/vfio/pci/vfio_pci_rdwr.c          |  5 +-
 fs/dcache.c                               | 27 ++++++++++
 fs/debugfs/inode.c                        | 10 ++--
 fs/namei.c                                |  8 +--
 fs/notify/fsnotify.c                      |  8 ++-
 fs/pstore/ram.c                           |  5 +-
 fs/pstore/ram_core.c                      | 25 +++++----
 include/linux/dcache.h                    |  7 +++
 include/linux/fsnotify.h                  | 31 -----------
 include/linux/phy.h                       |  4 ++
 include/linux/pstore_ram.h                | 11 +++-
 include/linux/string.h                    |  3 ++
 lib/string.c                              | 89 +++++++++++++++++++++++++++++++
 net/8021q/vlan.c                          |  5 ++
 net/8021q/vlan.h                          |  2 +
 net/8021q/vlan_dev.c                      | 20 +++++--
 net/bluetooth/bnep/core.c                 | 10 ++--
 net/bluetooth/cmtp/core.c                 |  3 ++
 net/core/dev.c                            | 19 ++++---
 net/ipv6/ip6_flowlabel.c                  |  4 +-
 net/ipv6/ip6_output.c                     |  2 +-
 net/key/af_key.c                          | 46 +++++++++++++---
 net/sched/cls_api.c                       |  4 +-
 net/sctp/socket.c                         |  8 ++-
 net/xfrm/xfrm_policy.c                    |  9 ++--
 sound/soc/codecs/tlv320aic3x.c            | 13 +++++
 55 files changed, 449 insertions(+), 163 deletions(-)

[toc] | [next] | [standalone]

#1704381 — [PATCH 3.18 21/50] mailbox: always wait in mbox_send_message for blocking Tx mode

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Sudeep Holla <sudeep.holla@arm.com>

commit c61b781ee084e69855477d23dd33e7e6caad652c upstream.

There exists a race when msg_submit return immediately as there was an
active request being processed which may have completed just before it's
checked again in mbox_send_message. This will result in return to the
caller without waiting in mbox_send_message even when it's blocking Tx.

This patch fixes the issue by waiting for the completion always if Tx
is in blocking mode.

Fixes: 2b6d83e2b8b7 ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Alexey Klimov <alexey.klimov@arm.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/mailbox/mailbox.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mailbox/mailbox.c
+++ b/drivers/mailbox/mailbox.c
@@ -255,7 +255,7 @@ int mbox_send_message(struct mbox_chan *
 	if (chan->txdone_method	== TXDONE_BY_POLL)
 		poll_txdone((unsigned long)chan->mbox);
 
-	if (chan->cl->tx_block && chan->active_req) {
+	if (chan->cl->tx_block) {
 		unsigned long wait;
 		int ret;
 

[toc] | [prev] | [next] | [standalone]

#1704385 — [PATCH 3.18 01/50] af_key: Add lock to key dump

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Yuejie Shi <syjcnss@gmail.com>

commit 89e357d83c06b6fac581c3ca7f0ee3ae7e67109e upstream.

A dump may come in the middle of another dump, modifying its dump
structure members. This race condition will result in NULL pointer
dereference in kernel. So add a lock to prevent that race.

Fixes: 83321d6b9872 ("[AF_KEY]: Dump SA/SP entries non-atomically")
Signed-off-by: Yuejie Shi <syjcnss@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Mark Salyzyn <salyzyn@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/key/af_key.c |   46 ++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 38 insertions(+), 8 deletions(-)

--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -63,6 +63,7 @@ struct pfkey_sock {
 		} u;
 		struct sk_buff	*skb;
 	} dump;
+	struct mutex dump_lock;
 };
 
 static int parse_sockaddr_pair(struct sockaddr *sa, int ext_len,
@@ -143,6 +144,7 @@ static int pfkey_create(struct net *net,
 {
 	struct netns_pfkey *net_pfkey = net_generic(net, pfkey_net_id);
 	struct sock *sk;
+	struct pfkey_sock *pfk;
 	int err;
 
 	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
@@ -157,6 +159,9 @@ static int pfkey_create(struct net *net,
 	if (sk == NULL)
 		goto out;
 
+	pfk = pfkey_sk(sk);
+	mutex_init(&pfk->dump_lock);
+
 	sock->ops = &pfkey_ops;
 	sock_init_data(sock, sk);
 
@@ -285,13 +290,23 @@ static int pfkey_do_dump(struct pfkey_so
 	struct sadb_msg *hdr;
 	int rc;
 
+	mutex_lock(&pfk->dump_lock);
+	if (!pfk->dump.dump) {
+		rc = 0;
+		goto out;
+	}
+
 	rc = pfk->dump.dump(pfk);
-	if (rc == -ENOBUFS)
-		return 0;
+	if (rc == -ENOBUFS) {
+		rc = 0;
+		goto out;
+	}
 
 	if (pfk->dump.skb) {
-		if (!pfkey_can_dump(&pfk->sk))
-			return 0;
+		if (!pfkey_can_dump(&pfk->sk)) {
+			rc = 0;
+			goto out;
+		}
 
 		hdr = (struct sadb_msg *) pfk->dump.skb->data;
 		hdr->sadb_msg_seq = 0;
@@ -302,6 +317,9 @@ static int pfkey_do_dump(struct pfkey_so
 	}
 
 	pfkey_terminate_dump(pfk);
+
+out:
+	mutex_unlock(&pfk->dump_lock);
 	return rc;
 }
 
@@ -1805,19 +1823,26 @@ static int pfkey_dump(struct sock *sk, s
 	struct xfrm_address_filter *filter = NULL;
 	struct pfkey_sock *pfk = pfkey_sk(sk);
 
-	if (pfk->dump.dump != NULL)
+	mutex_lock(&pfk->dump_lock);
+	if (pfk->dump.dump != NULL) {
+		mutex_unlock(&pfk->dump_lock);
 		return -EBUSY;
+	}
 
 	proto = pfkey_satype2proto(hdr->sadb_msg_satype);
-	if (proto == 0)
+	if (proto == 0) {
+		mutex_unlock(&pfk->dump_lock);
 		return -EINVAL;
+	}
 
 	if (ext_hdrs[SADB_X_EXT_FILTER - 1]) {
 		struct sadb_x_filter *xfilter = ext_hdrs[SADB_X_EXT_FILTER - 1];
 
 		filter = kmalloc(sizeof(*filter), GFP_KERNEL);
-		if (filter == NULL)
+		if (filter == NULL) {
+			mutex_unlock(&pfk->dump_lock);
 			return -ENOMEM;
+		}
 
 		memcpy(&filter->saddr, &xfilter->sadb_x_filter_saddr,
 		       sizeof(xfrm_address_t));
@@ -1833,6 +1858,7 @@ static int pfkey_dump(struct sock *sk, s
 	pfk->dump.dump = pfkey_dump_sa;
 	pfk->dump.done = pfkey_dump_sa_done;
 	xfrm_state_walk_init(&pfk->dump.u.state, proto, filter);
+	mutex_unlock(&pfk->dump_lock);
 
 	return pfkey_do_dump(pfk);
 }
@@ -2692,14 +2718,18 @@ static int pfkey_spddump(struct sock *sk
 {
 	struct pfkey_sock *pfk = pfkey_sk(sk);
 
-	if (pfk->dump.dump != NULL)
+	mutex_lock(&pfk->dump_lock);
+	if (pfk->dump.dump != NULL) {
+		mutex_unlock(&pfk->dump_lock);
 		return -EBUSY;
+	}
 
 	pfk->dump.msg_version = hdr->sadb_msg_version;
 	pfk->dump.msg_portid = hdr->sadb_msg_pid;
 	pfk->dump.dump = pfkey_dump_sp;
 	pfk->dump.done = pfkey_dump_sp_done;
 	xfrm_policy_walk_init(&pfk->dump.u.policy, XFRM_POLICY_TYPE_MAIN);
+	mutex_unlock(&pfk->dump_lock);
 
 	return pfkey_do_dump(pfk);
 }

[toc] | [prev] | [next] | [standalone]

#1704387 — [PATCH 3.18 02/50] pstore: Make spinlock per zone instead of global

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Joel Fernandes <joelaf@google.com>

commit 109704492ef637956265ec2eb72ae7b3b39eb6f4 upstream.

Currently pstore has a global spinlock for all zones. Since the zones
are independent and modify different areas of memory, there's no need
to have a global lock, so we should use a per-zone lock as introduced
here. Also, when ramoops's ftrace use-case has a FTRACE_PER_CPU flag
introduced later, which splits the ftrace memory area into a single zone
per CPU, it will eliminate the need for locking. In preparation for this,
make the locking optional.

Signed-off-by: Joel Fernandes <joelaf@google.com>
[kees: updated commit message]
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/pstore/ram_core.c       |   11 +++++------
 include/linux/pstore_ram.h |    1 +
 2 files changed, 6 insertions(+), 6 deletions(-)

--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -80,8 +80,6 @@ static void buffer_size_add_atomic(struc
 	} while (atomic_cmpxchg(&prz->buffer->size, old, new) != old);
 }
 
-static DEFINE_RAW_SPINLOCK(buffer_lock);
-
 /* increase and wrap the start pointer, returning the old value */
 static size_t buffer_start_add_locked(struct persistent_ram_zone *prz, size_t a)
 {
@@ -89,7 +87,7 @@ static size_t buffer_start_add_locked(st
 	int new;
 	unsigned long flags;
 
-	raw_spin_lock_irqsave(&buffer_lock, flags);
+	raw_spin_lock_irqsave(&prz->buffer_lock, flags);
 
 	old = atomic_read(&prz->buffer->start);
 	new = old + a;
@@ -97,7 +95,7 @@ static size_t buffer_start_add_locked(st
 		new -= prz->buffer_size;
 	atomic_set(&prz->buffer->start, new);
 
-	raw_spin_unlock_irqrestore(&buffer_lock, flags);
+	raw_spin_unlock_irqrestore(&prz->buffer_lock, flags);
 
 	return old;
 }
@@ -109,7 +107,7 @@ static void buffer_size_add_locked(struc
 	size_t new;
 	unsigned long flags;
 
-	raw_spin_lock_irqsave(&buffer_lock, flags);
+	raw_spin_lock_irqsave(&prz->buffer_lock, flags);
 
 	old = atomic_read(&prz->buffer->size);
 	if (old == prz->buffer_size)
@@ -121,7 +119,7 @@ static void buffer_size_add_locked(struc
 	atomic_set(&prz->buffer->size, new);
 
 exit:
-	raw_spin_unlock_irqrestore(&buffer_lock, flags);
+	raw_spin_unlock_irqrestore(&prz->buffer_lock, flags);
 }
 
 static size_t (*buffer_start_add)(struct persistent_ram_zone *, size_t) = buffer_start_add_atomic;
@@ -489,6 +487,7 @@ static int persistent_ram_post_init(stru
 
 	prz->buffer->sig = sig;
 	persistent_ram_zap(prz);
+	prz->buffer_lock = __RAW_SPIN_LOCK_UNLOCKED(buffer_lock);
 
 	return 0;
 }
--- a/include/linux/pstore_ram.h
+++ b/include/linux/pstore_ram.h
@@ -39,6 +39,7 @@ struct persistent_ram_zone {
 	void *vaddr;
 	struct persistent_ram_buffer *buffer;
 	size_t buffer_size;
+	raw_spinlock_t buffer_lock;
 
 	/* ECC correction */
 	char *par_buffer;

[toc] | [prev] | [next] | [standalone]

#1704407 — [PATCH 3.18 04/50] powerpc/pseries: Fix of_node_put() underflow during reconfig remove

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Laurent Vivier <lvivier@redhat.com>

commit 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 upstream.

As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
underflow during DLPAR remove"), the call to of_node_put() must be
removed from pSeries_reconfig_remove_node().

dlpar_detach_node() and pSeries_reconfig_remove_node() both call
of_detach_node(), and thus the node should not be released in both
cases.

Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/powerpc/platforms/pseries/reconfig.c |    1 -
 1 file changed, 1 deletion(-)

--- a/arch/powerpc/platforms/pseries/reconfig.c
+++ b/arch/powerpc/platforms/pseries/reconfig.c
@@ -112,7 +112,6 @@ static int pSeries_reconfig_remove_node(
 
 	of_detach_node(np);
 	of_node_put(parent);
-	of_node_put(np); /* Must decrement the refcount */
 	return 0;
 }
 

[toc] | [prev] | [next] | [standalone]

#1704411 — [PATCH 3.18 03/50] net: reduce skb_warn_bad_offload() noise

3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Eric Dumazet <edumazet@google.com>

commit b2504a5dbef3305ef41988ad270b0e8ec289331c upstream.

Dmitry reported warnings occurring in __skb_gso_segment() [1]

All SKB_GSO_DODGY producers can allow user space to feed
packets that trigger the current check.

We could prevent them from doing so, rejecting packets, but
this might add regressions to existing programs.

It turns out our SKB_GSO_DODGY handlers properly set up checksum
information that is needed anyway when packets needs to be segmented.

By checking again skb_needs_check() after skb_mac_gso_segment(),
we should remove these pesky warnings, at a very minor cost.

With help from Willem de Bruijn

[1]
WARNING: CPU: 1 PID: 6768 at net/core/dev.c:2439 skb_warn_bad_offload+0x2af/0x390 net/core/dev.c:2434
lo: caps=(0x000000a2803b7c69, 0x0000000000000000) len=138 data_len=0 gso_size=15883 gso_type=4 ip_summed=0
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 6768 Comm: syz-executor1 Not tainted 4.9.0 #5
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
 ffff8801c063ecd8 ffffffff82346bdf ffffffff00000001 1ffff100380c7d2e
 ffffed00380c7d26 0000000041b58ab3 ffffffff84b37e38 ffffffff823468f1
 ffffffff84820740 ffffffff84f289c0 dffffc0000000000 ffff8801c063ee20
Call Trace:
 [<ffffffff82346bdf>] __dump_stack lib/dump_stack.c:15 [inline]
 [<ffffffff82346bdf>] dump_stack+0x2ee/0x3ef lib/dump_stack.c:51
 [<ffffffff81827e34>] panic+0x1fb/0x412 kernel/panic.c:179
 [<ffffffff8141f704>] __warn+0x1c4/0x1e0 kernel/panic.c:542
 [<ffffffff8141f7e5>] warn_slowpath_fmt+0xc5/0x100 kernel/panic.c:565
 [<ffffffff8356cbaf>] skb_warn_bad_offload+0x2af/0x390 net/core/dev.c:2434
 [<ffffffff83585cd2>] __skb_gso_segment+0x482/0x780 net/core/dev.c:2706
 [<ffffffff83586f19>] skb_gso_segment include/linux/netdevice.h:3985 [inline]
 [<ffffffff83586f19>] validate_xmit_skb+0x5c9/0xc20 net/core/dev.c:2969
 [<ffffffff835892bb>] __dev_queue_xmit+0xe6b/0x1e70 net/core/dev.c:3383
 [<ffffffff8358a2d7>] dev_queue_xmit+0x17/0x20 net/core/dev.c:3424
 [<ffffffff83ad161d>] packet_snd net/packet/af_packet.c:2930 [inline]
 [<ffffffff83ad161d>] packet_sendmsg+0x32ed/0x4d30 net/packet/af_packet.c:2955
 [<ffffffff834f0aaa>] sock_sendmsg_nosec net/socket.c:621 [inline]
 [<ffffffff834f0aaa>] sock_sendmsg+0xca/0x110 net/socket.c:631
 [<ffffffff834f329a>] ___sys_sendmsg+0x8fa/0x9f0 net/socket.c:1954
 [<ffffffff834f5e58>] __sys_sendmsg+0x138/0x300 net/socket.c:1988
 [<ffffffff834f604d>] SYSC_sendmsg net/socket.c:1999 [inline]
 [<ffffffff834f604d>] SyS_sendmsg+0x2d/0x50 net/socket.c:1995
 [<ffffffff84371941>] entry_SYSCALL_64_fastpath+0x1f/0xc2

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov  <dvyukov@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Mark Salyzyn <salyzyn@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/core/dev.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2454,11 +2454,12 @@ static inline bool skb_needs_check(struc
 struct sk_buff *__skb_gso_segment(struct sk_buff *skb,
 				  netdev_features_t features, bool tx_path)
 {
+	struct sk_buff *segs;
+
 	if (unlikely(skb_needs_check(skb, tx_path))) {
 		int err;
 
-		skb_warn_bad_offload(skb);
-
+		/* We're going to init ->check field in TCP or UDP header */
 		err = skb_cow_head(skb, 0);
 		if (err < 0)
 			return ERR_PTR(err);
@@ -2470,7 +2471,12 @@ struct sk_buff *__skb_gso_segment(struct
 	skb_reset_mac_header(skb);
 	skb_reset_mac_len(skb);
 
-	return skb_mac_gso_segment(skb, features);
+	segs = skb_mac_gso_segment(skb, features);
+
+	if (unlikely(skb_needs_check(skb, tx_path)))
+		skb_warn_bad_offload(skb);
+
+	return segs;
 }
 EXPORT_SYMBOL(__skb_gso_segment);
 

[toc] | [prev] | [next] | [standalone]

#1704542

On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 3.18.64 release.
> There are 50 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> Anything received after that time might be too late.
> 

Preliminary:

Lots of

lib/string.c:31:32: fatal error: asm/word-at-a-time.h

affecting several architectures.

alpha:

lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'

Guenter

[toc] | [prev] | [next] | [standalone]

#1704551

On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 3.18.64 release.
> > There are 50 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > Anything received after that time might be too late.
> > 
> 
> Preliminary:
> 
> Lots of
> 
> lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> 
> affecting several architectures.
> 
> alpha:
> 
> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'

Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
zero_bytemask() on alpha and tile"), right?  Any other arches failing?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1704554

On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 3.18.64 release.
> > > There are 50 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > Anything received after that time might be too late.
> > > 
> > 
> > Preliminary:
> > 
> > Lots of
> > 
> > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > 
> > affecting several architectures.
> > 
> > alpha:
> > 
> > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> 
> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> zero_bytemask() on alpha and tile"), right?  Any other arches failing?

Hm, that doesn't work, do we care about tile? :)

Let me see how deep this hole is, I just wanted to get strscpy into 3.18
to fix a bug...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1704555

On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > There are 50 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > Preliminary:
> > > 
> > > Lots of
> > > 
> > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > 
> > > affecting several architectures.
> > > 
> > > alpha:
> > > 
> > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > 
> > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> 
> Hm, that doesn't work, do we care about tile? :)
> 
> Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> to fix a bug...

Ok, I think tile and alpha should be fixed, is there anything else that
is broken?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1704560

On 08/04/2017 08:00 PM, Greg Kroah-Hartman wrote:
> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
>> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
>>>> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
>>>>> This is the start of the stable review cycle for the 3.18.64 release.
>>>>> There are 50 patches in this series, all will be posted as a response
>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>> let me know.
>>>>>
>>>>> Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
>>>>> Anything received after that time might be too late.
>>>>>
>>>>
>>>> Preliminary:
>>>>
>>>> Lots of
>>>>
>>>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h
>>>>
>>>> affecting several architectures.
>>>>
>>>> alpha:
>>>>
>>>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
>>>
>>> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
>>> zero_bytemask() on alpha and tile"), right?  Any other arches failing?
>>
>> Hm, that doesn't work, do we care about tile? :)
>>
>> Let me see how deep this hole is, I just wanted to get strscpy into 3.18
>> to fix a bug...
> 
> Ok, I think tile and alpha should be fixed, is there anything else that
> is broken?
> 

Did you get my e-mail ? I sent it a couple of minutes ago.

Guenter

[toc] | [prev] | [next] | [standalone]

#1704662

On Fri, Aug 04, 2017 at 09:01:10PM -0700, Guenter Roeck wrote:
> On 08/04/2017 08:00 PM, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > > > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > > > There are 50 patches in this series, all will be posted as a response
> > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > > 
> > > > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > > > Anything received after that time might be too late.
> > > > > > 
> > > > > 
> > > > > Preliminary:
> > > > > 
> > > > > Lots of
> > > > > 
> > > > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > > > 
> > > > > affecting several architectures.
> > > > > 
> > > > > alpha:
> > > > > 
> > > > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > > > 
> > > > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > > > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > > 
> > > Hm, that doesn't work, do we care about tile? :)
> > > 
> > > Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> > > to fix a bug...
> > 
> > Ok, I think tile and alpha should be fixed, is there anything else that
> > is broken?
> > 
> 
> Did you get my e-mail ? I sent it a couple of minutes ago.

Yes, thanks, I've pushed out another update, that should fix all of
these.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1704576

On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > There are 50 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > Preliminary:
> > > 
> > > Lots of
> > > 
> > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > 
> > > affecting several architectures.
> > > 
> > > alpha:
> > > 
> > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > 
> > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> 
> Hm, that doesn't work, do we care about tile? :)
> 
> Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> to fix a bug...

I suspect you'll need this one which came as part of the strscpy() series
between 4.2 and 4.3 (though I have not tested) :

  commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
  Author: Chris Metcalf <cmetcalf@ezchip.com>
  Date:   Wed Apr 29 12:48:40 2015 -0400

    Make asm/word-at-a-time.h available on all architectures
    
    Added the x86 implementation of word-at-a-time to the
    generic version, which previously only supported big-endian.
    (...)
    
Willy

[toc] | [prev] | [next] | [standalone]

#1704578

On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > > There are 50 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > 
> > > > Preliminary:
> > > > 
> > > > Lots of
> > > > 
> > > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > > 
> > > > affecting several architectures.
> > > > 
> > > > alpha:
> > > > 
> > > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > > 
> > > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > 
> > Hm, that doesn't work, do we care about tile? :)
> > 
> > Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> > to fix a bug...
> 
> I suspect you'll need this one which came as part of the strscpy() series
> between 4.2 and 4.3 (though I have not tested) :
> 
>   commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
>   Author: Chris Metcalf <cmetcalf@ezchip.com>
>   Date:   Wed Apr 29 12:48:40 2015 -0400
> 
>     Make asm/word-at-a-time.h available on all architectures
>     
>     Added the x86 implementation of word-at-a-time to the
>     generic version, which previously only supported big-endian.
>     (...)

OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
which previously broke. It will not apply as-is, you'll need to drop the
change for arch/nios2/include/asm/Kbuild, and after that it's OK.

Willy

[toc] | [prev] | [next] | [standalone]

#1704660

On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote:
> On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
> > On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > > > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > > > There are 50 patches in this series, all will be posted as a response
> > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > > 
> > > > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > > > Anything received after that time might be too late.
> > > > > > 
> > > > > 
> > > > > Preliminary:
> > > > > 
> > > > > Lots of
> > > > > 
> > > > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > > > 
> > > > > affecting several architectures.
> > > > > 
> > > > > alpha:
> > > > > 
> > > > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > > > 
> > > > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > > > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > > 
> > > Hm, that doesn't work, do we care about tile? :)
> > > 
> > > Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> > > to fix a bug...
> > 
> > I suspect you'll need this one which came as part of the strscpy() series
> > between 4.2 and 4.3 (though I have not tested) :
> > 
> >   commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
> >   Author: Chris Metcalf <cmetcalf@ezchip.com>
> >   Date:   Wed Apr 29 12:48:40 2015 -0400
> > 
> >     Make asm/word-at-a-time.h available on all architectures
> >     
> >     Added the x86 implementation of word-at-a-time to the
> >     generic version, which previously only supported big-endian.
> >     (...)
> 
> OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
> which previously broke. It will not apply as-is, you'll need to drop the
> change for arch/nios2/include/asm/Kbuild, and after that it's OK.

Thanks for that, I've now queued that patch up.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1704696

On 08/05/2017 08:43 AM, Greg Kroah-Hartman wrote:
> On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote:
>> On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
>>> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
>>>> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
>>>>> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
>>>>>> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
>>>>>>> This is the start of the stable review cycle for the 3.18.64 release.
>>>>>>> There are 50 patches in this series, all will be posted as a response
>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>> let me know.
>>>>>>>
>>>>>>> Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
>>>>>>> Anything received after that time might be too late.
>>>>>>>
>>>>>>
>>>>>> Preliminary:
>>>>>>
>>>>>> Lots of
>>>>>>
>>>>>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h
>>>>>>
>>>>>> affecting several architectures.
>>>>>>
>>>>>> alpha:
>>>>>>
>>>>>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
>>>>>
>>>>> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
>>>>> zero_bytemask() on alpha and tile"), right?  Any other arches failing?
>>>>
>>>> Hm, that doesn't work, do we care about tile? :)
>>>>
>>>> Let me see how deep this hole is, I just wanted to get strscpy into 3.18
>>>> to fix a bug...
>>>
>>> I suspect you'll need this one which came as part of the strscpy() series
>>> between 4.2 and 4.3 (though I have not tested) :
>>>
>>>    commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
>>>    Author: Chris Metcalf <cmetcalf@ezchip.com>
>>>    Date:   Wed Apr 29 12:48:40 2015 -0400
>>>
>>>      Make asm/word-at-a-time.h available on all architectures
>>>      
>>>      Added the x86 implementation of word-at-a-time to the
>>>      generic version, which previously only supported big-endian.
>>>      (...)
>>
>> OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
>> which previously broke. It will not apply as-is, you'll need to drop the
>> change for arch/nios2/include/asm/Kbuild, and after that it's OK.
> 
> Thanks for that, I've now queued that patch up.
> 

Better, but there are still some errors.

powerpc:
lib/string.c: In function 'strscpy':
lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'

tile:
arch/tile/gxio/mpipe.c:46:15: error: conflicting types for 'strscpy'
include/linux/string.h:29:22: note: previous declaration of 'strscpy' was here

Missing patches:

7a5692e6e533 ("arch/powerpc: provide zero_bytemask() for big-endian")
30059d494a72 ("tile: use global strscpy() rather than private copy")

Guenter

[toc] | [prev] | [next] | [standalone]

#1705821

On Sat, Aug 05, 2017 at 12:11:19PM -0700, Guenter Roeck wrote:
> On 08/05/2017 08:43 AM, Greg Kroah-Hartman wrote:
> > On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote:
> > > On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
> > > > On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
> > > > > On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
> > > > > > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > > > > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > > > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > > > > > There are 50 patches in this series, all will be posted as a response
> > > > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > > > let me know.
> > > > > > > > 
> > > > > > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > > > > > Anything received after that time might be too late.
> > > > > > > > 
> > > > > > > 
> > > > > > > Preliminary:
> > > > > > > 
> > > > > > > Lots of
> > > > > > > 
> > > > > > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > > > > > 
> > > > > > > affecting several architectures.
> > > > > > > 
> > > > > > > alpha:
> > > > > > > 
> > > > > > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > > > > > 
> > > > > > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > > > > > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > > > > 
> > > > > Hm, that doesn't work, do we care about tile? :)
> > > > > 
> > > > > Let me see how deep this hole is, I just wanted to get strscpy into 3.18
> > > > > to fix a bug...
> > > > 
> > > > I suspect you'll need this one which came as part of the strscpy() series
> > > > between 4.2 and 4.3 (though I have not tested) :
> > > > 
> > > >    commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
> > > >    Author: Chris Metcalf <cmetcalf@ezchip.com>
> > > >    Date:   Wed Apr 29 12:48:40 2015 -0400
> > > > 
> > > >      Make asm/word-at-a-time.h available on all architectures
> > > >      Added the x86 implementation of word-at-a-time to the
> > > >      generic version, which previously only supported big-endian.
> > > >      (...)
> > > 
> > > OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
> > > which previously broke. It will not apply as-is, you'll need to drop the
> > > change for arch/nios2/include/asm/Kbuild, and after that it's OK.
> > 
> > Thanks for that, I've now queued that patch up.
> > 
> 
> Better, but there are still some errors.
> 
> powerpc:
> lib/string.c: In function 'strscpy':
> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> 
> tile:
> arch/tile/gxio/mpipe.c:46:15: error: conflicting types for 'strscpy'
> include/linux/string.h:29:22: note: previous declaration of 'strscpy' was here
> 
> Missing patches:
> 
> 7a5692e6e533 ("arch/powerpc: provide zero_bytemask() for big-endian")
> 30059d494a72 ("tile: use global strscpy() rather than private copy")

Thanks for these, I'll queue them up.  And do a -rc2 in a few days as
this was a mess...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1706004

On 08/07/2017 12:34 PM, Greg Kroah-Hartman wrote:
> On Sat, Aug 05, 2017 at 12:11:19PM -0700, Guenter Roeck wrote:
>> On 08/05/2017 08:43 AM, Greg Kroah-Hartman wrote:
>>> On Sat, Aug 05, 2017 at 08:02:17AM +0200, Willy Tarreau wrote:
>>>> On Sat, Aug 05, 2017 at 07:55:11AM +0200, Willy Tarreau wrote:
>>>>> On Fri, Aug 04, 2017 at 07:51:07PM -0700, Greg Kroah-Hartman wrote:
>>>>>> On Fri, Aug 04, 2017 at 07:46:57PM -0700, Greg Kroah-Hartman wrote:
>>>>>>> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
>>>>>>>> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
>>>>>>>>> This is the start of the stable review cycle for the 3.18.64 release.
>>>>>>>>> There are 50 patches in this series, all will be posted as a response
>>>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>>>> let me know.
>>>>>>>>>
>>>>>>>>> Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
>>>>>>>>> Anything received after that time might be too late.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Preliminary:
>>>>>>>>
>>>>>>>> Lots of
>>>>>>>>
>>>>>>>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h
>>>>>>>>
>>>>>>>> affecting several architectures.
>>>>>>>>
>>>>>>>> alpha:
>>>>>>>>
>>>>>>>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
>>>>>>>
>>>>>>> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
>>>>>>> zero_bytemask() on alpha and tile"), right?  Any other arches failing?
>>>>>>
>>>>>> Hm, that doesn't work, do we care about tile? :)
>>>>>>
>>>>>> Let me see how deep this hole is, I just wanted to get strscpy into 3.18
>>>>>> to fix a bug...
>>>>>
>>>>> I suspect you'll need this one which came as part of the strscpy() series
>>>>> between 4.2 and 4.3 (though I have not tested) :
>>>>>
>>>>>     commit a6e2f029ae34f41adb6ae3812c32c5d326e1abd2
>>>>>     Author: Chris Metcalf <cmetcalf@ezchip.com>
>>>>>     Date:   Wed Apr 29 12:48:40 2015 -0400
>>>>>
>>>>>       Make asm/word-at-a-time.h available on all architectures
>>>>>       Added the x86 implementation of word-at-a-time to the
>>>>>       generic version, which previously only supported big-endian.
>>>>>       (...)
>>>>
>>>> OK I just applied it on top of 3.18.64-rc1 and it allowed me to build mips
>>>> which previously broke. It will not apply as-is, you'll need to drop the
>>>> change for arch/nios2/include/asm/Kbuild, and after that it's OK.
>>>
>>> Thanks for that, I've now queued that patch up.
>>>
>>
>> Better, but there are still some errors.
>>
>> powerpc:
>> lib/string.c: In function 'strscpy':
>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
>>
>> tile:
>> arch/tile/gxio/mpipe.c:46:15: error: conflicting types for 'strscpy'
>> include/linux/string.h:29:22: note: previous declaration of 'strscpy' was here
>>
>> Missing patches:
>>
>> 7a5692e6e533 ("arch/powerpc: provide zero_bytemask() for big-endian")
>> 30059d494a72 ("tile: use global strscpy() rather than private copy")
> 
> Thanks for these, I'll queue them up.  And do a -rc2 in a few days as
> this was a mess...
> 

Getting there. With v3.18.63-62-gc7d9ae0:

Build results:
	total: 136 pass: 136 fail: 0
Qemu test results:
	total: 111 pass: 111 fail: 0

Details are available at http://kerneltests.org/builders.

Guenter

[toc] | [prev] | [next] | [standalone]

#1704559

On 08/04/2017 07:46 PM, Greg Kroah-Hartman wrote:
> On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
>> On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 3.18.64 release.
>>> There are 50 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
>>> Anything received after that time might be too late.
>>>
>>
>> Preliminary:
>>
>> Lots of
>>
>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h
>>
>> affecting several architectures.
>>
>> alpha:
>>
>> lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> 
> Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> 

Yes, you could say so. Is the offending patch really needed ?

Guenter

total: 136 pass: 68 fail: 68
Failed builds:
alpha:defconfig
alpha:allmodconfig
alpha:allnoconfig
arc:defconfig
arc:allnoconfig
arc:tb10x_defconfig
blackfin:defconfig
blackfin:BF561-EZKIT-SMP_defconfig
c6x:dsk6455_defconfig
c6x:evmc6457_defconfig
c6x:evmc6678_defconfig
cris:defconfig
cris:allnoconfig
cris:etrax-100lx_defconfig
cris:artpec_3_defconfig
cris:etraxfs_defconfig
frv:defconfig
hexagon:defconfig
hexagon:allnoconfig
ia64:defconfig
ia64:allnoconfig
m32r:defconfig
metag:defconfig
metag:allnoconfig
metag:meta1_defconfig
metag:meta2_defconfig
metag:meta2_smp_defconfig
microblaze:mmu_defconfig
microblaze:nommu_defconfig
microblaze:allnoconfig
mips:defconfig
mips:allnoconfig
mips:defconfig
mips:allmodconfig
mips:allnoconfig
mips:bcm47xx_defconfig
mips:bcm63xx_defconfig
mips:nlm_xlp_defconfig
mips:ath79_defconfig
mips:ar7_defconfig
mips:e55_defconfig
mips:cavium_octeon_defconfig
mips:malta_defconfig
mips:rt305x_defconfig
mn10300:asb2303_defconfig
mn10300:asb2364_defconfig
powerpc:defconfig
powerpc:allmodconfig
powerpc:allnoconfig
powerpc:ppc64e_defconfig
powerpc:cell_defconfig
powerpc:maple_defconfig
powerpc:ppc6xx_defconfig
powerpc:mpc83xx_defconfig
powerpc:tqm8xx_defconfig
powerpc:85xx/sbc8548_defconfig
powerpc:83xx/mpc834x_mds_defconfig
powerpc:86xx/sbc8641d_defconfig
s390:defconfig
s390:allmodconfig
s390:allnoconfig
score:defconfig
tile:tilegx_defconfig
unicore32:defconfig
unicore32:allnoconfig
xtensa:defconfig
xtensa:allmodconfig
xtensa:allnoconfig

Qemu:

total: 111 pass: 78 fail: 33
Failed tests:
alpha:defconfig
metag:meta2_defconfig
metag:tz1090_defconfig
microblaze:microblaze_defconfig
microblaze:microblazeel_defconfig
mips:malta_defconfig:nosmp
mips:malta_defconfig:smp
mips64:malta_defconfig:nosmp
mips64:malta_defconfig:smp
mipsel:24Kf:malta_defconfig:nosmp
mipsel:24Kf:malta_defconfig:smp
mipsel64:malta_defconfig:nosmp
mipsel64:malta_defconfig:smp
mipsel64:fuloong2e_defconfig:fulong2e
powerpc:mac99:nosmp:ppc_book3s_defconfig
powerpc:g3beige:nosmp:ppc_book3s_defconfig
powerpc:mac99:smp:ppc_book3s_defconfig
powerpc:virtex-ml507:44x/virtex5_defconfig
powerpc:mpc8544ds:mpc85xx_defconfig
powerpc:mpc8544ds:mpc85xx_smp_defconfig
powerpc:mpc8548cds:85xx/mpc85xx_cds_defconfig
powerpc:mpc8548cds:smpdev:85xx/mpc85xx_cds_defconfig
powerpc:bamboo:44x/bamboo_defconfig
powerpc:mac99:ppc64_book3s_defconfig:nosmp
powerpc:mac99:ppc64_book3s_defconfig:smp4
powerpc:pseries:pseries_defconfig
powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp
powerpc:mpc8544ds:ppc64_e5500_defconfig:smp
s390:defconfig
xtensa:dc232b:lx60:generic_kc705_defconfig
xtensa:dc232b:kc705:generic_kc705_defconfig
xtensa:dc233c:ml605:generic_kc705_defconfig
xtensa:dc233c:kc705:generic_kc705_defconfig

[toc] | [prev] | [next] | [standalone]

#1704661

On Fri, Aug 04, 2017 at 08:57:29PM -0700, Guenter Roeck wrote:
> On 08/04/2017 07:46 PM, Greg Kroah-Hartman wrote:
> > On Fri, Aug 04, 2017 at 06:43:50PM -0700, Guenter Roeck wrote:
> > > On 08/04/2017 04:15 PM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 3.18.64 release.
> > > > There are 50 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sun Aug  6 23:15:34 UTC 2017.
> > > > Anything received after that time might be too late.
> > > > 
> > > 
> > > Preliminary:
> > > 
> > > Lots of
> > > 
> > > lib/string.c:31:32: fatal error: asm/word-at-a-time.h
> > > 
> > > affecting several architectures.
> > > 
> > > alpha:
> > > 
> > > lib/string.c:217:4: error: implicit declaration of function 'zero_bytemask'
> > 
> > Hm, I think I need to add c753bf34c94e ("word-at-a-time.h: support
> > zero_bytemask() on alpha and tile"), right?  Any other arches failing?
> > 
> 
> Yes, you could say so. Is the offending patch really needed ?

The offending patch is for a subsystem that no one really uses, _but_
getting strscpy() into 3.18 is a good thing based on what I have seen
being used by the different vendor trees that rely on 3.18 at the
moment.

As proof of that, I did this backport a few weeks ago and didn't get it
correct :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

Page 1 of 2  [1] 2  Next page →

Back to top | Article view | linux.kernel

csiph-web